All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Luis Chamberlain <mcgrof@kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers
Date: Wed, 13 Apr 2022 10:40:47 +0200	[thread overview]
Message-ID: <YlaMjz7SoctkLzYo@apples> (raw)
In-Reply-To: <YlZ8j70shRKv/tif@x1-carbon>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Apr 13 07:34, Niklas Cassel wrote:
> On Wed, Apr 13, 2022 at 06:49:05AM +0200, Christoph Hellwig wrote:
> > Qemu unconditionally reports a UUID, which depending on the qemu version
> 
> Since it appears that both older and current QEMU versions are not
> implementing this properly, perhaps you should also consider adding
> the pci vendor and device id used by older QEMU versions?
> 
> QEMU nvme pci vendor and device id was changed in commit:
> https://github.com/qemu/qemu/commit/6eb7a071292a2f11065127ac152fa24248806021
> 
> Which was first included in QEMU v5.2.0.
> 

That is a good point Niklas. +1 for that. The driver already knows about
that ID.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-04-13  8:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  4:49 quirk broken namespace identifiers v2 Christoph Hellwig
2022-04-13  4:49 ` [PATCH 1/3] nvme: add a quirk to disable namespace identifiers Christoph Hellwig
2022-04-13  4:49 ` [PATCH 2/3] nvme-pci: disable namespace identifiers for the MAXIO MAP1002/1202 Christoph Hellwig
2022-04-13  4:49 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-13  7:34   ` Niklas Cassel
2022-04-13  8:40     ` Klaus Jensen [this message]
2022-04-13 15:34       ` Christoph Hellwig
2022-04-13 15:49         ` Klaus Jensen
2022-04-13 15:50           ` Christoph Hellwig
2022-04-13 20:08             ` Klaus Jensen
2022-04-13 20:38               ` Keith Busch
2022-04-14  4:19               ` Christoph Hellwig
2022-04-13 14:42 ` quirk broken namespace identifiers v2 Keith Busch
  -- strict thread matches above, loose matches on Subject: below --
2022-04-12  6:11 quirk broken namespace identifiers Christoph Hellwig
2022-04-12  6:11 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-12  6:33   ` Klaus Jensen
2022-04-12 11:45     ` Christoph Hellwig
2022-04-12 20:43       ` Klaus Jensen
2022-04-12 10:25   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlaMjz7SoctkLzYo@apples \
    --to=its@irrelevant.dk \
    --cc=Niklas.Cassel@wdc.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.