From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31CCEC433F5 for ; Wed, 13 Apr 2022 18:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w4A5fOnsxAxrZnyPv8aWjJF+QwYbKHR/wfASCxtIFbw=; b=MhBDEH3/9+nMMH 7KlS4nXLeopPJsA+Vu2FApOYY4LCP0bqu24NbBH+T2HzOJllubfST9upgcesxx6ZMrOepW3TI5smf PPWRuAitgEf4ffQUo2ze61CT9zmxbgX+6x8PocevkjDnnWVlnj1STicf15++HSIOV+RVhrT9zbX0S ETk4sSTrODBlycFxY3ezKRNMrmv4iBZJCz0gbQ8kV2krnIbKVaqZe8v1OyKbVrQC5Ueakq4W59ysr fxfOPw4tU6bXUan3prRil1GVkvoWSnOY4IzOhPWkVfcsUL8rBajNR7pJIJbojsZHZJrX4t4bHSfxW vfst7jVIMzhA7YLuq7Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nehZ3-0023B8-Ab; Wed, 13 Apr 2022 18:18:01 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nehZ0-0022tE-Dc for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 18:17:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HxPOUYv7EmbmrJwBdBPDOuvufBM1cpO1GfOJU8ONIEE=; b=IgboSqT8PTv9CItQUJPuLEMVaJ JVyE67D4sBlOF1t+2Dyt+LlBgfZwtSedHrYruNTGus83/T2uSjBsNUY0vmCZdylADjwqMpOtt+0Qk 9g7yirhmeZKiKSNDeRcqMt3dDcLbXS0cwbCUjOC1Ne9oReVOYBsX8WK8PlLW2s3YrDqZtI5cKbtsi Ctf/Pi6e5z/erhBEtnGEbv3FIefN0YgIsa04VZaYPpLvIKGZT3AVgypp1zWD50I8H5GMQST7KIr3F SkEfaymDyDFcZdyhxap9+tSLwmRYocW2Khj+lOc7pfn76L6gtc/jNUs0dsZfJwrnaOflTy60dRGgV B+1cColA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58248) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nehWx-0003Vh-7D; Wed, 13 Apr 2022 19:15:50 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nehWv-0003Yz-54; Wed, 13 Apr 2022 19:15:49 +0100 Date: Wed, 13 Apr 2022 19:15:49 +0100 From: "Russell King (Oracle)" To: James Morse Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Catalin Marinas , Will Deacon Subject: Re: [PATCH v2 2/2] ARM: Remove AES hwcap for parts affected by errata Message-ID: References: <20220413170545.3042558-1-james.morse@arm.com> <20220413170545.3042558-3-james.morse@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220413170545.3042558-3-james.morse@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_111758_494729_0F38462A X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 06:05:45PM +0100, James Morse wrote: > Cortex-A57 and Cortex-A72 have an erratum where an interrupt that > occurs between a pair of AES instructions in aarch32 mode may corrupt > the ELR. The task will subsequently produce the wrong AES result. > > The AES instructions are part of the cryptographic extensions, which are > optional. User-space software will detect the support for these > instructions from the hwcaps. If the platform doesn't support these > instructions a software implementation should be used. > > Remove the hwcap bits on affected parts to indicate user-space should > not use the AES instructions. > > Signed-off-by: James Morse Thanks James. LGTM. In time, can you drop this in the patch system please? I'm guessing we're only going to have Ard's ack on this. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel