All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation/RelNotes: fix a typo in 2.36's relnotes
Date: Wed, 13 Apr 2022 17:46:03 -0400	[thread overview]
Message-ID: <YldEmwQfLo2LbDGZ@nand.local> (raw)
In-Reply-To: <xmqqczhk7klg.fsf@gitster.g>

On Wed, Apr 13, 2022 at 02:13:31PM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > Signed-off-by: Taylor Blau <me@ttaylorr.com>
> > ---
> > Noticed while reading the RelNotes for GitHub's release highlights blog
> > post.
>
> Thanks as always for highlighting more interesting bits from the
> flat-and-bland-list-of-changes which is what I prepare as the
> release notes.

It's a pleasure to do. Thanks for maintaining the release notes in the
meantime which make my job much easier to do.

> > - * A not-so-common mistake is to write a script to feed "git bisect
> > + * A not-so-uncommon mistake is to write a script to feed "git bisect
> >     run" without making it executable, in which case all tests will
>
> I actually meant that this is "not a common mistake that deserves our
> bandwidth but because a change was already made to help such a case,
> why not take it".

Ha! I wasn't sure if that's what you meant or not. I think your
suggestion below is an appropriate way to remove the ambiguity. Thanks.

> We can probably rewrite _without_ mentioning our expectation of how
> common it would be.
>
>     A user can forget to make a script file executable before giving
>     it to "git bisect run".  In such a case, all tests will exit ...

Looks good to me.

Thanks,
Taylor

      reply	other threads:[~2022-04-13 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 21:03 [PATCH] Documentation/RelNotes: fix a typo in 2.36's relnotes Taylor Blau
2022-04-13 21:13 ` Junio C Hamano
2022-04-13 21:46   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YldEmwQfLo2LbDGZ@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.