From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86D8C4332F for ; Fri, 15 Apr 2022 06:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350497AbiDOGed (ORCPT ); Fri, 15 Apr 2022 02:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243518AbiDOGea (ORCPT ); Fri, 15 Apr 2022 02:34:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 019FAA7740; Thu, 14 Apr 2022 23:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AlSJrh/9aVdD6cccT4WMJlmUmFpg/2qtlWCw6b8UaS8=; b=C85NOtrZeDmbcQIJtBMn+UH4yg wAE14ydK2cPQcvA6sTvku0725EUU2bbJWA2cYyN2u9LD4UJOa+yettotZc5rO0g7KnNlAyEFW16K7 hg62RpMXTl5L/Yz0ZYkSxPWqx4oLJIlSXpL8KvoAtrWQbcNeOrvmbCbY8xelRO/gbyF/UpQ01jPQF vJyVmnMhijlVS9O0NhmANtGNZ10CI+W+5CaLCIQOAn8ZlhswxHSjFe9g7rb8uVHo2NaJLGMqQBTe6 ptdU5ynL/jRR9whMLC6m2YXic1KtNhebfGx23pgAY/mQ2xg/CVO6JVuLS5twqV8+8KH8I53Xfnnkr B8r2XJbw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfFUx-0090pQ-Gn; Fri, 15 Apr 2022 06:32:03 +0000 Date: Thu, 14 Apr 2022 23:32:03 -0700 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com, mcgrof@kernel.org Subject: Re: [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash Message-ID: References: <20220414195914.1648345-1-song@kernel.org> <20220414195914.1648345-3-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414195914.1648345-3-song@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 12:59:12PM -0700, Song Liu wrote: > Use __vmalloc_huge() in alloc_large_system_hash() so that large system > hash (>= PMD_SIZE) could benefit from huge pages. Note that __vmalloc_huge > only allocates huge pages for systems with HAVE_ARCH_HUGE_VMALLOC. Looks good (modulo the possible naming chane suggested in patch 1): Reviewed-by: Christoph Hellwig