From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABEDBC433EF for ; Sun, 17 Apr 2022 08:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbiDQIiz (ORCPT ); Sun, 17 Apr 2022 04:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbiDQIiu (ORCPT ); Sun, 17 Apr 2022 04:38:50 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14E2763F5 for ; Sun, 17 Apr 2022 01:36:16 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ng0Nx-003jSQ-Oq; Sun, 17 Apr 2022 18:35:59 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sun, 17 Apr 2022 16:35:58 +0800 Date: Sun, 17 Apr 2022 16:35:58 +0800 From: Herbert Xu To: Catalin Marinas Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 17, 2022 at 09:31:09AM +0100, Catalin Marinas wrote: > > Not with my series, the non-sharing of cache lines is preserved. > kmalloc() still returns objects aligned to a cache-line. > ARCH_DMA_MINALIGN was chosen as the cover-all value for all SoCs > supported but I want to reduce the kmalloc() alignment to a cache line > size if a platform has a cache line smaller than ARCH_DMA_MINALIGN (most > arm64 SoCs have a cache line of 64 bytes rather than 128). OK, but then you don't need to play with CRYPTO_MINALIGN at all, right? All you need to do is add the padding between the Crypto API fields and the context structure, right? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3376AC433EF for ; Sun, 17 Apr 2022 08:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lfd6xgKzVJQ3lXj8oz6WDnkzBf3awk8mtpVTsVIY6RM=; b=TNa0/HnDl+BlfK InX7py8Pa/4wQFiCqeLceu1/0VhCFbB/YBp6iM/MVZzQOTNYhkpwNEvB2ZuNlSCa7xK6PI6Rv+NYD pSn2Sxe3D/7czTwg6eNNbf9pCrGdaRx8t62SGKa6qrPh7uRuF7gqw98z623EobMQRV5+TX9RqEo+1 SxU+ggXt5jNV5tDpPS8H109e7w8GUETxrSCY46ZJF9DtGmcfQ+ha/9WNkOhzh5JtwtFc0hX96VxdY g9EoEjHPpfo5yeb6evcvyOAhuJPXEub97MC8MoAi2AmqbLrKdnGwr5zpz651Owlbjmmh9BiDrKdtS vV3XPa/84hXgXcqEw+3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng0OI-00E69y-I7; Sun, 17 Apr 2022 08:36:18 +0000 Received: from helcar.hmeau.com ([216.24.177.18] helo=fornost.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng0OF-00E696-MI for linux-arm-kernel@lists.infradead.org; Sun, 17 Apr 2022 08:36:17 +0000 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ng0Nx-003jSQ-Oq; Sun, 17 Apr 2022 18:35:59 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sun, 17 Apr 2022 16:35:58 +0800 Date: Sun, 17 Apr 2022 16:35:58 +0800 From: Herbert Xu To: Catalin Marinas Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_013615_759759_B607B986 X-CRM114-Status: GOOD ( 12.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 17, 2022 at 09:31:09AM +0100, Catalin Marinas wrote: > > Not with my series, the non-sharing of cache lines is preserved. > kmalloc() still returns objects aligned to a cache-line. > ARCH_DMA_MINALIGN was chosen as the cover-all value for all SoCs > supported but I want to reduce the kmalloc() alignment to a cache line > size if a platform has a cache line smaller than ARCH_DMA_MINALIGN (most > arm64 SoCs have a cache line of 64 bytes rather than 128). OK, but then you don't need to play with CRYPTO_MINALIGN at all, right? All you need to do is add the padding between the Crypto API fields and the context structure, right? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel