All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Marcin Wojtas <mw@semihalf.com>
Cc: Baruch Siach <baruch@tkos.co.il>, netdev <netdev@vger.kernel.org>,
	Baruch Siach <baruch.siach@siklu.com>
Subject: Re: [PATCH] net: mvpp2: add delay at the end of .mac_prepare
Date: Sun, 1 May 2022 12:34:44 +0100	[thread overview]
Message-ID: <Ym5wVDVcNe3kOjX9@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAPv3WKf5dnOrzkm6uaFYHkuZZ2ANrr3PMNrUhU5SV6TFAJE2Qw@mail.gmail.com>

On Thu, Apr 28, 2022 at 10:59:59AM +0200, Marcin Wojtas wrote:
> Hi Baruch,
> 
> Thank you for the patch and debug effort, however at first glance it
> seems that adding delay may be a work-around and cover an actual root
> cause (maybe Russell will have more input here).

Please note I'm on a boat suffering diesel bug (means I'm running off
limited battery power which has to last until Wednesday for more vital
services, so I'm only around sporadically as the situation permits.
It's basically exactly an Apollo 13 situation - everything's turned
off except when absolutely required!)

Early revisions of the 88x3310 firmware have problems when switching
between the different MAC-side link modes. When this occurs, the PHY
firmware flashes one (iirc yellow) LED rapidly and refuses to link.

The answer is not to add random delays to the MAC driver, but get
the firmware of the MAC updated to something way less buggy - and
those early firmwares do contain a lot of bugs.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  parent reply	other threads:[~2022-05-01 11:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 15:05 [PATCH] net: mvpp2: add delay at the end of .mac_prepare Baruch Siach
2022-04-28  8:59 ` Marcin Wojtas
2022-04-28 10:59   ` Baruch Siach
2022-04-28 16:38     ` Marcin Wojtas
2022-04-28 20:03       ` Baruch Siach
2022-05-01  7:46         ` Baruch Siach
2022-05-01  8:23           ` Marcin Wojtas
2022-05-01  8:28             ` Baruch Siach
2022-05-01 11:44         ` Russell King (Oracle)
2022-05-01 11:45           ` Baruch Siach
2022-05-01 11:37     ` Russell King (Oracle)
2022-05-01 11:34   ` Russell King (Oracle) [this message]
2022-04-28 14:28 ` Jakub Kicinski
2022-04-28 16:29   ` Marcin Wojtas
2022-05-01 11:30 ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ym5wVDVcNe3kOjX9@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=baruch.siach@siklu.com \
    --cc=baruch@tkos.co.il \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.