On Wed, Apr 20, 2022 at 02:18:52AM +0000, Miaoqian Lin wrote: > This will call twice platform_device_put() > if both platform_device_add() and snd_soc_register_card() fails. > return early on error to avoid duplicating the error code logic. > > Signed-off-by: Miaoqian Lin > --- > changes in v2: > - use return statement to return early when fails > - rebase on top of commit 559089e0a93d ("vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP") Why rebase on top of that seemingly random commit? Is there some sort of dependency here?