From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35021C433EF for ; Wed, 20 Apr 2022 13:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378769AbiDTNDi (ORCPT ); Wed, 20 Apr 2022 09:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378786AbiDTNDa (ORCPT ); Wed, 20 Apr 2022 09:03:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 917E841FB3 for ; Wed, 20 Apr 2022 06:00:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D71D461A10 for ; Wed, 20 Apr 2022 13:00:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB68DC385A1; Wed, 20 Apr 2022 13:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650459629; bh=GgFN/NG7MZ+CMRVLpa6/uG+FQSLb79x6dY9Ok/gLJm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qDqR1lgYVZDVjAXFl780znRq+EzCZQtAuBgWRXdWCJ7Bt5zV6QFyJ2NG0pkhDpG8B bNSbR3XnDAZK+jYXEc7zQl9PFxkDbITb2BsAmp40ALkiUU2tbWu3YbbCEPWBEcgehD e1Y4AM575lwbs6h7I8cVT0E+FPqZA8WPD/h9puvOwtU/3wTDp1nEVs9KjH/ifeZS9g 6anzzGmEqB7iSeCo9MUEvPoOFCasBEkvfz4F6EXUF/jNA05CgsVj9znVEp3JcHD0sw xBbBjLqWeT48cOXw2HnflRuZqIi/ySnN4gMHeLRep2MFiziRWusSFPVsXRirIB1din yhMrE2DCoqX1g== Date: Wed, 20 Apr 2022 14:00:24 +0100 From: Mark Brown To: Miaoqian Lin Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: fsl: Fix error handling in pcm030_fabric_probe Message-ID: References: <20220420021855.8224-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="efKG2CWXr2Wpj9k0" Content-Disposition: inline In-Reply-To: <20220420021855.8224-1-linmq006@gmail.com> X-Cookie: Will it improve my CASH FLOW? Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --efKG2CWXr2Wpj9k0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 20, 2022 at 02:18:52AM +0000, Miaoqian Lin wrote: > This will call twice platform_device_put() > if both platform_device_add() and snd_soc_register_card() fails. > return early on error to avoid duplicating the error code logic. >=20 > Signed-off-by: Miaoqian Lin > --- > changes in v2: > - use return statement to return early when fails > - rebase on top of commit 559089e0a93d ("vmalloc: replace VM_NO_HUGE_VMAP= with VM_ALLOW_HUGE_VMAP") Why rebase on top of that seemingly random commit? Is there some sort of dependency here? --efKG2CWXr2Wpj9k0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJgA+cACgkQJNaLcl1U h9DFwAf9GF3I/YlhSyVTcxq76mzScrKVify5IYug75y6034V/V8EfvQpAl74iFSA j/ojJnAVUN/zwIlJArD+ODRonrsps1Ie9t44AgGOZPvRkniOTvgCjZAJAzTF5gzI lKevcKZKOTCu30CRsLDQIpozLNGaZHqg108ppkn3pbc+tqL08oBJt4fdGTI7EVhV eyMPbXa5DGuSSed5CY8zWiHRB7Kr31I20izJje8j92n4UkEvUMnvaUStFXHPVZWo 4z7amWIBtXixq7Kyh6APPmp6cb5jKJv3RFblBzFdbz62n5qFD1erZtzKGja70WT5 j4tg4q5ZVOWv5BVFAnI1ZpCtSSB8/A== =wBgb -----END PGP SIGNATURE----- --efKG2CWXr2Wpj9k0-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1D31C433F5 for ; Wed, 20 Apr 2022 13:01:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5F4681A22; Wed, 20 Apr 2022 15:00:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5F4681A22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650459688; bh=GgFN/NG7MZ+CMRVLpa6/uG+FQSLb79x6dY9Ok/gLJm4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pafHJYB+EFUzILW2o80CUKbT/9gO7uszcWzPNy+FniT6Mv2NrMhZfTAdHEgO7SCR9 dzVZLq0owPrueKI4ve1fAFBgvdtuZtajio9RL9tKOkdujzVGpi5+Qn1g0/2znkIQm+ 4MHv8Y1O4QXbvDMWuealYue5u1SnFuIVjt7oZGE0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DE8ABF800C1; Wed, 20 Apr 2022 15:00:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2A345F80125; Wed, 20 Apr 2022 15:00:36 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9E040F800C1 for ; Wed, 20 Apr 2022 15:00:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9E040F800C1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qDqR1lgY" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F375C61A05; Wed, 20 Apr 2022 13:00:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB68DC385A1; Wed, 20 Apr 2022 13:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650459629; bh=GgFN/NG7MZ+CMRVLpa6/uG+FQSLb79x6dY9Ok/gLJm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qDqR1lgYVZDVjAXFl780znRq+EzCZQtAuBgWRXdWCJ7Bt5zV6QFyJ2NG0pkhDpG8B bNSbR3XnDAZK+jYXEc7zQl9PFxkDbITb2BsAmp40ALkiUU2tbWu3YbbCEPWBEcgehD e1Y4AM575lwbs6h7I8cVT0E+FPqZA8WPD/h9puvOwtU/3wTDp1nEVs9KjH/ifeZS9g 6anzzGmEqB7iSeCo9MUEvPoOFCasBEkvfz4F6EXUF/jNA05CgsVj9znVEp3JcHD0sw xBbBjLqWeT48cOXw2HnflRuZqIi/ySnN4gMHeLRep2MFiziRWusSFPVsXRirIB1din yhMrE2DCoqX1g== Date: Wed, 20 Apr 2022 14:00:24 +0100 From: Mark Brown To: Miaoqian Lin Subject: Re: [PATCH v2] ASoC: fsl: Fix error handling in pcm030_fabric_probe Message-ID: References: <20220420021855.8224-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="efKG2CWXr2Wpj9k0" Content-Disposition: inline In-Reply-To: <20220420021855.8224-1-linmq006@gmail.com> X-Cookie: Will it improve my CASH FLOW? Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --efKG2CWXr2Wpj9k0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 20, 2022 at 02:18:52AM +0000, Miaoqian Lin wrote: > This will call twice platform_device_put() > if both platform_device_add() and snd_soc_register_card() fails. > return early on error to avoid duplicating the error code logic. >=20 > Signed-off-by: Miaoqian Lin > --- > changes in v2: > - use return statement to return early when fails > - rebase on top of commit 559089e0a93d ("vmalloc: replace VM_NO_HUGE_VMAP= with VM_ALLOW_HUGE_VMAP") Why rebase on top of that seemingly random commit? Is there some sort of dependency here? --efKG2CWXr2Wpj9k0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJgA+cACgkQJNaLcl1U h9DFwAf9GF3I/YlhSyVTcxq76mzScrKVify5IYug75y6034V/V8EfvQpAl74iFSA j/ojJnAVUN/zwIlJArD+ODRonrsps1Ie9t44AgGOZPvRkniOTvgCjZAJAzTF5gzI lKevcKZKOTCu30CRsLDQIpozLNGaZHqg108ppkn3pbc+tqL08oBJt4fdGTI7EVhV eyMPbXa5DGuSSed5CY8zWiHRB7Kr31I20izJje8j92n4UkEvUMnvaUStFXHPVZWo 4z7amWIBtXixq7Kyh6APPmp6cb5jKJv3RFblBzFdbz62n5qFD1erZtzKGja70WT5 j4tg4q5ZVOWv5BVFAnI1ZpCtSSB8/A== =wBgb -----END PGP SIGNATURE----- --efKG2CWXr2Wpj9k0--