[PATCH blktests] block/002: delay debugfs directory check

* [PATCH blktests] block/002: delay debugfs directory check
@ 2022-04-20  4:59 Shin'ichiro Kawasaki
  2022-04-20  7:46 ` Johannes Thumshirn
  2022-04-20  9:34 ` Ming Lei
  0 siblings, 2 replies; 12+ messages in thread
From: Shin'ichiro Kawasaki @ 2022-04-20  4:59 UTC (permalink / raw)
  To: linux-block, Omar Sandoval
  Cc: Omar Sandoval, Ming Lei, Damien Le Moal, Johannes Thumshirn,
	Shin'ichiro Kawasaki

The test case block/002 checks that device removal during blktrace run
does not leak debugfs directory. The Linux kernel commit 0a9a25ca7843
("block: let blkcg_gq grab request queue's refcnt") triggered failure of
the test case. The commit delayed queue release and debugfs directory
removal then the test case checks directory existence too early. To
avoid this false-positive failure, delay the directory existence check.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 tests/block/002 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/block/002 b/tests/block/002
index 9b183e7..8061c91 100755
--- a/tests/block/002
+++ b/tests/block/002
@@ -29,6 +29,7 @@ test() {
 		echo "debugfs directory deleted with blktrace active"
 	fi
 	{ kill $!; wait; } >/dev/null 2>/dev/null
+	sleep 0.5
 	if [[ -d /sys/kernel/debug/block/${SCSI_DEBUG_DEVICES[0]} ]]; then
 		echo "debugfs directory leaked"
 	fi
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread