From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8B7C433EF for ; Wed, 20 Apr 2022 19:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381994AbiDTUAW (ORCPT ); Wed, 20 Apr 2022 16:00:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382006AbiDTUAM (ORCPT ); Wed, 20 Apr 2022 16:00:12 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF5E34924D for ; Wed, 20 Apr 2022 12:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b/p/Pjr5ZywCNRBqubhs8uK52pTLU/Q0ZMynjR0pwhI=; b=xiPcXnF2h5/X9LrJIi3nOEb7hu Zi9mqyZh6s9RbnMDR61YWHMPPrSy5sRe+VleUOeWrCLCPDnMURKQkea2Wh3HvrdXxGkiYVEW7VuPK zQ5E5XI5b4gkmYya/zjQ2UUIo8JU2JFJoGgl9ptSW1RPJymy8n2CZJSRyfyXuPFaB1zWcuiclxrru 185qn4IJuyEegx/EBCpBeFzkwIMt8ur9smFW31n9k4HkWyOjSYUSa/y3SWIKNrcI6LOL59vkF8DhU UOJgzWJAnEDPT943XWzJAji2o0qt/prkbYG2x+YOnXF5tSr5hbofNVEMwpacNi/6d9F5x/mejpXaN uknQXv5Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhGRI-00AGT4-M0; Wed, 20 Apr 2022 19:56:36 +0000 Date: Wed, 20 Apr 2022 12:56:36 -0700 From: Luis Chamberlain To: Tonghao Zhang Cc: Jakub Kicinski , Kees Cook , Iurii Zaikin , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Simon Horman , Julian Anastasov , Pablo Neira Ayuso , Jozsef Kadlecsik , Linux Kernel Network Developers , Florian Westphal , Dmitry Vyukov , Alexei Starovoitov , Eric Dumazet , Marc Kleine-Budde , Lorenz Bauer , Akhmat Karakotov Subject: Re: [PATCH v3 2/2] net: sysctl: introduce sysctl SYSCTL_THREE Message-ID: References: <20220415163912.26530-1-xiangxia.m.yue@gmail.com> <20220415163912.26530-3-xiangxia.m.yue@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 20, 2022 at 08:43:14PM +0800, Tonghao Zhang wrote: > On Sat, Apr 16, 2022 at 12:40 AM wrote: > > > > From: Tonghao Zhang > > > > This patch introdues the SYSCTL_THREE. > Hi Luis, Jakub > any thoughts? I have fixed v2. > > KUnit: > > [00:10:14] ================ sysctl_test (10 subtests) ================= > > [00:10:14] [PASSED] sysctl_test_api_dointvec_null_tbl_data > > [00:10:14] [PASSED] sysctl_test_api_dointvec_table_maxlen_unset > > [00:10:14] [PASSED] sysctl_test_api_dointvec_table_len_is_zero > > [00:10:14] [PASSED] sysctl_test_api_dointvec_table_read_but_position_set > > [00:10:14] [PASSED] sysctl_test_dointvec_read_happy_single_positive > > [00:10:14] [PASSED] sysctl_test_dointvec_read_happy_single_negative > > [00:10:14] [PASSED] sysctl_test_dointvec_write_happy_single_positive > > [00:10:14] [PASSED] sysctl_test_dointvec_write_happy_single_negative > > [00:10:14] [PASSED] sysctl_test_api_dointvec_write_single_less_int_min > > [00:10:14] [PASSED] sysctl_test_api_dointvec_write_single_greater_int_max > > [00:10:14] =================== [PASSED] sysctl_test =================== > > > > ./run_kselftest.sh -c sysctl > > ... > > ok 1 selftests: sysctl: sysctl.sh > > > > Cc: Luis Chamberlain > > Cc: Kees Cook > > Cc: Iurii Zaikin > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Hideaki YOSHIFUJI > > Cc: David Ahern > > Cc: Simon Horman > > Cc: Julian Anastasov > > Cc: Pablo Neira Ayuso > > Cc: Jozsef Kadlecsik > > Cc: Florian Westphal > > Cc: Dmitry Vyukov > > Cc: Alexei Starovoitov > > Cc: Eric Dumazet > > Cc: Marc Kleine-Budde > > Cc: Lorenz Bauer > > Cc: Akhmat Karakotov > > Signed-off-by: Tonghao Zhang It would be good for you to also have a separate patch which extends the selftest for sysctl which tests that each of the values always matches, I thought we had that test already, if not one needs to be added for this. That should be the first patch. The second one would add this as you are here in this patch, and the last one adds the new SYSCTL_THREE to the selftest. Otherwise looks good to me. Happy to route this via sysclt-next if Jacub is OK with that. Luis