From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE3DC433F5 for ; Wed, 20 Apr 2022 22:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382754AbiDTWDV (ORCPT ); Wed, 20 Apr 2022 18:03:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345336AbiDTWDU (ORCPT ); Wed, 20 Apr 2022 18:03:20 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BB6B140E4; Wed, 20 Apr 2022 15:00:32 -0700 (PDT) Received: from zn.tnic (p200300ea971b58ed329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:58ed:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B112E1EC0373; Thu, 21 Apr 2022 00:00:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1650492026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FTI0nvLkj3mQQgBgshh/GftzMREn/VptyZIk8yqNZsc=; b=gNN4FBttiA59A0dnHly31tuR0HGkjNXyMm+t1Z38iUySSuPy6BkNAXd2fEbUgJaWo8T4za 0/79kGFPzuNJmo+bhmB+bpcxoHlq/7ttYlef2BPlEi1iV4YmaABMCR1FkyLvzXdFgDwRYA WCTQJHNsYcVt5VEOPcMNJsqJoz8YmOo= Date: Thu, 21 Apr 2022 00:00:22 +0200 From: Borislav Petkov To: Sathyanarayanan Kuppuswamy Cc: Kai Huang , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Hans de Goede , Mark Gross , "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver Message-ID: References: <20220415220109.282834-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220415220109.282834-5-sathyanarayanan.kuppuswamy@linux.intel.com> <9198cc36-67d6-9365-5d18-f23ba4075151@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9198cc36-67d6-9365-5d18-f23ba4075151@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022 at 05:48:57AM -0700, Sathyanarayanan Kuppuswamy wrote: > Make sense. We can just go with CONFIG_INTEL_TDX_ATTESTATION. Sounds like you didn't read my mail. Kai was questioning the need for a Kconfig symbol at all. And me too. If this thing is not going to be used by anything else besides TDX guests, why does it need a Kconfig option at all?! > Boris, this is a simple platform driver which adds IOCTL interfaces to allow > user space to get TDREPORT and TDQuote support. > > So, would prefer to leave in platform/x86 or move it to arch/x86/coco/tdx/ ? See above. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette