From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72715C433EF for ; Thu, 21 Apr 2022 06:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383415AbiDUGe5 (ORCPT ); Thu, 21 Apr 2022 02:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242783AbiDUGex (ORCPT ); Thu, 21 Apr 2022 02:34:53 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8BE8513F36; Wed, 20 Apr 2022 23:32:05 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F2B92811B; Thu, 21 Apr 2022 06:29:13 +0000 (UTC) Date: Thu, 21 Apr 2022 09:32:03 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: linux-omap@vger.kernel.org, aaro.koskinen@iki.fi, jmkrzyszt@gmail.com, Arnd Bergmann , Russell King , Paul Walmsley , Kevin Hilman , Peter Ujfalusi , Vinod Koul , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Mark Brown , Felipe Balbi , Alan Stern , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Linus Walleij , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dmaengine@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 24/41] ARM: omap: un-merge plat/sram.c Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-25-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-25-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org * Arnd Bergmann [220419 13:37]: > From: Arnd Bergmann > > The sram initialization code is the only shared omap1/2 code that > is not a standalone driver, but it is very short. Having two copies > of this code means some duplication of the sources, but actually > saves object code size as it can be inlined better. FYI, the sram code should eventually be updated to use drivers/misc/sram.c, I recall there being some issues to deal with for PM related code though. Probably the PM related save and restore could be now handled with cpu_pm. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6672AC433F5 for ; Thu, 21 Apr 2022 06:32:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79A5810F4B8; Thu, 21 Apr 2022 06:32:07 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id B712E10F4B8 for ; Thu, 21 Apr 2022 06:32:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F2B92811B; Thu, 21 Apr 2022 06:29:13 +0000 (UTC) Date: Thu, 21 Apr 2022 09:32:03 +0300 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH 24/41] ARM: omap: un-merge plat/sram.c Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-25-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-25-arnd@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, Dominik Brodowski , Lee Jones , Daniel Thompson , aaro.koskinen@iki.fi, Peter Ujfalusi , Helge Deller , jmkrzyszt@gmail.com, Russell King , Krzysztof Kozlowski , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann , Mark Brown , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, alsa-devel@alsa-project.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Arnd Bergmann [220419 13:37]: > From: Arnd Bergmann > > The sram initialization code is the only shared omap1/2 code that > is not a standalone driver, but it is very short. Having two copies > of this code means some duplication of the sources, but actually > saves object code size as it can be inlined better. FYI, the sram code should eventually be updated to use drivers/misc/sram.c, I recall there being some issues to deal with for PM related code though. Probably the PM related save and restore could be now handled with cpu_pm. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAF28C433EF for ; Thu, 21 Apr 2022 06:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MtnVgBFXKpAli8qaMF6IpuIloqbUXoY55g8xZLwv8NE=; b=TUM17R0OLieDZu I4Zve/nZT/YcQRKuKSpfgg8RslLQV6GziOv71Km85hCneVHo0R92y6FnwmYtL2LugtPQeYKeCh/vG BYqqnUcapTF5iLDPhQXfqAMO7ptBYRplYmoLTutnGSmH5ZkU9QVubYnptlMqCxU/z1/qHPZqnEgEz 9DmQLw+4v5Ba2aRxhbWsEVmwjlR2mmvBvyM4OXJhB6tVNBBL6tRhg0PVEwzE6H40CmJPvYX44x3Lm hsIF/aMuIHGAj50GGbBibF3PrVnO/+1O1/1NeV4T1NUN7yJC0D8qf8ZhQWxLqlMv6yUDiSBLYx6gI DRqVzHe3oHb/GM0JqSCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQMK-00BkAj-Nt; Thu, 21 Apr 2022 06:32:08 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQMH-00BkAC-Qo for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 06:32:07 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F2B92811B; Thu, 21 Apr 2022 06:29:13 +0000 (UTC) Date: Thu, 21 Apr 2022 09:32:03 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: linux-omap@vger.kernel.org, aaro.koskinen@iki.fi, jmkrzyszt@gmail.com, Arnd Bergmann , Russell King , Paul Walmsley , Kevin Hilman , Peter Ujfalusi , Vinod Koul , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Mark Brown , Felipe Balbi , Alan Stern , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Linus Walleij , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dmaengine@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 24/41] ARM: omap: un-merge plat/sram.c Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-25-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419133723.1394715-25-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_233205_942189_75C9FC07 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [220419 13:37]: > From: Arnd Bergmann > > The sram initialization code is the only shared omap1/2 code that > is not a standalone driver, but it is very short. Having two copies > of this code means some duplication of the sources, but actually > saves object code size as it can be inlined better. FYI, the sram code should eventually be updated to use drivers/misc/sram.c, I recall there being some issues to deal with for PM related code though. Probably the PM related save and restore could be now handled with cpu_pm. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34CD4C433F5 for ; Fri, 22 Apr 2022 13:55:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 748FA1836; Fri, 22 Apr 2022 15:54:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 748FA1836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650635731; bh=5zjK5wHKcm1de7G6sWuf2Gc7nE0DPY9MyYrx8JMWNJw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vN6vvcMAUOu9hTf8kshNmZl6daE8p3VzuAPS9fjnAoV1nMrB+lko1jc+DUjPC+OrF EwpHZGboutF7Dcb3g98J7gvQUEwS2PTS5ZBgqkWUfaano8Fa4rEyg+9jXHBzHBAop/ QQTboWErIKKd3JGxg2UwxCafTrQFUQh4Jx6fEZes= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A2E6FF80C22; Fri, 22 Apr 2022 15:32:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E284DF80279; Thu, 21 Apr 2022 08:32:14 +0200 (CEST) Received: from muru.com (muru.com [72.249.23.125]) by alsa1.perex.cz (Postfix) with ESMTP id 9BE28F800F4 for ; Thu, 21 Apr 2022 08:32:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9BE28F800F4 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F2B92811B; Thu, 21 Apr 2022 06:29:13 +0000 (UTC) Date: Thu, 21 Apr 2022 09:32:03 +0300 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH 24/41] ARM: omap: un-merge plat/sram.c Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-25-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-25-arnd@kernel.org> X-Mailman-Approved-At: Fri, 22 Apr 2022 15:31:40 +0200 Cc: Ulf Hansson , linux-usb@vger.kernel.org, Linus Walleij , linux-fbdev@vger.kernel.org, Dominik Brodowski , Lee Jones , Daniel Thompson , aaro.koskinen@iki.fi, Peter Ujfalusi , Helge Deller , jmkrzyszt@gmail.com, Russell King , Krzysztof Kozlowski , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann , Mark Brown , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Arnd Bergmann [220419 13:37]: > From: Arnd Bergmann > > The sram initialization code is the only shared omap1/2 code that > is not a standalone driver, but it is very short. Having two copies > of this code means some duplication of the sources, but actually > saves object code size as it can be inlined better. FYI, the sram code should eventually be updated to use drivers/misc/sram.c, I recall there being some issues to deal with for PM related code though. Probably the PM related save and restore could be now handled with cpu_pm. Regards, Tony