From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 820ADC433F5 for ; Thu, 21 Apr 2022 09:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRzfFU2UvQPWOx4SJj/x7uJAXuu3imBuEOLOUtgOJ2E=; b=lz0p9TXpqSjdTx IqPiex2NYfq3koOSvqLVFqOwTVKwHcdoivZXs3YRee+QeyQ8xw2xtPWCumwqyeYxlH3dGE1PccUie nPNU5Ez6NK9BHZOLXZR6fzdkkL2eQFF3llbipCy5MJFH9puruFTt3EOpUiQ7B/xpHW2glJ3ZLDWVe 4ZAB1tpmdzJNdFnZe29EwEFnl2wXlvuzQnk+pwLhfrsm8PpEduqFxYaT/xyKQXuwVnHa/zPyqpsha tZoD2BiuXuW5eBehiYq8V1usbc+t1Dnsa4MuO/hYsTjdkePqHhO3EIlslWmGELrjf9zfASsJ0b1l4 a0fRR/wfw/5eCVYpvHig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhTEX-00Cn7h-97; Thu, 21 Apr 2022 09:36:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhTET-00Cn61-Pt for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 09:36:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F7231477; Thu, 21 Apr 2022 02:36:12 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.76.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 418FA3F766; Thu, 21 Apr 2022 02:36:11 -0700 (PDT) Date: Thu, 21 Apr 2022 10:36:07 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/8] arm64/sysreg: Rename SCTLR_EL1_NTWE/TWI to SCTLR_EL1_nTWE/TWI Message-ID: References: <20220419104329.188489-1-broonie@kernel.org> <20220419104329.188489-4-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419104329.188489-4-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_023613_905235_09EE555B X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 11:43:24AM +0100, Mark Brown wrote: > We already use lower case in some defines in sysreg.h, for consistency with > the architecture definition do so for SCTLR_EL1.nTWE and SCTLR_EL1.nTWI. > > Signed-off-by: Mark Brown I have no strong feelings either way as to whether we should keep this all caps or match the architectural CamelCase, so: Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/sysreg.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 1911f36773e5..f300c49d6281 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -689,8 +689,8 @@ > #define SCTLR_EL1_UCI (BIT(26)) > #define SCTLR_EL1_E0E (BIT(24)) > #define SCTLR_EL1_SPAN (BIT(23)) > -#define SCTLR_EL1_NTWE (BIT(18)) > -#define SCTLR_EL1_NTWI (BIT(16)) > +#define SCTLR_EL1_nTWE (BIT(18)) > +#define SCTLR_EL1_nTWI (BIT(16)) > #define SCTLR_EL1_UCT (BIT(15)) > #define SCTLR_EL1_DZE (BIT(14)) > #define SCTLR_EL1_UMA (BIT(9)) > @@ -714,7 +714,7 @@ > #define INIT_SCTLR_EL1_MMU_ON \ > (SCTLR_ELx_M | SCTLR_ELx_C | SCTLR_ELx_SA | SCTLR_EL1_SA0 | \ > SCTLR_EL1_SED | SCTLR_ELx_I | SCTLR_EL1_DZE | SCTLR_EL1_UCT | \ > - SCTLR_EL1_NTWE | SCTLR_ELx_IESB | SCTLR_EL1_SPAN | SCTLR_ELx_ITFSB | \ > + SCTLR_EL1_nTWE | SCTLR_ELx_IESB | SCTLR_EL1_SPAN | SCTLR_ELx_ITFSB | \ > ENDIAN_SET_EL1 | SCTLR_EL1_UCI | SCTLR_EL1_EPAN | SCTLR_EL1_RES1) > > /* MAIR_ELx memory attributes (used by Linux) */ > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel