From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E069C433F5 for ; Thu, 21 Apr 2022 13:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oaSqFsg5IYxCdIMAOuVMUk6JAO+vxCCW46zMJ48FEPA=; b=z/YEnT107Fqc5HR0qjF78LO0k8 Ed1pMYCVLJ0SBYmTsZ6N/RWIg93t6N5gXe3CTmCBmEgaguz7UF/Rs/uaNLd+6pDuABL6rRRERchD+ x9i1etnMEDXISTc95dFWRvI/fVhc30r6IzIrbmeiHSS8cKZa4bWajPquscCudIttZxmX/WrZ6pU8c zqBS9OJmS+B/yBksQI7mB04gF3N066it2AcZCdlmmdg9p+mB8AOcqBi22J7vS8Gn4p7o0tdGzL+YD gRRXKJsB9eDXv2YOmrXR+gxxvklLDD3FQvUQaSNS+3af7Yg6g1Omm3WJBR9hD2yBPeP/koo+v4AHL 2CWWecvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhWQ9-00DToK-FA; Thu, 21 Apr 2022 13:00:29 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhWQ5-00DTn7-6t for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 13:00:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DC936B8245E; Thu, 21 Apr 2022 13:00:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2488C385A8; Thu, 21 Apr 2022 13:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650546023; bh=RBL3cSu2ucDK/5/rdF2qLYHG9D5Zt6Xr30JqlKgLJes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d73Q5Q/jJBI1jZ0P+xoFfSFPlx1VIEnkls2uFQUXaTgqkiO5yFUAu1qlUxt0CE4Zd x4+auBxBljw5bAPt1U2vg/ZonUQB22/qzOUY0oaJWwzwiPhMjHvi1ow2JJvNLWU3QU xk4ki+cCtdVAq5gQCHWseiR0oftT5xWp/dO51Npf0iOWVhXNPkky1ugLzWf/5LK4yF vvihkgtcJIfJep0H32ndWm5+ceZuZWGlXUJ7luZ38bcqpHlv3nh4cyPQRWBfC0J/ez 2C6mOgfl0RGTg9tsYIQLMSyGDFxmonvJ1EGy4NGZEuMJsMOVro+b5aG6077RMB1z2Q 1R3BYe19OeccA== Date: Thu, 21 Apr 2022 14:00:17 +0100 From: Mark Brown To: Mark Rutland Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 4/8] arm64: Add sysreg header generation scripting Message-ID: References: <20220419104329.188489-1-broonie@kernel.org> <20220419104329.188489-5-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Cookie: Two percent of zero is almost nothing. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_060025_570313_12C5E5FB X-CRM114-Status: GOOD ( 26.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6761086381886180425==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6761086381886180425== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HZM6zRsBY8JW0RJm" Content-Disposition: inline --HZM6zRsBY8JW0RJm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 21, 2022 at 10:47:42AM +0100, Mark Rutland wrote: > On Tue, Apr 19, 2022 at 11:43:25AM +0100, Mark Brown wrote: > > | #define ID_AA64ISAR0_EL1_RNDR ARM64_SYSREG_BITMASK(63, 60) > > | #define ID_AA64ISAR0_EL1_RNDR_MASK ARM64_SYSREG_BITMASK(63, 60) > I think this got missed when s/ARM64_SYSREG_BITMASK()/GENMASK_ULL()/ happened. Yes. > > | #define ID_AA64ISAR0_EL1_RNDR_SHIFT 60 > > | #define ID_AA64ISAR0_EL1_RNDR_WIDTH 4 > > | #define ID_AA64ISAR0_EL1_RNDR_NI ULL(0b0000) > > | #define ID_AA64ISAR0_EL1_RNDR_IMP ULL(0b0001) > Just to check, was there a reason for going for ULL() and GENMASK_ULL() rather > than UL() and GENMASK()? > We generally use UL() today, since we treat `unsigned long` as the native > register size. That's not been updated from what you originally had had, I think I'd just been under the impression that there was a good reason for it that wasn't apparent to me. > > The script requires that all bits in the register be specified and that > > there be no overlapping fields. This helps the script spot errors in the > > input but means that the few registers which change layout at runtime > > depending on things like virtualisation settings will need some manual > > handling. No actual register conversions are done here but a header for > > the register data with some documention of the format is provided. > It would be good to see an example of how we'd handle one of those, in case > that means we need to play around with naming or structure of the definitions a > bit. My thinking here was that we might not want to handle those registers through the automated stuff at all. I haven't yet come up with something that seems tasteful and viable for them, if I had a firm idea for what that should look like I'd probably have implemented it. --HZM6zRsBY8JW0RJm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJhVWAACgkQJNaLcl1U h9Cz1Af+OhT54A23cyxC8ZFXuCfPCGXaAUMEHchixCdGaIKwDyZDA68ItPH33hbN VDZJGAvNzZXGFL9oD2daLPsBUF3E1ZoTmnIySrT9y0S60fwHs56WVe6yj43pjBE6 6fDPUeJ31rOcWQM57EQ/v06VOTZJ3wXtXRH9afxNnce+XhaJ5V7EkTYP/GqKdSx8 EbzHO1mIr7rdHmaVlLzGQrIWD4IXRLk0ItNinjkInUY1oYufX5MfwDdhskGfo94u s96pZc1/F6VLIqqVGr9QKa6279azqtpWPTTIoeVvAmNLpUKmjHSV928HLH10jCsL 0b5utiLrq02Gd12zfahjIIa+/2Y6og== =uP/T -----END PGP SIGNATURE----- --HZM6zRsBY8JW0RJm-- --===============6761086381886180425== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6761086381886180425==--