All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues
Date: Thu, 21 Apr 2022 14:39:47 +0100	[thread overview]
Message-ID: <YmFeo7Hv3esVrBiY@sirena.org.uk> (raw)
In-Reply-To: <1j1qxqzi7g.fsf@starbuckisacylon.baylibre.com>


[-- Attachment #1.1: Type: text/plain, Size: 1406 bytes --]

On Thu, Apr 21, 2022 at 03:02:54PM +0200, Jerome Brunet wrote:
> On Thu 21 Apr 2022 at 13:38, Mark Brown <broonie@kernel.org> wrote:

> > I'm also seeing other failures due to these
> > controls having invalid values, eg:

> > # # AIU ACODEC SRC.0 value 3 more than item count 3

> > but without documentation I'm not sure how to interpret/fix these -
> > either the value should be fixed up on startup or there should be an
> > extra value there (disconnected possibly?).

> Value 3 is an I2S input from a block we don't support.
> If we did support it, it would be an hostless DPCM BE to BE link
> I'm not sure how I would represent this in ASoC TBH :/

> At the time, I thought it would be easier (for the users) to leave this
> value out and not give the false impression that the path was somehow
> supported.

> I did not realize it was the reset value nor that it would be a problem.

> I can add a element to the enum if you think it is better have it
> regardless of the actual path support. What do you think ?

I don't have strong feelings TBH - your argument for not supporting it
for now makes sense to me and we generally try to avoid changing the
hardware defaults.  Probably I'd go with changing the default but since
it's a valid value in the hardware it's most likely not too bad to leave
things as they are for now, though there might be some applications that
get confused and explode.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID
From: Mark Brown <broonie@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: alsa-devel@alsa-project.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues
Date: Thu, 21 Apr 2022 14:39:47 +0100	[thread overview]
Message-ID: <YmFeo7Hv3esVrBiY@sirena.org.uk> (raw)
In-Reply-To: <1j1qxqzi7g.fsf@starbuckisacylon.baylibre.com>

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

On Thu, Apr 21, 2022 at 03:02:54PM +0200, Jerome Brunet wrote:
> On Thu 21 Apr 2022 at 13:38, Mark Brown <broonie@kernel.org> wrote:

> > I'm also seeing other failures due to these
> > controls having invalid values, eg:

> > # # AIU ACODEC SRC.0 value 3 more than item count 3

> > but without documentation I'm not sure how to interpret/fix these -
> > either the value should be fixed up on startup or there should be an
> > extra value there (disconnected possibly?).

> Value 3 is an I2S input from a block we don't support.
> If we did support it, it would be an hostless DPCM BE to BE link
> I'm not sure how I would represent this in ASoC TBH :/

> At the time, I thought it would be easier (for the users) to leave this
> value out and not give the false impression that the path was somehow
> supported.

> I did not realize it was the reset value nor that it would be a problem.

> I can add a element to the enum if you think it is better have it
> regardless of the actual path support. What do you think ?

I don't have strong feelings TBH - your argument for not supporting it
for now makes sense to me and we generally try to avoid changing the
hardware defaults.  Probably I'd go with changing the default but since
it's a valid value in the hardware it's most likely not too bad to leave
things as they are for now, though there might be some applications that
get confused and explode.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-04-21 13:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 12:38 Mark Brown
2022-04-21 12:38 ` Mark Brown
2022-04-21 12:38 ` [PATCH v1 1/3] ASoC: meson: Fix event generation for AUI ACODEC mux Mark Brown
2022-04-21 12:38   ` Mark Brown
2022-04-21 12:38 ` [PATCH v1 2/3] ASoC: meson: Fix event generation for AUI CODEC mux Mark Brown
2022-04-21 12:38   ` Mark Brown
2022-04-21 12:38 ` [PATCH v1 3/3] ASoC: meson: Fix event generation for G12A tohdmi mux Mark Brown
2022-04-21 12:38   ` Mark Brown
2022-04-21 13:02 ` [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues Jerome Brunet
2022-04-21 13:02   ` Jerome Brunet
2022-04-21 13:39   ` Mark Brown [this message]
2022-04-21 13:39     ` Mark Brown
2022-04-21 17:24 ` Mark Brown
2022-04-21 17:24   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmFeo7Hv3esVrBiY@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --subject='Re: [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.