From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5EA23A4 for ; Fri, 22 Apr 2022 09:30:21 +0000 (UTC) Received: from zn.tnic (p200300ea971b581b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:581b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5725E1EC0373; Fri, 22 Apr 2022 11:30:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1650619815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=fr/3xj84Vj/TEZf1cZMkrVY7DcRLFp6TzUknTxfDSpc=; b=EBQ+NlmK0S0dUCbjuzPRVhMIe8rt78EeQP9rPUu0CLQVFXjErOhx+pp+GAGMrf9X6yNmvb E8Cnw33VbETp64hh3oU1zlBRc2lcXVLoomXUnc1Vp+b/fTiXNhXc7MwTzwwaytoFWbPSrW eaMdjGlodeR8SBAKePnQafG0WaFO9M0= Date: Fri, 22 Apr 2022 11:30:11 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Dave Hansen , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 3/8] efi/x86: Implement support for unaccepted memory Message-ID: References: <20220405234343.74045-1-kirill.shutemov@linux.intel.com> <20220405234343.74045-4-kirill.shutemov@linux.intel.com> <20220418155545.a567xnxa6elglapl@box.shutemov.name> <20220418202431.whvql4w57c7l5vpw@box.shutemov.name> <20220418235015.mnujtlmmlyin7y6m@box.shutemov.name> <20220422002124.lwd7b56zko24gbll@box.shutemov.name> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220422002124.lwd7b56zko24gbll@box.shutemov.name> On Fri, Apr 22, 2022 at 03:21:24AM +0300, Kirill A. Shutemov wrote: > There's still #include in misc.h. You removed one, but > there's a second one for some reason. I don't know which tree you're looking at but latest tip/master has: $ git grep -E "efi\.h" arch/x86/boot/ arch/x86/boot/compressed/acpi.c:6:#include "efi.h" arch/x86/boot/compressed/kaslr.c:25:#include "efi.h" arch/x86/boot/compressed/misc.h:40:#include "efi.h" arch/x86/boot/compressed/pgtable_64.c:7:#include "efi.h" > Any plans for ? It includes : So if misc.h is including linux/bitmap.h indirectly, you can simply include misc.h right? And then you'll slide under the closing door, as you say below. :) > I also underesitmated what is required to be copied because of the > indirect include. The list was only to compile bitmap.c. mem.c (former > unaccepted_memory.c) would require more. More like? Maybe I can help out converting some of the stuff. You could push your current state somewhere - even if it doesn't build - so that I can take a look... > BTW, do we have a white list of linux/ includes that allowed? minmax.h? > math.h? What is the line. Well, that's the thing. Even if those look innocuous now, if they get new includes added to them, that has an influence on the decompressor. So I'm thinking copying the required bits would be the proper way forward. > Maybe allow what is included directly or indirectly now? (Yes, it is my > poor attempt to slide under closing door.) That's basically saying, can I get this done so that I can mark my checkbox that my task is done - you can deal with the crap later yourself. How about we take our time and solve this properly instead of hurrying constantly? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette