From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F221C433F5 for ; Fri, 22 Apr 2022 11:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447104AbiDVLgX (ORCPT ); Fri, 22 Apr 2022 07:36:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232054AbiDVLgW (ORCPT ); Fri, 22 Apr 2022 07:36:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CDD0F14; Fri, 22 Apr 2022 04:33:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC77FB82C2E; Fri, 22 Apr 2022 11:33:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4348C385A4; Fri, 22 Apr 2022 11:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650627206; bh=3jfuEAzvI+fireVbhLAA89FI7cLlXG2gLVIt5mnBIg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N4xc6sPbo+yCUgMVCAfbmL9aaI0wq2uWC3lRyQp75hx9AB4KcChx7EvF3ADbYj3re gjC5jcLuiV0rrYIRHI2hV1QJ9RN7Wef3noIirHog3grPtVx9m2FkUUx9dP+R0qYwNV G6m1sInmZfIGXe5R3kzj6N0QL39ugPMBC63JxbP3xL0Zi5tcYr9i4g5MxxEInSG30o VR5rygxQY/QCxUbIAi/iZxSHWejn0IhHm1atF2cWDlA3JlK077bU5reZv/HUHaFLZM lOp9ohClb795LjV5CoLtPsIFEU/5EVPXXXFzitBgXBLis95T1yA32uKghxdnjcCuGH P1lrjqCWbiDTQ== Date: Fri, 22 Apr 2022 12:33:20 +0100 From: Mark Brown To: Martin =?utf-8?Q?Povi=C5=A1er?= Cc: Martin =?utf-8?Q?Povi=C5=A1er?= , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis , Hector Martin , Sven Peter Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Message-ID: References: <20220331000449.41062-1-povik+lin@cutebit.org> <6D199EAB-FE14-4030-96A7-2E0E89D25FAB@cutebit.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HUPCgzDyOfBhsa/5" Content-Disposition: inline In-Reply-To: X-Cookie: Whoever dies with the most toys wins. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HUPCgzDyOfBhsa/5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2022 at 01:28:20PM +0200, Martin Povi=C5=A1er wrote: > > On 22. 4. 2022, at 13:19, Mark Brown wrote: > > On Fri, Apr 22, 2022 at 12:43:30PM +0200, Martin Povi=C5=A1er wrote: > >> One final thought on the playback routing controls: On systems with >2 > >> speakers, the codecs need to be assigned slots through set_tdm_slot. > >> The macaudio driver RFCed here assigns a single slot to each speaker, > >> making the effect of each speaker's routing control this: =2E.. > > I don't quite grasp the difference between the arrangement you're > > proposing and assigning a single slot to each speaker? Possibly it's > > just a reordering of the slots? > Ah, maybe what=E2=80=99s missing is the fact that the way the speaker amp= drivers > are written, if they are assigned two slots with a call to set_tdm_slot, > the first slot is considered 'left' and the second is 'right'. > So in the arrangement I am proposing the 'Left', 'Right' and 'LeftRight' > values of the routing control have the nominal effect (within the left-ri= ght > speaker pair), while in the other arrangement it is as I described above. So previously each speaker would get two slots but now it just gets one? --HUPCgzDyOfBhsa/5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJikn8ACgkQJNaLcl1U h9Apfwf9FyqYZwZ2D2ZxnG/lVxGl4cjqMmJe5FgwZCDKQPzM3Y9o4137S0U7kLTz QM1Jf+3LJgVkdvJN/Hj3GaJPazdeXB6mMQ5o3p28PEe/ASqNKJCa6Z1UcQ5zdcaZ D89JCKjmGPoHjNWiZCSRE6k7kXhtJO5MyXxNCgXAf5bk7352nedgPmg/4PapUL82 sEV/b496dYNV/EQ6HLGey/73P3cKc6w+urEcUQKaPcFlLWjK1J9ZP+TQuBdSxBNp MjkcoQoQSNrw0PJ/rQWd++JkLimYQDwFEkaNeLWmh+K/L3/vCdun88ZtIbdeM3NL VwJzyNbDoxmUu+IBEFgYIa+SP/YvUw== =k+NI -----END PGP SIGNATURE----- --HUPCgzDyOfBhsa/5-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE28C433F5 for ; Fri, 22 Apr 2022 11:34:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 71AEF16EF; Fri, 22 Apr 2022 13:33:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 71AEF16EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650627266; bh=3jfuEAzvI+fireVbhLAA89FI7cLlXG2gLVIt5mnBIg8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=otisbOEh132rSySjlCuo+yUOZu4dwyaFFdWO9ieALBe3HiUQL+5ypfwXpemDqzyC6 UKEgA7Rj9EwTIaoKPu9zL2YAyhVIS+MdJqcq4oCZdF21iz4/Ic3NvbAktQGhfLeBRJ AehCz5N+YtxqM7I0LBF0GNBXAzowLz1zXBVl9HVI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 16225F800D1; Fri, 22 Apr 2022 13:33:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1AB98F80245; Fri, 22 Apr 2022 13:33:35 +0200 (CEST) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 74B1FF800D1 for ; Fri, 22 Apr 2022 13:33:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 74B1FF800D1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N4xc6sPb" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 2DAA9CE28CB; Fri, 22 Apr 2022 11:33:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4348C385A4; Fri, 22 Apr 2022 11:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650627206; bh=3jfuEAzvI+fireVbhLAA89FI7cLlXG2gLVIt5mnBIg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N4xc6sPbo+yCUgMVCAfbmL9aaI0wq2uWC3lRyQp75hx9AB4KcChx7EvF3ADbYj3re gjC5jcLuiV0rrYIRHI2hV1QJ9RN7Wef3noIirHog3grPtVx9m2FkUUx9dP+R0qYwNV G6m1sInmZfIGXe5R3kzj6N0QL39ugPMBC63JxbP3xL0Zi5tcYr9i4g5MxxEInSG30o VR5rygxQY/QCxUbIAi/iZxSHWejn0IhHm1atF2cWDlA3JlK077bU5reZv/HUHaFLZM lOp9ohClb795LjV5CoLtPsIFEU/5EVPXXXFzitBgXBLis95T1yA32uKghxdnjcCuGH P1lrjqCWbiDTQ== Date: Fri, 22 Apr 2022 12:33:20 +0100 From: Mark Brown To: Martin =?utf-8?Q?Povi=C5=A1er?= Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Message-ID: References: <20220331000449.41062-1-povik+lin@cutebit.org> <6D199EAB-FE14-4030-96A7-2E0E89D25FAB@cutebit.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HUPCgzDyOfBhsa/5" Content-Disposition: inline In-Reply-To: X-Cookie: Whoever dies with the most toys wins. Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Sven Peter , linux-kernel@vger.kernel.org, Hector Martin , Takashi Iwai , Liam Girdwood , Rob Herring , Mark Kettenis , Martin =?utf-8?Q?Povi=C5=A1er?= , Krzysztof Kozlowski X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --HUPCgzDyOfBhsa/5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2022 at 01:28:20PM +0200, Martin Povi=C5=A1er wrote: > > On 22. 4. 2022, at 13:19, Mark Brown wrote: > > On Fri, Apr 22, 2022 at 12:43:30PM +0200, Martin Povi=C5=A1er wrote: > >> One final thought on the playback routing controls: On systems with >2 > >> speakers, the codecs need to be assigned slots through set_tdm_slot. > >> The macaudio driver RFCed here assigns a single slot to each speaker, > >> making the effect of each speaker's routing control this: =2E.. > > I don't quite grasp the difference between the arrangement you're > > proposing and assigning a single slot to each speaker? Possibly it's > > just a reordering of the slots? > Ah, maybe what=E2=80=99s missing is the fact that the way the speaker amp= drivers > are written, if they are assigned two slots with a call to set_tdm_slot, > the first slot is considered 'left' and the second is 'right'. > So in the arrangement I am proposing the 'Left', 'Right' and 'LeftRight' > values of the routing control have the nominal effect (within the left-ri= ght > speaker pair), while in the other arrangement it is as I described above. So previously each speaker would get two slots but now it just gets one? --HUPCgzDyOfBhsa/5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJikn8ACgkQJNaLcl1U h9Apfwf9FyqYZwZ2D2ZxnG/lVxGl4cjqMmJe5FgwZCDKQPzM3Y9o4137S0U7kLTz QM1Jf+3LJgVkdvJN/Hj3GaJPazdeXB6mMQ5o3p28PEe/ASqNKJCa6Z1UcQ5zdcaZ D89JCKjmGPoHjNWiZCSRE6k7kXhtJO5MyXxNCgXAf5bk7352nedgPmg/4PapUL82 sEV/b496dYNV/EQ6HLGey/73P3cKc6w+urEcUQKaPcFlLWjK1J9ZP+TQuBdSxBNp MjkcoQoQSNrw0PJ/rQWd++JkLimYQDwFEkaNeLWmh+K/L3/vCdun88ZtIbdeM3NL VwJzyNbDoxmUu+IBEFgYIa+SP/YvUw== =k+NI -----END PGP SIGNATURE----- --HUPCgzDyOfBhsa/5--