From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFA3C10E9B7 for ; Fri, 22 Apr 2022 11:49:56 +0000 (UTC) Date: Fri, 22 Apr 2022 14:49:57 +0300 From: Petri Latvala To: "Sharma, Swati2" Message-ID: References: <20220422055930.19377-1-anshuman.gupta@intel.com> <60a88b08-bf08-55ab-9f40-c32a702ec72d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60a88b08-bf08-55ab-9f40-c32a702ec72d@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: Reorder system suspend to last List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, Apr 22, 2022 at 12:59:50PM +0530, Sharma, Swati2 wrote: > Please find one nitpick below. Rest looks good to me. > With that fixed. > > Reviewed-by: > Swati Sharma And FWIW CI's pov: Acked-by: Petri Latvala > > On 22-Apr-22 11:29 AM, Anshuman Gupta wrote: > > Reorder the system wide igt tests to last of fast-feedback.testlist, > > so we don't loose the other tests coverage on the platforms which > > are largely getting hit by Suspend/Resume related failures. > > > > Cc: Petri Latvala > > Cc: Swati Sharma > > Signed-off-by: Anshuman Gupta > > --- > > tests/intel-ci/fast-feedback.testlist | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist > > index f6329708b..c9613e609 100644 > > --- a/tests/intel-ci/fast-feedback.testlist > > +++ b/tests/intel-ci/fast-feedback.testlist > > @@ -25,8 +25,6 @@ igt@gem_exec_fence@nb-await > > igt@gem_exec_gttfill@basic > > igt@gem_exec_parallel@engines > > igt@gem_exec_store@basic > > -igt@gem_exec_suspend@basic-s0 > > -igt@gem_exec_suspend@basic-s3 > > igt@gem_flink_basic@bad-flink > > igt@gem_flink_basic@bad-open > > igt@gem_flink_basic@basic > > @@ -98,7 +96,6 @@ igt@kms_chamelium@hdmi-edid-read > > igt@kms_chamelium@hdmi-crc-fast > > igt@kms_chamelium@vga-hpd-fast > > igt@kms_chamelium@vga-edid-read > > -igt@kms_chamelium@common-hpd-after-suspend > > igt@kms_prop_blob@basic > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy > > @@ -128,7 +125,6 @@ igt@kms_pipe_crc_basic@read-crc-pipe-a > > igt@kms_pipe_crc_basic@read-crc-pipe-b > > igt@kms_pipe_crc_basic@read-crc-pipe-c > > igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence > > -igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a > > igt@kms_psr@primary_page_flip > > igt@kms_psr@cursor_plane_move > > igt@kms_psr@sprite_plane_onoff > > @@ -174,8 +170,14 @@ igt@gem_lmem_swapping@parallel-random-engines > > igt@gem_lmem_swapping@random-engines > > igt@gem_lmem_swapping@verify-random > > igt@i915_pm_rpm@module-reload > > -igt@i915_suspend@system-suspend-without-i915 > > # Kernel selftests > > igt@i915_selftest@live > > igt@dmabuf@all > > + > > +# System wide Suspend Test > > nitpick: System wide suspend tests > > > +igt@i915_suspend@system-suspend-without-i915 > > +igt@gem_exec_suspend@basic-s0 > > +igt@gem_exec_suspend@basic-s3 > > +igt@kms_chamelium@common-hpd-after-suspend > > +igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a > > -- > ~Swati Sharma