From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Bhupesh Sharma <bhupesh.sharma@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, vkoul@kernel.org Subject: Re: [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Date: Sat, 23 Apr 2022 08:46:47 -0700 [thread overview] Message-ID: <YmQfZ+h5tD6KbMID@ripper> (raw) In-Reply-To: <20220418205509.1102109-2-bhupesh.sharma@linaro.org> On Mon 18 Apr 13:55 PDT 2022, Bhupesh Sharma wrote: > '#clock-cells' is not a required property for qmp-phy(s) in the > '/' node, but it should be is used in 'phy@' subnode (where it is > actually a 'required' property). Fix the same. > It's not that #clock-cells is "not a required property", it's that the clock comes out of the phy (the child node), so there is no clocks provided by the parent device. Please rewrite the commit message. > This also fixes the following 'make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > '#clock-cells' is a required property > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index 8b850c5ab116..c39ead81ecd7 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -66,9 +66,6 @@ properties: > - description: Address and length of PHY's common serdes block. > - description: Address and length of PHY's DP_COM control block. > > - "#clock-cells": > - enum: [ 1, 2 ] > - > "#address-cells": > enum: [ 1, 2 ] > > @@ -112,11 +109,13 @@ patternProperties: > description: > Each device node of QMP phy is required to have as many child nodes as > the number of lanes the PHY has. > + properties: > + "#clock-cells": > + enum: [ 0, 1, 2 ] The commit message doesn't mention the fact that 0 is also a valid value. Perhaps just keep it [1, 2] in this patch? Regards, Bjorn > > required: > - compatible > - reg > - - "#clock-cells" > - "#address-cells" > - "#size-cells" > - ranges > @@ -468,7 +467,6 @@ examples: > usb_2_qmpphy: phy-wrapper@88eb000 { > compatible = "qcom,sdm845-qmp-usb3-uni-phy"; > reg = <0x088eb000 0x18c>; > - #clock-cells = <1>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x088eb000 0x2000>; > -- > 2.35.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Bhupesh Sharma <bhupesh.sharma@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, vkoul@kernel.org Subject: Re: [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Date: Sat, 23 Apr 2022 08:46:47 -0700 [thread overview] Message-ID: <YmQfZ+h5tD6KbMID@ripper> (raw) In-Reply-To: <20220418205509.1102109-2-bhupesh.sharma@linaro.org> On Mon 18 Apr 13:55 PDT 2022, Bhupesh Sharma wrote: > '#clock-cells' is not a required property for qmp-phy(s) in the > '/' node, but it should be is used in 'phy@' subnode (where it is > actually a 'required' property). Fix the same. > It's not that #clock-cells is "not a required property", it's that the clock comes out of the phy (the child node), so there is no clocks provided by the parent device. Please rewrite the commit message. > This also fixes the following 'make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > '#clock-cells' is a required property > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index 8b850c5ab116..c39ead81ecd7 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -66,9 +66,6 @@ properties: > - description: Address and length of PHY's common serdes block. > - description: Address and length of PHY's DP_COM control block. > > - "#clock-cells": > - enum: [ 1, 2 ] > - > "#address-cells": > enum: [ 1, 2 ] > > @@ -112,11 +109,13 @@ patternProperties: > description: > Each device node of QMP phy is required to have as many child nodes as > the number of lanes the PHY has. > + properties: > + "#clock-cells": > + enum: [ 0, 1, 2 ] The commit message doesn't mention the fact that 0 is also a valid value. Perhaps just keep it [1, 2] in this patch? Regards, Bjorn > > required: > - compatible > - reg > - - "#clock-cells" > - "#address-cells" > - "#size-cells" > - ranges > @@ -468,7 +467,6 @@ examples: > usb_2_qmpphy: phy-wrapper@88eb000 { > compatible = "qcom,sdm845-qmp-usb3-uni-phy"; > reg = <0x088eb000 0x18c>; > - #clock-cells = <1>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x088eb000 0x2000>; > -- > 2.35.1 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-04-23 15:44 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-18 20:55 [PATCH v3 0/4] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma 2022-04-18 20:55 ` Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 1/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-19 12:12 ` [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: " Rob Herring 2022-04-19 12:12 ` [PATCH v3 1/4] dt-bindings: phy: qcom, qmp: " Rob Herring 2022-04-23 15:46 ` Bjorn Andersson [this message] 2022-04-23 15:46 ` [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: " Bjorn Andersson 2022-05-15 6:36 ` Bhupesh Sharma 2022-05-15 6:36 ` [PATCH v3 1/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 2/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-18 22:34 ` [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: " Dmitry Baryshkov 2022-04-18 22:34 ` Dmitry Baryshkov 2022-04-19 3:36 ` Bhupesh Sharma 2022-04-19 3:36 ` Bhupesh Sharma 2022-04-23 15:56 ` Bjorn Andersson 2022-04-23 15:56 ` Bjorn Andersson 2022-04-18 20:55 ` [PATCH v3 3/4] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 3/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-23 15:51 ` [PATCH v3 3/4] dt-bindings: phy: qcom,qmp: " Bjorn Andersson 2022-04-23 15:51 ` [PATCH v3 3/4] dt-bindings: phy: qcom, qmp: " Bjorn Andersson 2022-04-18 20:55 ` [PATCH v3 4/4] arm64: dts: qcom: sm8450: Fix qmp phy node (use phy@ instead of lanes@) Bhupesh Sharma 2022-04-18 20:55 ` Bhupesh Sharma 2022-04-23 16:03 ` (subset) " Bjorn Andersson 2022-04-23 16:03 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YmQfZ+h5tD6KbMID@ripper \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=bhupesh.linux@gmail.com \ --cc=bhupesh.sharma@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.