From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Bhupesh Sharma <bhupesh.sharma@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, vkoul@kernel.org, Rob Herring <robh@kernel.org> Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Date: Sat, 23 Apr 2022 08:56:22 -0700 [thread overview] Message-ID: <YmQhpsmiYJzR99LK@ripper> (raw) In-Reply-To: <20220418205509.1102109-3-bhupesh.sharma@linaro.org> On Mon 18 Apr 13:55 PDT 2022, Bhupesh Sharma wrote: > Since a few boards based on QCoM qmp phy use the > 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to > describe the ufs phy nodes, add them to the dt-bindings doc as well. > > This fixes the following '$ make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of > the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index c39ead81ecd7..411c79dbfa15 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -90,6 +90,14 @@ properties: > minItems: 1 > maxItems: 3 > > + vdda-max-microamp: > + description: > + Specifies max. load that can be drawn from phy supply. > + > + vdda-pll-max-microamp: > + description: > + Specifies max. load that can be drawn from pll supply. It's not clear to me what an implementation would do with this information. As expressed here it sounds like it's a property of the specified regulator, so the driver should just request that information from the regulator framework. So let's wait with introducing such properties until we know. Thanks, Bjorn > + > vdda-phy-supply: > description: > Phandle to a regulator supply to PHY core block. > -- > 2.35.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Bhupesh Sharma <bhupesh.sharma@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, vkoul@kernel.org, Rob Herring <robh@kernel.org> Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Date: Sat, 23 Apr 2022 08:56:22 -0700 [thread overview] Message-ID: <YmQhpsmiYJzR99LK@ripper> (raw) In-Reply-To: <20220418205509.1102109-3-bhupesh.sharma@linaro.org> On Mon 18 Apr 13:55 PDT 2022, Bhupesh Sharma wrote: > Since a few boards based on QCoM qmp phy use the > 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to > describe the ufs phy nodes, add them to the dt-bindings doc as well. > > This fixes the following '$ make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of > the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index c39ead81ecd7..411c79dbfa15 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -90,6 +90,14 @@ properties: > minItems: 1 > maxItems: 3 > > + vdda-max-microamp: > + description: > + Specifies max. load that can be drawn from phy supply. > + > + vdda-pll-max-microamp: > + description: > + Specifies max. load that can be drawn from pll supply. It's not clear to me what an implementation would do with this information. As expressed here it sounds like it's a property of the specified regulator, so the driver should just request that information from the regulator framework. So let's wait with introducing such properties until we know. Thanks, Bjorn > + > vdda-phy-supply: > description: > Phandle to a regulator supply to PHY core block. > -- > 2.35.1 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-04-23 15:54 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-18 20:55 [PATCH v3 0/4] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma 2022-04-18 20:55 ` Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 1/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-19 12:12 ` [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: " Rob Herring 2022-04-19 12:12 ` [PATCH v3 1/4] dt-bindings: phy: qcom, qmp: " Rob Herring 2022-04-23 15:46 ` [PATCH v3 1/4] dt-bindings: phy: qcom,qmp: " Bjorn Andersson 2022-04-23 15:46 ` Bjorn Andersson 2022-05-15 6:36 ` Bhupesh Sharma 2022-05-15 6:36 ` [PATCH v3 1/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 2/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-18 22:34 ` [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: " Dmitry Baryshkov 2022-04-18 22:34 ` Dmitry Baryshkov 2022-04-19 3:36 ` Bhupesh Sharma 2022-04-19 3:36 ` Bhupesh Sharma 2022-04-23 15:56 ` Bjorn Andersson [this message] 2022-04-23 15:56 ` Bjorn Andersson 2022-04-18 20:55 ` [PATCH v3 3/4] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Bhupesh Sharma 2022-04-18 20:55 ` [PATCH v3 3/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-04-23 15:51 ` [PATCH v3 3/4] dt-bindings: phy: qcom,qmp: " Bjorn Andersson 2022-04-23 15:51 ` [PATCH v3 3/4] dt-bindings: phy: qcom, qmp: " Bjorn Andersson 2022-04-18 20:55 ` [PATCH v3 4/4] arm64: dts: qcom: sm8450: Fix qmp phy node (use phy@ instead of lanes@) Bhupesh Sharma 2022-04-18 20:55 ` Bhupesh Sharma 2022-04-23 16:03 ` (subset) " Bjorn Andersson 2022-04-23 16:03 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YmQhpsmiYJzR99LK@ripper \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=bhupesh.linux@gmail.com \ --cc=bhupesh.sharma@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.