Re: [qemu.qmp PATCH 04/12] update project URLs

[Kashyap Chamarthy <kchamart@redhat.com>]

On Tue, Apr 26, 2022 at 08:55:38AM +0100, Daniel P. Berrangé wrote:
> On Mon, Apr 25, 2022 at 02:19:27PM -0400, John Snow wrote:
> > On Mon, Apr 25, 2022, 6:56 AM Daniel P. Berrangé <berrange@redhat.com>
> > wrote:
> > 
> > > On Fri, Apr 22, 2022 at 02:49:32PM -0400, John Snow wrote:
> > > > Point to this library's URLs instead of the entire project's.
> > > >
> > > > Signed-off-by: John Snow <jsnow@redhat.com>
> > > > ---
> > > >  setup.cfg | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/setup.cfg b/setup.cfg
> > > > index c21f2ce..0a1c215 100644
> > > > --- a/setup.cfg
> > > > +++ b/setup.cfg
> > > > @@ -5,8 +5,8 @@ author = QEMU Project
> > > >  author_email = qemu-devel@nongnu.org
> > > >  maintainer = John Snow
> > > >  maintainer_email = jsnow@redhat.com
> > > > -url = https://www.qemu.org/
> > > > -download_url = https://www.qemu.org/download/
> > > > +url = https://gitlab.com/qemu-project/python-qemu-qmp
> > > > +download_url =
> > > https://gitlab.com/qemu-project/python-qemu-qmp/-/packages
> > >
> > > Auto-generated tarballs are not guaranteed to have fixed content forever
> > > so I tend to avoid pointing to those. Assuming you're intending to upload
> > > to pypi, I'd link to that instead as the "official" tarball source.
> > >
> > 
> > This metadata will also be used for PyPI, so that seemed cyclic.
> > 
> > I linked it to the gitlab package repository, where I *intend* to push
> > built wheels (and dev interstitial builds) but maybe that's too "inside
> > baseball" for a pypi link.
> 
> Oh wait, I mis-understood the URL. If it is the location for manually
> built & published dists, that's ok - it isn't the gitlab auto tarballs. 
> 
> > Seems weird for a Pypi package to point to itself on pypi, but maybe that's
> > correct?
> 
> I wonder what common practice is for some popular python libs....

E.g. if you look at SQLAlchemy (definitely one of the popular
libraries), it is pointing to itself (see the Ufiles under the "Download
files" link):

    https://pypi.org/project/SQLAlchemy

-- 
/kashyap