From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D429C433F5 for ; Wed, 27 Apr 2022 12:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234897AbiD0Muy (ORCPT ); Wed, 27 Apr 2022 08:50:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234874AbiD0Mux (ORCPT ); Wed, 27 Apr 2022 08:50:53 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BD541C123 for ; Wed, 27 Apr 2022 05:47:42 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id y21so1090850wmi.2 for ; Wed, 27 Apr 2022 05:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4ZU7ssA0uBUIH6XIuoYvcPvJ99ZnRQPUGmPQtpNi76c=; b=IW2c9joHq/hwifhAacbBVc1qzogNoXNAxtBDcYWCPJ6fPOM9y6yKnxL7LpTymyi1Mw hjMcixIyPI70Pi2PTqQlosHfCg1E8SnZ5l0ArWRvMWodQsPK5LhTsudvfWJN9kI4hau8 q0lDTsSvPRBac4hfb3TQ0orhvL6MUxOyjUvtvP5Yq/D4+mHZPSQn08XLD3G61YIjeSEa M4MO+l2LtH2/6N7jEwuGc9ZS+61BVh/gEjsKIastxGEQjzGbgP8+YNOkNsjzSS3tgsLX VM7ssK8zNESBLZCy1G0Aser5Eb5kq6GNeP6Wm6p+hwwD3361fyDBWfdauodf69g0q6sq eP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4ZU7ssA0uBUIH6XIuoYvcPvJ99ZnRQPUGmPQtpNi76c=; b=uXKqet+W9I12zXcLf3GJQGSyfyipBMnQph1KQJWU0vev/zEoRKwL0PwYj/YVDnFBCW 6PHbC5J34wedtvX+6d9NoeTuE+DUTRgMA6EHKz/OLg31htt1L4qNTDBpnOMwUM8qSyep tYU349/VqiPtQklY5uMcodgMrIGcXLCv06/U6XpsRt92GZOSWNnhOyUm8Dzp/WA3cvwH jZZ9d2eBF5Z8J11OInniYbObn4ypz2MXTzKOrGWkwZPqc3J4dZmq9H1yXpmgBGhTV0ON mbMW0T+i1xUfOkYNnh70bvlZuP3IfhPKH+XuJlU+cqX01XLeUYpQ28hrpLlg6HikrcbU ryIQ== X-Gm-Message-State: AOAM5321CTz887oNnYaq65ZAwr/nNILJ9SMVz3VRRoQ74mbOjNx/2Yhc A2mLCh3hRRKHepl1D+IwjTmzgQ== X-Google-Smtp-Source: ABdhPJz5NK+Ha567qr3bpxGvIn7U9ze3IwWfwIo5TY6HK+pg7ceZbULrFiJZ/aDUS4aMuFui3oFWlQ== X-Received: by 2002:a05:600c:1584:b0:38e:c80e:b8b5 with SMTP id r4-20020a05600c158400b0038ec80eb8b5mr34457739wmf.99.1651063660964; Wed, 27 Apr 2022 05:47:40 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:493f:cd0f:324a:323c]) by smtp.gmail.com with ESMTPSA id w12-20020adf8bcc000000b002060e3da33fsm13564171wra.66.2022.04.27.05.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 05:47:40 -0700 (PDT) Date: Wed, 27 Apr 2022 14:47:34 +0200 From: Marco Elver To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/46] kasan: common: adapt to the new prototype of __stack_depot_save() Message-ID: References: <20220426164315.625149-1-glider@google.com> <20220426164315.625149-4-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426164315.625149-4-glider@google.com> User-Agent: Mutt/2.1.4 (2021-12-11) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 06:42PM +0200, Alexander Potapenko wrote: > Pass extra_bits=0, as KASAN does not intend to store additional > information in the stack handle. No functional change. > > Signed-off-by: Alexander Potapenko I think this patch needs to be folded into the previous one, otherwise bisection will be broken. > --- > Link: https://linux-review.googlesource.com/id/I932d8f4f11a41b7483e0d57078744cc94697607a > --- > mm/kasan/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index d9079ec11f313..5d244746ac4fe 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -36,7 +36,7 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags, bool can_alloc) > unsigned int nr_entries; > > nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0); > - return __stack_depot_save(entries, nr_entries, flags, can_alloc); > + return __stack_depot_save(entries, nr_entries, 0, flags, can_alloc); > } > > void kasan_set_track(struct kasan_track *track, gfp_t flags) > -- > 2.36.0.rc2.479.g8af0fa9b8e-goog >