From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3275FC433F5 for ; Wed, 27 Apr 2022 10:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbiD0Kob (ORCPT ); Wed, 27 Apr 2022 06:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbiD0Ko3 (ORCPT ); Wed, 27 Apr 2022 06:44:29 -0400 Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDBD528B76D for ; Wed, 27 Apr 2022 03:25:26 -0700 (PDT) Received: from hillosipuli.retiisi.eu (dkvn5pty0gzs3nltj987t-3.rev.dnainternet.fi [IPv6:2001:14ba:4457:9640:1e2d:1f75:a607:ef37]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 476811B00120; Wed, 27 Apr 2022 12:57:23 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1651053443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tgawboluo26f/XvecJ8vce6KYUKWyc0cis4y368vPWM=; b=RL/A8+VfzMwq1XxQ9Glt5ZRdKBO/UaAbuIS1j9fl3cfeGIwTD/lfxaIs6CtnriDfz4jshm 3030hiOiw+R4oXObZ44E3d2zRxLvRHShFQM4Ca0XP9bjuyO12/k9rv7XIMCdQ0E97cksfA WFX8m7BauMzfQ+KybAt01GrwHlSw2DuByGkys/9Aym6dr2Zd13FADyNkYXlkBADop+BvgH x5Mrcg3eDfAAsB/xkfyXJTezDt2dviksivaAI0Tgf1Tqex4oD8J2nHizgpHxINc+oaWHUc zrbOkMYl7IPXlguvQJHYcFscTOAyQNK/cN4dF/kyn9ZU9C8T01I8o5aqBlnepg== Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id D7DD5634C91; Wed, 27 Apr 2022 12:57:16 +0300 (EEST) Date: Wed, 27 Apr 2022 12:57:16 +0300 From: Sakari Ailus To: Jacopo Mondi Cc: Chiranjeevi Rapolu , krzysztof.kozlowski@canonical.com, jeanmichel.hautbois@ideasonboard.com, laurent.pinchart@ideasonboard.com, paul.kocialkowski@bootlin.com, paul.elder@ideasonboard.com, Mauro Carvalho Chehab , "open list:OMNIVISION OV5670 SENSOR DRIVER" Subject: Re: [PATCH v3 6/8] media: i2c: ov5670: Add runtime_pm operations Message-ID: References: <20220329090133.338073-1-jacopo@jmondi.org> <20220329090133.338073-7-jacopo@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329090133.338073-7-jacopo@jmondi.org> ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1651053443; a=rsa-sha256; cv=none; b=fWRkxASj+CdwSrz8BrtszyN2Jdf8dLlAoomYjTj2RgINeRSJ717EATexp0+4bczuvZMKXP hEygNu9Htb10UNNgs165PvH1yQnF+vP5iOfVa65ED/nk+SgvFAcxz+RJfodsfy9z2NEIqN ZB3APxVJCd3LuMffYtRQ+j5RSC3ozovX+oj0boGP/8KTOy8jZrLfLqgcJrIFZxSWgwvNvG JKCNbXiUUozErj74bq/7l/MtniZTexcxzEmFcEPw9Fl/eakHyz+zc5/pOety0GF8NdKohO tkM/l7s9ue8AXuS0wdF8o2Jqd6vROcHHgksusjXYnQyMc0l/WqJ3Azlhs/jc6w== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1651053443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tgawboluo26f/XvecJ8vce6KYUKWyc0cis4y368vPWM=; b=FeCXJIyi00r2MRLoZP+LoYQSb8qMnrttkk/MXx2mw0XAv1hdsAUyah9CN/TUk+6x6Bixi3 +OQQ9FmyUUfepJeIi2mG/yoO8cC4kjS3GTQTlZ3IwwbAX7mUwc9fZfWQuTSoRLW54n00yT cGFSCF/BsOgYCKpPJf09oaudFUSFi2y7WwQz23ebmPmmfyvhdu3mGmJ3CYZsEDSuag8cCa RmBEjBBnUu8jftyqxQKpP74rNJZoF07dCe662ifkDvR7H3zo/K+guDfRkjqaWrP4aYlouX 2GBA8qacp/+ntFeWbImxrTgeO+20xjjL04Z7WZxQmEP7BPh4VSnKA9kr0yRtSg== Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jacopo, On Tue, Mar 29, 2022 at 11:01:31AM +0200, Jacopo Mondi wrote: > Implement the power up and power down routines and install them as > runtime_pm handler for runtime_suspend and runtime_resume operations. > > Rework the runtime_pm enablement and the chip power handling during > probe, as calling pm_runtime_idle() in a driver that registers no > idle callback is a nop. The suspend callback is called by rpm_idle() in the absence of the idle callback. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/ov5670.c | 58 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 52 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c > index 9e69b4008917..b63b07d8ca2f 100644 > --- a/drivers/media/i2c/ov5670.c > +++ b/drivers/media/i2c/ov5670.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2424,6 +2425,39 @@ static int ov5670_set_stream(struct v4l2_subdev *sd, int enable) > return ret; > } > > +static int __maybe_unused ov5670_runtime_resume(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > + struct ov5670 *ov5670 = to_ov5670(sd); > + int ret; > + > + ret = regulator_bulk_enable(OV5670_NUM_SUPPLIES, ov5670->supplies); > + if (ret) > + return ret; > + > + gpiod_set_value_cansleep(ov5670->pwdn_gpio, 0); > + gpiod_set_value_cansleep(ov5670->reset_gpio, 0); > + > + /* 8192 * 2 clock pulses before the first SCCB transaction. */ > + usleep_range(1000, 1500); > + > + return 0; > +} > + > +static int __maybe_unused ov5670_runtime_suspend(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > + struct ov5670 *ov5670 = to_ov5670(sd); > + > + gpiod_set_value_cansleep(ov5670->reset_gpio, 1); > + gpiod_set_value_cansleep(ov5670->pwdn_gpio, 1); > + regulator_bulk_disable(OV5670_NUM_SUPPLIES, ov5670->supplies); > + > + return 0; > +} > + > static int __maybe_unused ov5670_suspend(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > @@ -2564,14 +2598,25 @@ static int ov5670_probe(struct i2c_client *client) > goto error_print; > } > > + pm_runtime_enable(&client->dev); > + > full_power = acpi_dev_state_d0(&client->dev); > if (full_power) { > + ret = pm_runtime_resume_and_get(&client->dev); Please see how e.g. the CCS driver does this (no need for autosuspend though). E.g. don't use runtime PM to power the sensor on in probe, or off in remove. > + if (ret) { > + err_msg = "Failed to power on"; > + goto error_print; > + } > + > /* Check module identity */ > ret = ov5670_identify_module(ov5670); > if (ret) { > err_msg = "ov5670_identify_module() error"; > - goto error_print; > + goto error_power_off; > } > + > + /* Set the device's state to active if it's in D0 state. */ > + pm_runtime_set_active(&client->dev); > } > > mutex_init(&ov5670->mutex); > @@ -2608,11 +2653,7 @@ static int ov5670_probe(struct i2c_client *client) > > ov5670->streaming = false; > > - /* Set the device's state to active if it's in D0 state. */ > - if (full_power) > - pm_runtime_set_active(&client->dev); > - pm_runtime_enable(&client->dev); > - pm_runtime_idle(&client->dev); > + pm_runtime_suspend(&client->dev); > > return 0; > > @@ -2625,6 +2666,9 @@ static int ov5670_probe(struct i2c_client *client) > error_mutex_destroy: > mutex_destroy(&ov5670->mutex); > > +error_power_off: > + pm_runtime_put(&client->dev); > + > error_print: > dev_err(&client->dev, "%s: %s %d\n", __func__, err_msg, ret); > > @@ -2641,6 +2685,7 @@ static int ov5670_remove(struct i2c_client *client) > v4l2_ctrl_handler_free(sd->ctrl_handler); > mutex_destroy(&ov5670->mutex); > > + pm_runtime_put(&client->dev); > pm_runtime_disable(&client->dev); > > return 0; > @@ -2648,6 +2693,7 @@ static int ov5670_remove(struct i2c_client *client) > > static const struct dev_pm_ops ov5670_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ov5670_suspend, ov5670_resume) > + SET_RUNTIME_PM_OPS(ov5670_runtime_suspend, ov5670_runtime_resume, NULL) > }; > > #ifdef CONFIG_ACPI -- Kind regards, Sakari Ailus