From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ritaro Takenaka <ritarot634@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nf_flowtable: ensure dst.dev is not blackhole
Date: Wed, 27 Apr 2022 17:10:50 +0200 [thread overview]
Message-ID: <Ymlc+vl4TUE57Q3+@salvia> (raw)
In-Reply-To: <04e2c223-7936-481d-0032-0a55a21dca7a@gmail.com>
On Tue, Apr 26, 2022 at 09:28:13PM +0900, Ritaro Takenaka wrote:
> Thanks for your reply.
>
> > In 5.4, this check is only enabled for xfrm.
> Packet loss occurs with xmit (xfrm is not confirmed).
> I also experienced packet loss with 5.10, which runs dst_check periodically.
> Route GC and flowtable GC are not synchronized, so it is
> necessary to check each packet.
>
> > dst_check() should deal with this.
> When dst_check is used, the performance degradation is not negligible.
> From 900 Mbps to 700 Mbps with QCA9563 simple firewall.
You mention 5.10 above.
Starting 5.12, dst_check() uses INDIRECT_CALL_INET.
Is dst_check() still slow with >= 5.12?
Asking this because my understanding (at this stage) is that this
check for blackhole_netdev is a faster way to check for stale cached
routes.
next prev parent reply other threads:[~2022-04-27 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 8:08 [PATCH] nf_flowtable: ensure dst.dev is not blackhole Ritaro Takenaka
2022-04-26 11:21 ` Pablo Neira Ayuso
2022-04-26 11:55 ` りたろう
2022-04-26 12:28 ` Ritaro Takenaka
2022-04-27 15:10 ` Pablo Neira Ayuso [this message]
2022-04-30 17:23 ` Ritaro Takenaka
2022-05-09 6:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymlc+vl4TUE57Q3+@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ritarot634@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.