Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_pipe_control_store_loop: added description for test case

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Sai,

On 2022-04-26 at 10:53:30 +0530, sai.gowtham.ch@intel.com wrote:
> From: Ch Sai Gowtham <sai.gowtham.ch@intel.com>
> 
> Added test description for subtest that are available.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch@intel.com>
---------------- ^
Correct this (see my other letter on gem_partial_pwrite_pread).

> ---
>  tests/i915/gem_pipe_control_store_loop.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/i915/gem_pipe_control_store_loop.c b/tests/i915/gem_pipe_control_store_loop.c
> index 983605e3..070e767f 100644
> --- a/tests/i915/gem_pipe_control_store_loop.c
> +++ b/tests/i915/gem_pipe_control_store_loop.c
> @@ -183,9 +183,13 @@ igt_main
>  		igt_skip_on(devid == PCI_CHIP_I965_G); /* has totally broken pipe control */
>  	}
>  
> +	igt_describe("checks tlb consistency of the pipe_control target so creates new buffer"
--------------------- ^
Use capital letter at begin of sentence, so s/checks/Checks/

> +		     " each time, emit commands and send it to ring for execution and target"
> +		     " buffer won't get reused.");

Looks a little too long, you do not need to describe every
single step used, so imho shorten this to something like

	igt_describe("Checks tlb consistency of the pipe_control with fresh buffer.");

should be ok.

>  	igt_subtest("fresh-buffer")
>  		store_pipe_control_loop(false, 2);
>  
> +	igt_describe("Emit commands in reused buffer and send it to ring for execution.");

Here just reuse previous one with s/fresh/reused/ buffer change.

Regards,
Kamil

>  	igt_subtest("reused-buffer")
>  		store_pipe_control_loop(true, 2);
>  
> -- 
> 2.35.1
>