From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A4D1361 for ; Thu, 28 Apr 2022 15:45:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F236C385A0; Thu, 28 Apr 2022 15:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651160754; bh=jlixZfnqmKwsIrnN9lsthFcR9XPCemSMhABH6wF5Vak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ckfl7IiSrlKHBmTeTl558CK6CyJAsU1xYpPEtird+WEKuZGZKLJvgpQmzIv9iWu7d PRLSIIojMl9MyOjlMrHEMuhr/f4XrTZQbtNwP7RcZb5wwFQB8qK9+5QNa32JjjUgy6 SUjX6eeRPaoaXtvlA0tqf9Zdh2SbZM79fJJvYajU= Date: Thu, 28 Apr 2022 17:45:51 +0200 From: Greg Kroah-Hartman To: Adrien Thierry Cc: Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vchiq_arm: use standard print helpers Message-ID: References: <20220428150550.261499-1-athierry@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 28, 2022 at 05:23:17PM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 28, 2022 at 11:05:49AM -0400, Adrien Thierry wrote: > > Replace the custom debug print macros with the standard dev_err() and > > friends. > > > > This handles TODO item "Cleanup logging mechanism". > > > > Signed-off-by: Adrien Thierry > > --- > > > > Changes since v1: removed function name in dev_dbg() calls > > > > .../interface/vchiq_arm/vchiq_arm.c | 157 +++--- > > .../interface/vchiq_arm/vchiq_connected.c | 7 +- > > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++---------- > > .../interface/vchiq_arm/vchiq_core.h | 43 +- > > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ---- > > .../interface/vchiq_arm/vchiq_dev.c | 86 ++- > > 7 files changed, 341 insertions(+), 556 deletions(-) > > Try doing this in smaller chunks. There's a lot of churn here, and not > all of it is correct. > > Try removing these one-function-at-a-time and then when it's all > finished, you can remove the debugfs and function calls as no one is > calling them. That is one function you are replacing at a time, not to do this one function you are cleaning up in the source at a time. If that makes sense. Awkward wording... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E96DFC433EF for ; Thu, 28 Apr 2022 15:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cIvWaeA7yJl113X1A2ZgckNpP6UmQqSftmItyyG+NXQ=; b=WflbesHbZzY1ei CFmVGOQYYoD4Pwjo/VvxtSwRy6M2fIU9I4eFWOGnD3+QgWDMjqFI0KQ3SCsteJ/0cCH0nmI54HtMf On/WCjrgvHzovE4urxat7EU55FViXVw6yp+F4ETdTBmCdlgD+wFnH0rWk9fl3ibv4hT+/PyBG4V9e vDwp4WTWerEihE/QrBT+D1nOiR705Mo+TieZahREpWzjtJhXMkrvSLQbnUvQQbjezcYAZwYeplQ73 FRZWBA0OL2wvjZic7DIt2efTk3Euj8IWm4WdgKlyZsuD5TV5KVtdZgmm2mo61Cbint1AzY+4IvYip OTjUo4BCQN781BnHVWfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk6L8-007iQl-Ip; Thu, 28 Apr 2022 15:45:58 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk6L5-007iQH-R3; Thu, 28 Apr 2022 15:45:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 238D461FB7; Thu, 28 Apr 2022 15:45:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F236C385A0; Thu, 28 Apr 2022 15:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651160754; bh=jlixZfnqmKwsIrnN9lsthFcR9XPCemSMhABH6wF5Vak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ckfl7IiSrlKHBmTeTl558CK6CyJAsU1xYpPEtird+WEKuZGZKLJvgpQmzIv9iWu7d PRLSIIojMl9MyOjlMrHEMuhr/f4XrTZQbtNwP7RcZb5wwFQB8qK9+5QNa32JjjUgy6 SUjX6eeRPaoaXtvlA0tqf9Zdh2SbZM79fJJvYajU= Date: Thu, 28 Apr 2022 17:45:51 +0200 From: Greg Kroah-Hartman To: Adrien Thierry Cc: Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vchiq_arm: use standard print helpers Message-ID: References: <20220428150550.261499-1-athierry@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_084555_951324_25FC13B9 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 05:23:17PM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 28, 2022 at 11:05:49AM -0400, Adrien Thierry wrote: > > Replace the custom debug print macros with the standard dev_err() and > > friends. > > > > This handles TODO item "Cleanup logging mechanism". > > > > Signed-off-by: Adrien Thierry > > --- > > > > Changes since v1: removed function name in dev_dbg() calls > > > > .../interface/vchiq_arm/vchiq_arm.c | 157 +++--- > > .../interface/vchiq_arm/vchiq_connected.c | 7 +- > > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++---------- > > .../interface/vchiq_arm/vchiq_core.h | 43 +- > > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ---- > > .../interface/vchiq_arm/vchiq_dev.c | 86 ++- > > 7 files changed, 341 insertions(+), 556 deletions(-) > > Try doing this in smaller chunks. There's a lot of churn here, and not > all of it is correct. > > Try removing these one-function-at-a-time and then when it's all > finished, you can remove the debugfs and function calls as no one is > calling them. That is one function you are replacing at a time, not to do this one function you are cleaning up in the source at a time. If that makes sense. Awkward wording... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel