From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B704BC433FE for ; Thu, 28 Apr 2022 16:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349829AbiD1QSY (ORCPT ); Thu, 28 Apr 2022 12:18:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349831AbiD1QSW (ORCPT ); Thu, 28 Apr 2022 12:18:22 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827BF1A808 for ; Thu, 28 Apr 2022 09:15:07 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso5566171wme.5 for ; Thu, 28 Apr 2022 09:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PJ9fXshc7sXkSmf17RTyOYRRAPFZLf4/m3xbXOUm70M=; b=BjQezLJtJXhJeRPdtqhso0UBmUQ0NMOdOsNiQRtxT8tybYx5ZdK0+vh8txyPDxFaA1 6P089U18UfqSmudm23BIUxPLI4St8AgkXXYdRWlyFBMg8hyxvOfsSMsjvKeizVHFOSA6 pe4SkfFZW6DC1fn3pLfT8IxwTIzXHW1A+NlKIZ5SC0Kw/jyrCAzwiXPPnGQNMnfJjKP7 XJRksLD0NpmAXzgR8xKIz305bjilqSu4BE9P/0NPPAasQautK/p/vVrFohbRS9+B1inB nzyy3whLczaq5RqyKrj7qK84Sg3DvquiQsBZWT627m9+hMu/u/QXFKUu+RjUu4Cfjqu6 o0mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PJ9fXshc7sXkSmf17RTyOYRRAPFZLf4/m3xbXOUm70M=; b=dILaGBgRICDadQXakP4G9bOPK16CXySWLjBYHV7HOgQAzoKfJ6P+ld9+lm5CH8n7Zc /hghLFbGNLiF2QE9/vqh2fj3xj/2pdO88Ig6sS8WEOf7utLwGexPpfo7R/GfTlTIirCB k3DGjjK7yHbIW6Qhi/LWrZE6VODjrflPnV6t19c/kqhJH7xownkYDpMUR2uOUn6FQrb/ LZpSQk26h0OmRmN7yvPlDCca7NJ7KLLt2nxb3FrlAadpM08bLdHcxYcfM646/odmbBhA zOZUf0pV73wJ38QZGhdxiBD2IrdIFWGN6+lwIP9+voCJAstWze4Et2jQj+1pEURawuWQ fADQ== X-Gm-Message-State: AOAM530nkozOHVTR+6xYu+DoXp42PHi2hSWgnHM3mrNXbNo4EmudeDoo Oz6JfNBPt6Oe7eG5jak9boi5KA== X-Google-Smtp-Source: ABdhPJxjzKbO7XX/MsRiwHEuz6e06OZpH88NuPbhYb20alPwj38X0mssnjCP/E+GGAlTNVozQIQUpA== X-Received: by 2002:a7b:c095:0:b0:393:fd2e:9191 with SMTP id r21-20020a7bc095000000b00393fd2e9191mr10294526wmh.137.1651162506028; Thu, 28 Apr 2022 09:15:06 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id n10-20020a5d588a000000b002052e4aaf89sm191694wrf.80.2022.04.28.09.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 09:15:04 -0700 (PDT) Date: Thu, 28 Apr 2022 17:15:02 +0100 From: Lee Jones To: Caleb Connolly Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org, amit.pundir@linaro.org, Krzysztof Kozlowski , Dmitry Baryshkov Subject: Re: [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs Message-ID: References: <20220323162820.110806-1-caleb@connolly.tech> <20220323162820.110806-4-caleb@connolly.tech> <10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org> <850d2c2d-9531-ed4c-48fc-2daa0311e3e6@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <850d2c2d-9531-ed4c-48fc-2daa0311e3e6@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 27 Apr 2022, Caleb Connolly wrote: > > > On 26/04/2022 19:24, Lee Jones wrote: > > On Tue, 26 Apr 2022, Caleb Connolly wrote: > > > On 25/04/2022 16:05, Lee Jones wrote: > > > > On Wed, 23 Mar 2022, Caleb Connolly wrote: > > > > > > > > > From: Caleb Connolly > > > > > > > > > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like > > > > > the RRADC to calibrate ADC values. > > > > > > > > > > Signed-off-by: Caleb Connolly > > > > > Reviewed-by: Dmitry Baryshkov > > > > > Tested-by: Dmitry Baryshkov > > > > > --- > > > > > drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ > > > > > include/soc/qcom/qcom-spmi-pmic.h | 1 + > > > > > 2 files changed, 8 insertions(+) > > > > > > > > Please change the Subject line to match the style of the sub-system? > > > Hi, sorry if this is a silly question, I don't quite understand what you > > > want me to change here, the subject line is in the same "mfd: driver:" > > > format as other patches in the subsystem? > > > > mfd: qcom-spmi-pmic: Read fab ID on supported PMICs > > > > What's 'fab' should that be capitalised too? > "fab" is short for fabrication I think, the register value can be used to > determine which factory the chip was manufactured in. > > I can make it clearer and go for > > mfd: qcom-spmi-pmic: Read fabrication ID on supported PMICs Clearer, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog