From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1236C433EF for ; Fri, 29 Apr 2022 11:44:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240194AbiD2Lrt (ORCPT ); Fri, 29 Apr 2022 07:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbiD2Lrm (ORCPT ); Fri, 29 Apr 2022 07:47:42 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40F4CC7495 for ; Fri, 29 Apr 2022 04:44:18 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id r9so6884081pjo.5 for ; Fri, 29 Apr 2022 04:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EkPpqVJFZwtWuFEh4cjXyyHHD2JdNkeuaKvQxOerGLs=; b=UiTgjpBDLYNVb5S2HJ7JkqhnXTLajN0F89ea627idBHei/lCATFHimuuXRKJrI7VP1 hXd7YtHmJfxGyoIYThnjXVLHYbsWVstByJN/HBzblqHJmwTxONK1aH8TlhMIUEt+J9JL Jvj2ubAeOBdbV9dq8oG8yygZ9JPthi8vSkNDCX94aI4sEhLujFDd+HRF55Ml0m06TdkX I6Xj25mlJ0iyRn7ETPC/BZk4FHDDb2OOBnDcodFk6gi47HGtXFbrvtnl7TQeEoom11lr HZAz2r2JE0eZk/RGC0m2KhI7rmMDlVncQ6eLOBDh+9jdIJ4jcDL3YARyrhK3+hqz12g4 Xu6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EkPpqVJFZwtWuFEh4cjXyyHHD2JdNkeuaKvQxOerGLs=; b=Be7b4UczUdvPLRfF24H6M2Vu4gLgXlssMHJXH/JdGPUhtbqUf1zbge40sxL/im+vSc Xmvq/Bx5/dUYKWUeqH1RL77VU2SRNekl3u7bkbKnXtu+dR0ZBeSIFKuSiH/tUX++xk4j r0kfR2P3MOPg0dHAqZPiZHwlMOarqw4qHeel6BO6/9REtLQQsVoDYIEGvharKB2B6jIL FyX/MJXVa9WkGcMgiLrMohuzoCUopmkWJj3frXNvAFoAAG1iQP6b71gQFSPSRkTgR06L CwxX6O3n9IEcBrMH1BP0AEARtoybpuvoSIROLWUjmZU6w2ycMMX9w69a21sphD43Fq2A rJ1A== X-Gm-Message-State: AOAM532vQ5KWzebTUzqn19V5ttWVhQ5H1gmxMTyg6PbdiV3MMbE2Zy0m 8S1uji17sdc1b7s8IFvPHFsqEQ== X-Google-Smtp-Source: ABdhPJzBsgHH4J5QAo+Gn1X23WEJ7Tm2fIjGmg7YoFqHNQUGWoo/feizs2yfyHBrgsdv6ewosE17vw== X-Received: by 2002:a17:902:e84b:b0:15c:fee2:aeb6 with SMTP id t11-20020a170902e84b00b0015cfee2aeb6mr27576901plg.128.1651232657669; Fri, 29 Apr 2022 04:44:17 -0700 (PDT) Received: from localhost ([139.177.225.239]) by smtp.gmail.com with ESMTPSA id u14-20020a63470e000000b003c14af5061esm5653739pga.54.2022.04.29.04.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 04:44:17 -0700 (PDT) Date: Fri, 29 Apr 2022 19:44:14 +0800 From: Muchun Song To: Peng Liu Cc: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, dave@stgolabs.net, wangborong@cdjrlc.com, linux-ia64@vger.kernel.org, adobriyan@gmail.com Subject: Re: [PATCH v4] mm: Using for_each_online_node and node_online instead of open coding Message-ID: References: <20220413032915.251254-4-liupeng256@huawei.com> <20220429030218.644635-1-liupeng256@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429030218.644635-1-liupeng256@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 03:02:18AM +0000, Peng Liu wrote: > Use more generic functions to deal with issues related to online > nodes. The changes will make the code simplified. > > Signed-off-by: Peng Liu > Suggested-by: Davidlohr Bueso > Suggested-by: Andrew Morton Reviewed-by: Muchun Song Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Date: Fri, 29 Apr 2022 11:44:14 +0000 Subject: Re: [PATCH v4] mm: Using for_each_online_node and node_online instead of open coding Message-Id: List-Id: References: <20220413032915.251254-4-liupeng256@huawei.com> <20220429030218.644635-1-liupeng256@huawei.com> In-Reply-To: <20220429030218.644635-1-liupeng256@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peng Liu Cc: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, dave@stgolabs.net, wangborong@cdjrlc.com, linux-ia64@vger.kernel.org, adobriyan@gmail.com On Fri, Apr 29, 2022 at 03:02:18AM +0000, Peng Liu wrote: > Use more generic functions to deal with issues related to online > nodes. The changes will make the code simplified. > > Signed-off-by: Peng Liu > Suggested-by: Davidlohr Bueso > Suggested-by: Andrew Morton Reviewed-by: Muchun Song Thanks.