From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B404EC433EF for ; Sat, 14 May 2022 13:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232806AbiENN7P (ORCPT ); Sat, 14 May 2022 09:59:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231148AbiENN7M (ORCPT ); Sat, 14 May 2022 09:59:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65EC5261A; Sat, 14 May 2022 06:59:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 01FE660ECF; Sat, 14 May 2022 13:59:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5B69C340EE; Sat, 14 May 2022 13:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652536750; bh=g+xjDubdqC9It71MMxt/VZzJGHiKLgv6x+YoVNGg3n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=USR88H7UqHbgW+re1jM9ZnMIlX5HMoA8oH2x5KXiZ3jk42mv9gL+pU/PESPmyScez 3JZJ13mOtgD2lkr/y8h4CgVyhPYXGmY7VeMt7yew0QSf4NVnS8L4b1irIBK4ZXKkag y1+sIDmNJTz5oilzmrpj9CMJGA4N73YXMowq5BNZrMD5D5XJ3YwMTu5TH9md8lWobJ DY0VUs+fsuxjXDUpH6ssDYt0fhem0ZBUEKOTIcNQpxpFBVaUN3WEO3YeY4kZTEc5yY YydCFCxyHHA74o21wMBvoMDFWY5sw96niigUjgX65y2Z2JRQK8sGeuN/gxUG6VTQKi IAO7TiTEunwdg== Date: Sat, 14 May 2022 15:59:06 +0200 From: Wolfram Sang To: Lucas Tanure Cc: Michal Simek , Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2 RESEND] i2c: cadence: Increase timeout per message if necessary Message-ID: Mail-Followup-To: Wolfram Sang , Lucas Tanure , Michal Simek , Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com References: <20220413091410.17970-1-tanureal@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="asp/WgYZG/X+qijA" Content-Disposition: inline In-Reply-To: <20220413091410.17970-1-tanureal@opensource.cirrus.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --asp/WgYZG/X+qijA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 13, 2022 at 10:14:10AM +0100, Lucas Tanure wrote: > Timeout as 1 second sets an upper limit on the length > of the transfer executed, but there is no maximum length > of a write or read message set in i2c_adapter_quirks for > this controller. >=20 > This upper limit affects devices that require sending > large firmware blobs over I2C. >=20 > To remove that limitation, calculate the minimal time > necessary, plus some wiggle room, for every message and > use it instead of the default one second, if more than > one second. >=20 > Signed-off-by: Lucas Tanure > Acked-by: Michal Simek Applied to for-next, thanks! --asp/WgYZG/X+qijA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJ/taoACgkQFA3kzBSg KbZOqg/9GYVmCAvpY/zjcuSmkQpOq1nTg1U2ZrPxu7uFmRWK9Jx8Rd8dh+9hHvBb YcmmCRIlVqhwuK3aAzEd3I50Rkup7aHgoJUgireISL7XFi7+33KxodiHzMJLg+Z1 uvpsZKKRvohTiBfdvtcD2S26LB6vIYiQxmCYLapT7+pqvnsfqMBx/kLJDArB3m17 w6AQTSHsMYWifMFR9zdl/bq/f/SQCISJWEW51yZEk+4lhLQfyJYyv1GS5LoeXhmH DQo/f6KJ1791bhdy6GqK3J3TJ4lQ6G1rMYwCuM2pJj+Ldo7A6DC/dtEsQ0uJGPog TaLwyHSYVQZMvLM/fgCoKND0DFlAvucyehzrR8L0pWacSe3yvIK9dA2MKvM5tk7l 95sQ1yVl5RCVDKsGQYLDXKKihGH+K1p6TjqwVFsDCRepP3dYEciwkRAzaVbuvlY7 e1EjkwYa8yvjfNtlayIPLzDyBdyRMpHbedT5h075/2qq+umWezdRKkhdWuQ45c/s 5zQlLNwCw8KOUTO8DZuYvTHJPDU4pdLBmtljD7FjF77MKR7SZYV29dzwvFUGXhG2 VTcLtR75scJaA9cU1C5k2roh3f2hWk05c5DCyoV3PdHrfUriCguXCq2WzzXniF93 pnNjLt6qZeJdwYVEns2DdpBLcrYCm2qwOOEDXOptdarZv4HO1P0= =O6TJ -----END PGP SIGNATURE----- --asp/WgYZG/X+qijA-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C65FC433EF for ; Sat, 14 May 2022 14:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z9OhL6T5YVibgSvg5JokiILSAHcXM0aKFSY4fO1BPqA=; b=smCYRIS3sW1qpQeQStJantupq3 CxYWGp+LzflJYiyukBr3aqWZtcrInvXpMx+bf1aGdSQHnRCrjLr/5kTW9AB62hYqnTjMCQ/9rsOjb +AT7+XVQM/hVbD0xEzPp/j3lZkttZ0GjfHOa9ZLqMAc15B/zib7ROdkAwUbDJWK+Hn19SZ+1uD3Qm Hu9kIwGHfN+BOIg5AG8Hz7ACDJwnVARlED9TQZ8cwKunDle5S6tLXwC1rLOUsABlPvpFlU7v1xid2 jVCAWSKzArM0q1r4EOJLGoIQxvqLuc788PAsTjoMPNIh8klQFkwYncWpdYsnDjO90wOT1EbWWFSL0 m7JCOzBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npsIe-001ZDn-8M; Sat, 14 May 2022 13:59:16 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npsIb-001ZCi-9W for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 13:59:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B3036B808C8; Sat, 14 May 2022 13:59:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5B69C340EE; Sat, 14 May 2022 13:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652536750; bh=g+xjDubdqC9It71MMxt/VZzJGHiKLgv6x+YoVNGg3n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=USR88H7UqHbgW+re1jM9ZnMIlX5HMoA8oH2x5KXiZ3jk42mv9gL+pU/PESPmyScez 3JZJ13mOtgD2lkr/y8h4CgVyhPYXGmY7VeMt7yew0QSf4NVnS8L4b1irIBK4ZXKkag y1+sIDmNJTz5oilzmrpj9CMJGA4N73YXMowq5BNZrMD5D5XJ3YwMTu5TH9md8lWobJ DY0VUs+fsuxjXDUpH6ssDYt0fhem0ZBUEKOTIcNQpxpFBVaUN3WEO3YeY4kZTEc5yY YydCFCxyHHA74o21wMBvoMDFWY5sw96niigUjgX65y2Z2JRQK8sGeuN/gxUG6VTQKi IAO7TiTEunwdg== Date: Sat, 14 May 2022 15:59:06 +0200 From: Wolfram Sang To: Lucas Tanure Cc: Michal Simek , Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2 RESEND] i2c: cadence: Increase timeout per message if necessary Message-ID: Mail-Followup-To: Wolfram Sang , Lucas Tanure , Michal Simek , Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com References: <20220413091410.17970-1-tanureal@opensource.cirrus.com> MIME-Version: 1.0 In-Reply-To: <20220413091410.17970-1-tanureal@opensource.cirrus.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_065913_522648_7E3B736A X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9142589699278917507==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9142589699278917507== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="asp/WgYZG/X+qijA" Content-Disposition: inline --asp/WgYZG/X+qijA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 13, 2022 at 10:14:10AM +0100, Lucas Tanure wrote: > Timeout as 1 second sets an upper limit on the length > of the transfer executed, but there is no maximum length > of a write or read message set in i2c_adapter_quirks for > this controller. >=20 > This upper limit affects devices that require sending > large firmware blobs over I2C. >=20 > To remove that limitation, calculate the minimal time > necessary, plus some wiggle room, for every message and > use it instead of the default one second, if more than > one second. >=20 > Signed-off-by: Lucas Tanure > Acked-by: Michal Simek Applied to for-next, thanks! --asp/WgYZG/X+qijA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJ/taoACgkQFA3kzBSg KbZOqg/9GYVmCAvpY/zjcuSmkQpOq1nTg1U2ZrPxu7uFmRWK9Jx8Rd8dh+9hHvBb YcmmCRIlVqhwuK3aAzEd3I50Rkup7aHgoJUgireISL7XFi7+33KxodiHzMJLg+Z1 uvpsZKKRvohTiBfdvtcD2S26LB6vIYiQxmCYLapT7+pqvnsfqMBx/kLJDArB3m17 w6AQTSHsMYWifMFR9zdl/bq/f/SQCISJWEW51yZEk+4lhLQfyJYyv1GS5LoeXhmH DQo/f6KJ1791bhdy6GqK3J3TJ4lQ6G1rMYwCuM2pJj+Ldo7A6DC/dtEsQ0uJGPog TaLwyHSYVQZMvLM/fgCoKND0DFlAvucyehzrR8L0pWacSe3yvIK9dA2MKvM5tk7l 95sQ1yVl5RCVDKsGQYLDXKKihGH+K1p6TjqwVFsDCRepP3dYEciwkRAzaVbuvlY7 e1EjkwYa8yvjfNtlayIPLzDyBdyRMpHbedT5h075/2qq+umWezdRKkhdWuQ45c/s 5zQlLNwCw8KOUTO8DZuYvTHJPDU4pdLBmtljD7FjF77MKR7SZYV29dzwvFUGXhG2 VTcLtR75scJaA9cU1C5k2roh3f2hWk05c5DCyoV3PdHrfUriCguXCq2WzzXniF93 pnNjLt6qZeJdwYVEns2DdpBLcrYCm2qwOOEDXOptdarZv4HO1P0= =O6TJ -----END PGP SIGNATURE----- --asp/WgYZG/X+qijA-- --===============9142589699278917507== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9142589699278917507==--