From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5D8C433EF for ; Thu, 12 May 2022 22:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359289AbiELWsO (ORCPT ); Thu, 12 May 2022 18:48:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355938AbiELWsM (ORCPT ); Thu, 12 May 2022 18:48:12 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C52E216076; Thu, 12 May 2022 15:48:11 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id a5so5346909wrp.7; Thu, 12 May 2022 15:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LenX5q8clYj/Ritl2+sXqopbOv/wuxh9dSWVaj6WujY=; b=K2axMNOwMpgK//LGT46npsuQhEEFQdyVpmgp0EPnc+YVChAmxoWbCCFtJTpiRf1Des ggQ6No7G71U25KfTlioMqTT53c+ru78fkEba7Xaf/jHn8jiT5iZ0RrNcCQ3NNOa2AT87 wJne6mV/vUoDDUEcxuR42s2N+aJ0p37Z5UvHOZ2JwlI6YYNG2xY4ahMUo8KCVMe1BZaM 2jqciX1w8jscLaGEHkyGpIF4P6Bjk6dkOLXTv55VTnxKecEkq5FEoVfhYFAhWeFDhLi4 waUknWOYMRNukEF+XH6dEvkLtUSjbwUJNZTJf1c25UcncA5hgcmgqz2x3aVkc+2/y5O/ 4qzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LenX5q8clYj/Ritl2+sXqopbOv/wuxh9dSWVaj6WujY=; b=P6DYMOyTBeLPV3ZKgpXw0tGZQTExGkgsQUpM3PHzn5GaPZJ3YcvVQZ2e4zW3FiPp5v oCApMmOAz0AMtABNXVofU39M6j2sE76WS8glJ66U9ba6QSx5i1hRMn0S3WSVk3Uj8P84 y2ZqjDZzTSAVRZWFYWawfMvQRw/jZow0npnS6C7f/Bp8v3cFJtukmre97xmrwWm5eNuW z4wBtIlrUWHuaaSbi8vwN0mGkN5ElEllLl48zTsLEnxpUts9Gd5Q+CBCUdlSyxC1h34f f0tRXwf/iN02DicrBW5ZKtOZE4sb8BEQ80XM1BjCrar89gRuw+y+cbpLBOqQqkMqYQdd 2s3g== X-Gm-Message-State: AOAM530bquvjMgxxeAZfQAPIJofkE8I3diihpjbMuxMtm1d6JtqGOjSN GNfUGLDzCkeJJwfq4tqVK+Y= X-Google-Smtp-Source: ABdhPJzVNDAOBS5AnObtbFQKaZ69q0gtsrK2qu6wMJyizLQbQOH9HFyFUfCD4w99AzyH5dGDXIKTuw== X-Received: by 2002:a5d:648b:0:b0:20c:5aec:1c06 with SMTP id o11-20020a5d648b000000b0020c5aec1c06mr1428353wri.525.1652395689697; Thu, 12 May 2022 15:48:09 -0700 (PDT) Received: from penguin ([80.149.170.9]) by smtp.gmail.com with ESMTPSA id q4-20020adf9dc4000000b0020c6b78eb5asm602278wre.68.2022.05.12.15.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 15:48:08 -0700 (PDT) Date: Fri, 13 May 2022 00:47:49 +0200 From: Dmitry Torokhov To: Pablo Ceballos Cc: Jiri Kosina , Benjamin Tissoires , lkml , "linux-input@vger.kernel.org" Subject: Re: [PATCH] HID: Driver for Google Hangouts Meet Speakermic Message-ID: References: <20220405183953.2094007-1-pceballos@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 03:35:00PM -0700, Pablo Ceballos wrote: > On Thu, May 12, 2022 at 3:53 AM Jiri Kosina wrote: > > On Thu, 12 May 2022, Dmitry Torokhov wrote: > > > I am curious, could not this be achieved without a kernel driver by > > > simply using udev to map this usage code to KEY_RESERVED? > > > > Hmm, good point, using KEY_RESERVED mapping to achieve the key being > > actually ignored didn't immediately occur to me. > > > > Pablo, could you please verify that it behaves in the expected way, and > > confirm that we could drop the 'driver' in favor of udev rule? > > I think I've achieved the same result by adding the following to udev > hwdb. Dmitry, is this what you had in mind, or is there a better way > of doing this? > > evdev:input:b0003v18D1p8001* > KEYBOARD_KEY_b002f=reserved No, that is exactly what I had in mind, thank you. Please submit this entry to upstream systemd/udev project (and we can cherry-pick it into our udev as well). In general I think we should try to avoid trivial "fixup" HID drivers if it is possible. I also wondered if we could be supplying fixed-up HID descriptors via request_firmware() for HID devices. Thanks. -- Dmitry