From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335D7C433FE for ; Fri, 13 May 2022 16:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381961AbiEMQcg (ORCPT ); Fri, 13 May 2022 12:32:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381898AbiEMQcW (ORCPT ); Fri, 13 May 2022 12:32:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8EBFC635E for ; Fri, 13 May 2022 09:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652459539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uO6U74szUS3EMQ0vAs41/itY3d7xTijwR9U6DhLEJMQ=; b=V9q+vqH+CL5ZKdN7GrHB9vYAD7XNrhn0L4EVDRVMzj7VCzHQDXpC9gb0NXDsiuZfpsfkFc 08PvAVy+D22DywB8V+RhAHU+iUoghwanD/KDhkEHufSeqxbpas6g7Zl7JhxiSpumwPuN7o oGblppNuKQkvPx9X9nlW4cadKwd1fu4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-wMI-x-GzPfeDnMY4eNy2CQ-1; Fri, 13 May 2022 12:32:16 -0400 X-MC-Unique: wMI-x-GzPfeDnMY4eNy2CQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B2A8E101AA44; Fri, 13 May 2022 16:32:15 +0000 (UTC) Received: from lorien.usersys.redhat.com (unknown [10.22.16.240]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 811072166B4E; Fri, 13 May 2022 16:32:12 +0000 (UTC) Date: Fri, 13 May 2022 12:32:10 -0400 From: Phil Auld To: Waiman Long Cc: linux-kernel@vger.kernel.org, mkoutny@suse.com, tj@kernel.org Subject: Re: [PATCH] kselftest/cgroup: fix test_stress.sh to use OUTPUT dir Message-ID: References: <20220512143439.26104-1-pauld@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2022 at 12:19:24PM -0400 Waiman Long wrote: > > On 5/12/22 10:34, Phil Auld wrote: > > Running cgroup kselftest with O= fails to run the with_stress test due > > to hardcoded ./test_core. Find test_core binary using the OUTPUT directory. > > > > Fixes: 1a99fcc035fb ("selftests: cgroup: Run test_core under interfering stress") > > Signed-off-by: Phil Auld > > --- > > tools/testing/selftests/cgroup/test_stress.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/cgroup/test_stress.sh b/tools/testing/selftests/cgroup/test_stress.sh > > index 15d9d5896394..109c044f715f 100755 > > --- a/tools/testing/selftests/cgroup/test_stress.sh > > +++ b/tools/testing/selftests/cgroup/test_stress.sh > > @@ -1,4 +1,4 @@ > > #!/bin/bash > > # SPDX-License-Identifier: GPL-2.0 > > -./with_stress.sh -s subsys -s fork ./test_core > > +./with_stress.sh -s subsys -s fork ${OUTPUT}/test_core > > > I would suggest using "${OUTPUT:-.}" as the variable OUTPUT may not be > defined if test_stress.sh is run interactively. > I worked both ways as is. > Cheers, > Longman > --