Re: [PATCH 0/4] Request to cherry-pick f00432063db1 to 5.10

From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Meena Shanmugam <meenashanmugam@google.com>
Cc: gregkh@linuxfoundation.org, enrico.scholz@sigma-chemnitz.de,
	stable@vger.kernel.org, trond.myklebust@hammerspace.com,
	Dexter Rivera <riverade@google.com>
Subject: Re: [PATCH 0/4] Request to cherry-pick f00432063db1 to 5.10
Date: Sat, 14 May 2022 15:47:38 +0700	[thread overview]
Message-ID: <Yn9sqjJsnsLznmoq@debian.me> (raw)
In-Reply-To: <20220514053453.3277330-1-meenashanmugam@google.com>

On Sat, May 14, 2022 at 05:34:49AM +0000, Meena Shanmugam wrote:
> The commit f00432063db1a0db484e85193eccc6845435b80e upstream (SUNRPC:
> Ensure we flush any closed sockets before xs_xprt_free()) fixes
> CVE-2022-28893, hence good candidate for stable trees.
> The above commit depends on 3be232f(SUNRPC: Prevent immediate
> close+reconnect)  and  89f4249(SUNRPC: Don't call connect() more than
> once on a TCP socket). Commit 3be232f depends on commit
> e26d9972720e(SUNRPC: Clean up scheduling of autoclose).
> 
> Commits e26d9972720e, 3be232f, f00432063db1 apply cleanly on 5.10
> kernel. commit 89f4249 didn't apply cleanly. This patch series includes
> all the commits required for back porting f00432063db1.
> 

Hi Meena,

I can't speaking about the code (as I'm not subject-expert here), but I
would like to give you suggestions:

  - When sending backported patch series, always prefix the subject with
    "[PATCH x.y]", where x.y is the stable version the backport is made
    against.
  - Abbreviated commit hash should be at least 12 (or my favorite, 14) characters long.
  - Commit identifier should be in format "%h (\"%s\")".
  - As always, DON'T DO top-posting, DO interleaved reply and reply
    below the quoted original message.

Trond and Dexter, any comments or ACKs?

Thanks.

-- 
An old man doll... just what I always wanted! - Clara