All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Weil <sw@weilnetz.de>
Subject: Re: [PATCH 0/3] coroutine: use QEMU_DEFINE_STATIC_CO_TLS()
Date: Tue, 3 May 2022 12:48:27 +0200	[thread overview]
Message-ID: <YnEHPRupoWDtrG4U@redhat.com> (raw)
In-Reply-To: <20220307153853.602859-1-stefanha@redhat.com>

Am 07.03.2022 um 16:38 hat Stefan Hajnoczi geschrieben:
> The coroutine implementation uses __thread variables internally. Compiler
> optimizations may cache Thread-Local Storage values across
> qemu_coroutine_yield(), leading to stale values being used after the coroutine
> is re-entered from another thread.
> 
> Kevin pointed out that the coroutine implementation itself is vulnerable to
> this problem. As a follow-up to my coroutine TLS patch series I'm sending these
> patches to convert __thread variables to the new "qemu/coroutine-tls.h" macros
> so they are safe.

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2022-05-03 11:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 15:38 [PATCH 0/3] coroutine: use QEMU_DEFINE_STATIC_CO_TLS() Stefan Hajnoczi
2022-03-07 15:38 ` [PATCH 1/3] coroutine-ucontext: " Stefan Hajnoczi
2022-03-07 15:38 ` [PATCH 2/3] coroutine: " Stefan Hajnoczi
2022-03-07 15:38 ` [PATCH 3/3] coroutine-win32: " Stefan Hajnoczi
2022-03-07 16:03 ` [PATCH 0/3] coroutine: " Philippe Mathieu-Daudé
2022-03-16 13:28 ` Stefan Hajnoczi
2022-05-03 10:48 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnEHPRupoWDtrG4U@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.