From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA50C433EF for ; Tue, 3 May 2022 13:00:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9364B6B0078; Tue, 3 May 2022 09:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E61B6B007B; Tue, 3 May 2022 09:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D4CA6B007D; Tue, 3 May 2022 09:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 6DF386B0078 for ; Tue, 3 May 2022 09:00:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 362922B31C for ; Tue, 3 May 2022 13:00:11 +0000 (UTC) X-FDA: 79424439822.06.72305C0 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 11F09120092 for ; Tue, 3 May 2022 13:00:05 +0000 (UTC) Date: Tue, 3 May 2022 15:00:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1651582808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6ERYw//u5FU5vVjrbUic9geB9P1IBgXIN9HR45kCeeg=; b=dOJb8UAndZxizRfShfAxxTeljO1hQL56VsgGwlAUJemGeFFm0srUr7RjE13n5EM69ojWFl v1JXQ9rN/UdObLNlzgjm9VbqxyPk9S4QwQnaDOK1emx5SL59cIZbnIGschLDoCLe0opsJc Nx0m2q55rv1Ef5Ha3DIVi/6AQnuMhVwyZFTzKOd+9WpxhNHLZuzqVaDjwVpkxBcHih4Iz8 7gTk13sguJYO/Bqd6EKMiEhnGwQjSInbhX5RtgsajtdtPZyJmRRKc6zihh74xy3eP1fNbA zKfWyQMrDuZzmFbXcymOXSmJjDcuESmD6QMD10xU3sP9zSwwgIJKE7Q4Q+FXiQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1651582808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6ERYw//u5FU5vVjrbUic9geB9P1IBgXIN9HR45kCeeg=; b=ksEVB3IwkMsx3JpssJRyQrZJwYFB1LPGOay+rX25VveyvFZOyCvg20EPDP7g6Axrdjyfla MfKPc6l14kLjiBDA== From: Sebastian Andrzej Siewior To: Matthew Wilcox Cc: akpm@linuxfoundation.org, linux-mm@kvack.org, tglx@linutronix.de Subject: Re: [PATCH 16/21] mm/shmem: Convert shmem_add_to_page_cache to take a folio Message-ID: References: <20220429192329.3034378-1-willy@infradead.org> <20220429192329.3034378-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: e4pk9mbqx7b7iu86odjghcwsdey5caxm Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=dOJb8UAn; dkim=pass header.d=linutronix.de header.s=2020e header.b=ksEVB3Iw; spf=pass (imf29.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 11F09120092 X-HE-Tag: 1651582805-621003 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-05-03 13:48:50 [+0100], Matthew Wilcox wrote: > Thanks. Stephen already reported that; fix here: > > https://lore.kernel.org/all/Ym++SI1ftbRg+9zK@casper.infradead.org/ Stephen says "I applied the above patch to the mm tree merge today" and I have here next-20220503. I don't have the BUILD_BUG() in can_split_folio() anymore so I have this change. My guess is that since THP_FILE_ALLOC is defined as BUILD_BUG() for !CONFIG_TRANSPARENT_HUGEPAGE and there is nothing that removes that part of the code, I end up in BUILD_BUG with CGROUP and no THP. PageTransHuge() used to "return false" for !CONFIG_TRANSPARENT_HUGEPAGE which isn't the case for folio_test_large(). Sebastian