From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474A4C433FE for ; Wed, 4 May 2022 18:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377252AbiEDStn (ORCPT ); Wed, 4 May 2022 14:49:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377241AbiEDStl (ORCPT ); Wed, 4 May 2022 14:49:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3B4101DC; Wed, 4 May 2022 11:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Dn3HTp6KUp78ZFzWlHBYdXj5KOE/G4agBHq21Rs9ZcU=; b=q8P31BgeHM8LksWa1g6pVQGEev 8H/7gSHdSIGf4hnUZNG6k+NP/eyDVuhEa+E/bIHsjVXN5T1EKYCJy7/bIZ2gwofMBVL0m04h906iy O3m6WyGqfypCYPOeFlE0zbL6KzH75Dt6yQynZ2YQb+tjQcvc8h0DNJLxPlj13yCZ/0fHhfWFYko29 +mbPlaxqsXq8iB7o++eo7wHDCeL+pv7RLP4uld2Owm2FwNjROt2Nbdn7jgEo1D8SAnfFhVijf+4Ah 2gPgRMk9OnlAr8zlq0l5QdnCMe8bwU9AhVy3E7SmAac3O5pVOrjuKc62H1lx2a7NKVVOWSVVV3BVX R0OH7blQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmK0f-00CBsb-2f; Wed, 04 May 2022 18:46:01 +0000 Date: Wed, 4 May 2022 11:46:01 -0700 From: Luis Chamberlain To: Daniel Latypov Cc: David Gow , Shuah Khan , Lucas De Marchi , Aaron Tomlin , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Brendan Higgins , Andy Shevchenko , Jonathan Corbet , Andrew Morton , Kees Cook , Greg KH , "Guilherme G . Piccoli" , Sebastian Reichel , John Ogness , Joe Fradley , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula Subject: Re: [PATCH v2] kunit: Taint kernel if any tests run Message-ID: References: <20220429043913.626647-1-davidgow@google.com> <20220430030019.803481-1-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, May 04, 2022 at 11:25:14AM -0500, Daniel Latypov wrote: > On Wed, May 4, 2022 at 9:51 AM Luis Chamberlain wrote: > > selftests has modules, although I am not sure if there are selftests > > which do not load modules. Shuah? > > I'm not Shuah, but there are indeed selftests that don't load modules. > > I went looking for an example and found > tools/testing/selftests/bpf/test_doc_build.sh, which runs entirely in > userspace (basically just `make docs`). OK so, we can just skip tainting considerations for selftests which don't use modules for now. There may be selftests which do wonky things in userspace but indeed I agree the userspace taint would be better for those but I don't think it may be worth bother worrying about those at this point in time. But my point in that sharing a taint between kunit / selftests modules does make sense and is easily possible. The unfortunate aspect is just that selftests don't have a centralized runner, because I can just run tools/testing/selftests/sysctl/sysctl.sh for example and that's it. So I think we have no other option but to just add the module info manually for selftests at this time. Luis