From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B301C433EF for ; Thu, 5 May 2022 11:57:44 +0000 (UTC) Received: from localhost ([::1]:36884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nma75-0000Ay-6P for qemu-devel@archiver.kernel.org; Thu, 05 May 2022 07:57:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nma5W-0006FV-6B for qemu-devel@nongnu.org; Thu, 05 May 2022 07:56:06 -0400 Received: from us-smtp-delivery-74.mimecast.com ([170.10.129.74]:40486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nma5U-0002Tw-EL for qemu-devel@nongnu.org; Thu, 05 May 2022 07:56:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651751763; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pkXTg9qLeekgSjMdvAVBSnjl3PVLzxH8UNxCbsffgJc=; b=WFlLceAetrnw8ZONnFsoLq3z5ZvNVAm/U4cK6MDZaYu2XGXJ8h3WRDiyoWF8jADxu6PUHp /bpgHHdf/n90AKm+dp761kiPh4HcW4ARCTiq+vzWxoBgGbVWp8NB11oP71vrxGQTtEL35I 5rpNtpip7QAOMr0+lR0yVpfobTfTXAY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-283-Yx4vcvX_P7G9bwVURefRqg-1; Thu, 05 May 2022 07:56:00 -0400 X-MC-Unique: Yx4vcvX_P7G9bwVURefRqg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64C093C62B63; Thu, 5 May 2022 11:56:00 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.128]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDF51551E6E; Thu, 5 May 2022 11:55:59 +0000 (UTC) Date: Thu, 5 May 2022 12:55:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth , qemu-devel@nongnu.org, Yonggang Luo Subject: Re: [PATCH] docs/about: Update the support statement for Windows Message-ID: References: <20220505074841.406185-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.74; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-74.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 05, 2022 at 09:14:57AM +0100, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 09:48:41AM +0200, Thomas Huth wrote: > > Our support statement for Windows currently talks about "Vista / Server > > 2008" - which is related to the API of Windows, and this is not easy > > to understand for the non-technical users. It might also not be quite > > true anymore, since we only compile-test QEMU with recent toolchains. > > We documented Vista / Server 2008 because that is what our code is > declaring it wants in terms of Windows public APIs: > > In osdep.h we have: > > #ifdef _WIN32 > /* as defined in sdkddkver.h */ > #ifndef _WIN32_WINNT > #define _WIN32_WINNT 0x0600 /* Vista */ > #endif > > which tells Mingw / MSys not to expose windows header file declarations > that post-date Vista. Of course we rely on 3rd party libraries and in particular GLib2 is mandatory, and it also set _WIN32_WINNT. So our constraint is the newer of the _WIN32_WINNT constraint set by QEMU and whatever version of GLib2 being compiled against. QEMU sets a min GLib of 2.56, and that version of GLib sets 0x0601 which means Windows >= 7. So even though QEMU only asks for Vista, in practice our minimum is 7. Given that we should increase QEMU's own _WIN32_WINNT value to 0x601 too, since its impossible to build with older GLib than 2.56. Next time we bump GLib min version, we should remember to check their _WIN32_WINNT value. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|