[PATCH] crypto: vmx - Align the short log with Makefile cleanups

[PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Masahiro Yamada]

I notieced the log is not properly aligned:

  PERL drivers/crypto/vmx/aesp8-ppc.S
  CC [M]  fs/xfs/xfs_reflink.o
  PERL drivers/crypto/vmx/ghashp8-ppc.S
  CC [M]  drivers/crypto/vmx/aes.o

Add some spaces after 'PERL'.

While I was here, I cleaned up the Makefile:

 - Merge the two similar rules

 - Remove redundant 'clean-files' (Having 'targets' is enough)

 - Move the flavour into the build command

This still avoids the build failures fixed by commit 4ee812f6143d
("crypto: vmx - Avoid weird build failures").

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/crypto/vmx/Makefile | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile
index 709670d2b553..df93ba63b1cd 100644
--- a/drivers/crypto/vmx/Makefile
+++ b/drivers/crypto/vmx/Makefile
@@ -2,21 +2,10 @@
 obj-$(CONFIG_CRYPTO_DEV_VMX_ENCRYPT) += vmx-crypto.o
 vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o aes_cbc.o aes_ctr.o aes_xts.o ghash.o
 
-ifeq ($(CONFIG_CPU_LITTLE_ENDIAN),y)
-override flavour := linux-ppc64le
-else
-override flavour := linux-ppc64
-endif
-
-quiet_cmd_perl = PERL $@
-      cmd_perl = $(PERL) $(<) $(flavour) > $(@)
+quiet_cmd_perl = PERL    $@
+      cmd_perl = $(PERL) $< $(if $(CONFIG_LITTLE_ENDIAN), linux-ppc64le, linux-ppc64) > $@
 
 targets += aesp8-ppc.S ghashp8-ppc.S
 
-$(obj)/aesp8-ppc.S: $(src)/aesp8-ppc.pl FORCE
-	$(call if_changed,perl)
-  
-$(obj)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl FORCE
+$(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S: $(obj)/%.S: $(src)/%.pl FORCE
 	$(call if_changed,perl)
-
-clean-files := aesp8-ppc.S ghashp8-ppc.S
-- 
2.32.0

[PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Masahiro Yamada]

I notieced the log is not properly aligned:

  PERL drivers/crypto/vmx/aesp8-ppc.S
  CC [M]  fs/xfs/xfs_reflink.o
  PERL drivers/crypto/vmx/ghashp8-ppc.S
  CC [M]  drivers/crypto/vmx/aes.o

Add some spaces after 'PERL'.

While I was here, I cleaned up the Makefile:

 - Merge the two similar rules

 - Remove redundant 'clean-files' (Having 'targets' is enough)

 - Move the flavour into the build command

This still avoids the build failures fixed by commit 4ee812f6143d
("crypto: vmx - Avoid weird build failures").

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/crypto/vmx/Makefile | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile
index 709670d2b553..df93ba63b1cd 100644
--- a/drivers/crypto/vmx/Makefile
+++ b/drivers/crypto/vmx/Makefile
@@ -2,21 +2,10 @@
 obj-$(CONFIG_CRYPTO_DEV_VMX_ENCRYPT) += vmx-crypto.o
 vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o aes_cbc.o aes_ctr.o aes_xts.o ghash.o
 
-ifeq ($(CONFIG_CPU_LITTLE_ENDIAN),y)
-override flavour := linux-ppc64le
-else
-override flavour := linux-ppc64
-endif
-
-quiet_cmd_perl = PERL $@
-      cmd_perl = $(PERL) $(<) $(flavour) > $(@)
+quiet_cmd_perl = PERL    $@
+      cmd_perl = $(PERL) $< $(if $(CONFIG_LITTLE_ENDIAN), linux-ppc64le, linux-ppc64) > $@
 
 targets += aesp8-ppc.S ghashp8-ppc.S
 
-$(obj)/aesp8-ppc.S: $(src)/aesp8-ppc.pl FORCE
-	$(call if_changed,perl)
-  
-$(obj)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl FORCE
+$(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S: $(obj)/%.S: $(src)/%.pl FORCE
 	$(call if_changed,perl)
-
-clean-files := aesp8-ppc.S ghashp8-ppc.S
-- 
2.32.0

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[kernel test robot]

Hi Masahiro,

I love your patch! Yet something to improve:

[auto build test ERROR on herbert-crypto-2.6/master]
[also build test ERROR on herbert-cryptodev-2.6/master powerpc/next v5.18-rc5 next-20220503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Masahiro-Yamada/crypto-vmx-Align-the-short-log-with-Makefile-cleanups/20220501-211151
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
config: powerpc64-randconfig-c024-20220501 (https://download.01.org/0day-ci/archive/20220503/202205032046.GVMtYY1b-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ee5bc3b577c98befd8dfe65bbcd877e2f246470d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Masahiro-Yamada/crypto-vmx-Align-the-short-log-with-Makefile-cleanups/20220501-211151
        git checkout ee5bc3b577c98befd8dfe65bbcd877e2f246470d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   /tmp/ccMTXCTj.s: Assembler messages:
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_set_encrypt_key does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_set_encrypt_key does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_set_decrypt_key does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_set_decrypt_key does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_encrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_encrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_decrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_decrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_cbc_encrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_cbc_encrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_ctr32_encrypt_blocks does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_ctr32_encrypt_blocks does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_xts_encrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_xts_encrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for aes_p8_xts_decrypt does not evaluate to a constant
>> /tmp/ccMTXCTj.s: Error: .size expression for .aes_p8_xts_decrypt does not evaluate to a constant
--
   /tmp/cci7g2fQ.s: Assembler messages:
>> /tmp/cci7g2fQ.s: Error: .size expression for gcm_init_p8 does not evaluate to a constant
>> /tmp/cci7g2fQ.s: Error: .size expression for .gcm_init_p8 does not evaluate to a constant
>> /tmp/cci7g2fQ.s: Error: .size expression for gcm_gmult_p8 does not evaluate to a constant
>> /tmp/cci7g2fQ.s: Error: .size expression for .gcm_gmult_p8 does not evaluate to a constant
>> /tmp/cci7g2fQ.s: Error: .size expression for gcm_ghash_p8 does not evaluate to a constant
>> /tmp/cci7g2fQ.s: Error: .size expression for .gcm_ghash_p8 does not evaluate to a constant

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Herbert Xu]

On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> I notieced the log is not properly aligned:
> 
>   PERL drivers/crypto/vmx/aesp8-ppc.S
>   CC [M]  fs/xfs/xfs_reflink.o
>   PERL drivers/crypto/vmx/ghashp8-ppc.S
>   CC [M]  drivers/crypto/vmx/aes.o
> 
> Add some spaces after 'PERL'.
> 
> While I was here, I cleaned up the Makefile:
> 
>  - Merge the two similar rules
> 
>  - Remove redundant 'clean-files' (Having 'targets' is enough)
> 
>  - Move the flavour into the build command
> 
> This still avoids the build failures fixed by commit 4ee812f6143d
> ("crypto: vmx - Avoid weird build failures").
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  drivers/crypto/vmx/Makefile | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Herbert Xu]

On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> I notieced the log is not properly aligned:
> 
>   PERL drivers/crypto/vmx/aesp8-ppc.S
>   CC [M]  fs/xfs/xfs_reflink.o
>   PERL drivers/crypto/vmx/ghashp8-ppc.S
>   CC [M]  drivers/crypto/vmx/aes.o
> 
> Add some spaces after 'PERL'.
> 
> While I was here, I cleaned up the Makefile:
> 
>  - Merge the two similar rules
> 
>  - Remove redundant 'clean-files' (Having 'targets' is enough)
> 
>  - Move the flavour into the build command
> 
> This still avoids the build failures fixed by commit 4ee812f6143d
> ("crypto: vmx - Avoid weird build failures").
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  drivers/crypto/vmx/Makefile | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Masahiro Yamada]

Hi Herbert,



On Fri, May 6, 2022 at 7:23 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> > I notieced the log is not properly aligned:
> >
> >   PERL drivers/crypto/vmx/aesp8-ppc.S
> >   CC [M]  fs/xfs/xfs_reflink.o
> >   PERL drivers/crypto/vmx/ghashp8-ppc.S
> >   CC [M]  drivers/crypto/vmx/aes.o
> >
> > Add some spaces after 'PERL'.
> >
> > While I was here, I cleaned up the Makefile:
> >
> >  - Merge the two similar rules
> >
> >  - Remove redundant 'clean-files' (Having 'targets' is enough)
> >
> >  - Move the flavour into the build command
> >
> > This still avoids the build failures fixed by commit 4ee812f6143d
> > ("crypto: vmx - Avoid weird build failures").
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  drivers/crypto/vmx/Makefile | 17 +++--------------
> >  1 file changed, 3 insertions(+), 14 deletions(-)
>
> Patch applied.  Thanks.


Sorry, I just noticed the 0day bot had reported the error.

I sent v2.    (CONFIG_LITTLE_ENDIAN  --> CONFIG_CPU_LITTLE_ENDIAN)

https://lore.kernel.org/lkml/20220506150820.1310802-1-masahiroy@kernel.org/


Could you replace it, or fix it up, please?





--
Best Regards
Masahiro Yamada

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Masahiro Yamada]

Hi Herbert,



On Fri, May 6, 2022 at 7:23 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sun, May 01, 2022 at 10:07:49PM +0900, Masahiro Yamada wrote:
> > I notieced the log is not properly aligned:
> >
> >   PERL drivers/crypto/vmx/aesp8-ppc.S
> >   CC [M]  fs/xfs/xfs_reflink.o
> >   PERL drivers/crypto/vmx/ghashp8-ppc.S
> >   CC [M]  drivers/crypto/vmx/aes.o
> >
> > Add some spaces after 'PERL'.
> >
> > While I was here, I cleaned up the Makefile:
> >
> >  - Merge the two similar rules
> >
> >  - Remove redundant 'clean-files' (Having 'targets' is enough)
> >
> >  - Move the flavour into the build command
> >
> > This still avoids the build failures fixed by commit 4ee812f6143d
> > ("crypto: vmx - Avoid weird build failures").
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  drivers/crypto/vmx/Makefile | 17 +++--------------
> >  1 file changed, 3 insertions(+), 14 deletions(-)
>
> Patch applied.  Thanks.


Sorry, I just noticed the 0day bot had reported the error.

I sent v2.    (CONFIG_LITTLE_ENDIAN  --> CONFIG_CPU_LITTLE_ENDIAN)

https://lore.kernel.org/lkml/20220506150820.1310802-1-masahiroy@kernel.org/


Could you replace it, or fix it up, please?





--
Best Regards
Masahiro Yamada

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Herbert Xu]

On Sat, May 07, 2022 at 12:25:32AM +0900, Masahiro Yamada wrote:
>
> Sorry, I just noticed the 0day bot had reported the error.
> 
> I sent v2.    (CONFIG_LITTLE_ENDIAN  --> CONFIG_CPU_LITTLE_ENDIAN)
> 
> https://lore.kernel.org/lkml/20220506150820.1310802-1-masahiroy@kernel.org/
> 
> 
> Could you replace it, or fix it up, please?

Please send me an incremental patch.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Herbert Xu]

On Sat, May 07, 2022 at 12:25:32AM +0900, Masahiro Yamada wrote:
>
> Sorry, I just noticed the 0day bot had reported the error.
> 
> I sent v2.    (CONFIG_LITTLE_ENDIAN  --> CONFIG_CPU_LITTLE_ENDIAN)
> 
> https://lore.kernel.org/lkml/20220506150820.1310802-1-masahiroy@kernel.org/
> 
> 
> Could you replace it, or fix it up, please?

Please send me an incremental patch.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Masahiro Yamada]

On Sat, May 7, 2022 at 11:02 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sat, May 07, 2022 at 12:25:32AM +0900, Masahiro Yamada wrote:
> >
> > Sorry, I just noticed the 0day bot had reported the error.
> >
> > I sent v2.    (CONFIG_LITTLE_ENDIAN  --> CONFIG_CPU_LITTLE_ENDIAN)
> >
> > https://lore.kernel.org/lkml/20220506150820.1310802-1-masahiroy@kernel.org/
> >
> >
> > Could you replace it, or fix it up, please?
>
> Please send me an incremental patch.

Done.

BTW, you added a wrong Reported-by tag:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=b52455a73db95ef90fd3c2be84db77b55be43f46

It is a clean up patch, where 0day bot did not report anything.




-- 
Best Regards
Masahiro Yamada

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

[Masahiro Yamada]

On Sat, May 7, 2022 at 11:02 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sat, May 07, 2022 at 12:25:32AM +0900, Masahiro Yamada wrote:
> >
> > Sorry, I just noticed the 0day bot had reported the error.
> >
> > I sent v2.    (CONFIG_LITTLE_ENDIAN  --> CONFIG_CPU_LITTLE_ENDIAN)
> >
> > https://lore.kernel.org/lkml/20220506150820.1310802-1-masahiroy@kernel.org/
> >
> >
> > Could you replace it, or fix it up, please?
>
> Please send me an incremental patch.

Done.

BTW, you added a wrong Reported-by tag:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=b52455a73db95ef90fd3c2be84db77b55be43f46

It is a clean up patch, where 0day bot did not report anything.




-- 
Best Regards
Masahiro Yamada