From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C11C433F5 for ; Sat, 7 May 2022 08:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446069AbiEGIUG (ORCPT ); Sat, 7 May 2022 04:20:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238744AbiEGIUE (ORCPT ); Sat, 7 May 2022 04:20:04 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 397AEA7 for ; Sat, 7 May 2022 01:16:18 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id a14-20020a7bc1ce000000b00393fb52a386so8126151wmj.1 for ; Sat, 07 May 2022 01:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ocuJE0gAGEqaqKxUV4jvj8obtrJ431aiQbMs9D9K8C4=; b=Rt3p2REQwsRDFGcxc3f5ldBLgHOLUPQjis5BAVkVrGD/bwgBomG2SR2kPYmDlt7bto rRatI1I614wEHxyZ2Gc4oCwOWThnJQ2EB4EHYxJNi3adcUjk51D8SQGS3B3hTtPtCFKA /Af1ET/T3OXRbb8k5QL0+QmJiuPRAMWrDEhBJztaydK4d3KIvldLJmh4sEMYvQqZNQet eWZd4YXeSHU/6y64khr+LUBIAUZ1/ItXV7hgg/DW9yWYI8PbFt4kUOH/rCwbgghgENHN N+RpSTEhkHVc/lPsGrDzPSZLOn8o+MnHAi8cfsVZaLAUQdom3OCdM6O2cmOO07+QQHFI BM7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ocuJE0gAGEqaqKxUV4jvj8obtrJ431aiQbMs9D9K8C4=; b=R2mog/z7wLSWgv+oVImR4JSEdtSmTLS2WofAdEiwZmVGRfuUygq0OhIqj5ZxJzqyB1 CJUdsp9JrdPxlEYmiuAlSzYUflOjNMsmJ91f5A2jExA278w2aj0AL+yA3d6kjMjf/x54 1z75uMMUql5moODAN+QQuixrCZUyAj13sa+n93ZZVy8/Ulex1uvp5oYGsKy2vuZC0kAm cHkQQ5KMJLsk88qfc0HuOPEKksZFPN2Sl9q+RoxVl3VVby0X22X/Fo71lpXxtCdb3S3D PwwJbgB6u5RkIc6xEQIcSfh79zznrY+2bWcNuJlsk4Q6R2SxM8386snE80LcV2KT7FRj tbMA== X-Gm-Message-State: AOAM533NcFYHK2zNeMKpzQ/9l/ouYQk8JclypMlGMRBY4AwDZW2h+swO iKeIobs86Lsgr14Zq84oPWpfYA== X-Google-Smtp-Source: ABdhPJx9s5perey3uFNE4Jbpnstue3qwJxcFldfSIn/vkY0AMcMDK8ljm5rKJAhbcQdtDc/3xKmlcw== X-Received: by 2002:a05:600c:281:b0:394:1075:fe3e with SMTP id 1-20020a05600c028100b003941075fe3emr13513613wmk.155.1651911376473; Sat, 07 May 2022 01:16:16 -0700 (PDT) Received: from google.com (49.222.77.34.bc.googleusercontent.com. [34.77.222.49]) by smtp.gmail.com with ESMTPSA id v128-20020a1cac86000000b003942a244f56sm10957782wme.47.2022.05.07.01.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 May 2022 01:16:16 -0700 (PDT) Date: Sat, 7 May 2022 08:16:14 +0000 From: Sebastian Ene To: Sebastian Ene Cc: linux-kernel@vger.kernel.org, Derek Kiernan , Dragan Cvetic , Arnd Bergmann , devicetree@vger.kernel.org, qperret@google.com, will@kernel.org, maz@kernel.org, Greg Kroah-Hartman , Rob Herring , Guenter Roeck Subject: Re: [PATCH v4 1/2] dt-bindings: vm-wdt: Add qemu,vm-watchdog compatible Message-ID: References: <20220429083030.3241640-1-sebastianene@google.com> <20220429083030.3241640-2-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429083030.3241640-2-sebastianene@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 08:30:31AM +0000, Sebastian Ene wrote: > The stall detection mechanism allows to configure the expiration > duration and the internal counter clock frequency measured in Hz. > Add these properties in the schema. > > Signed-off-by: Sebastian Ene > --- > .../devicetree/bindings/misc/vm-watchdog.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/vm-watchdog.yaml > > diff --git a/Documentation/devicetree/bindings/misc/vm-watchdog.yaml b/Documentation/devicetree/bindings/misc/vm-watchdog.yaml > new file mode 100644 > index 000000000000..d7cca23357ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/vm-watchdog.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/vm-watchdog.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: VM watchdog > + > +description: | > + This binding describes a CPU stall detector mechanism for virtual cpus > + which is accessed through MMIO. > + > +maintainers: > + - Sebastian Ene > + > +properties: > + compatible: > + enum: > + - qemu,vm-watchdog > + clock-frequency: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + The watchdog internal clock measure in Hz used to decrement the > + watchdog counter register on each tick. > + Defaults to 10 if unset. > + timeout-sec: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + The watchdog expiration timeout measured in seconds. > + Defaults to 8 if unset. > + > +required: > + - compatible > + > +additionalProperties: false Hi, > + > +examples: > + - | > + watchdog { > + compatible = "qemu,vm-watchdog"; > + clock-frequency = <10>; > + timeout-sec = <8>; > + }; > + > +... > -- > 2.36.0.464.gb9c8b46e94-goog > I was thinking to move the properties clock-frequency and timeout-sec as part of the emulated watchdog registers and keep only the registers property in the DT. Thanks, Seb