From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16995C433EF for ; Sun, 8 May 2022 15:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234762AbiEHPaU (ORCPT ); Sun, 8 May 2022 11:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234692AbiEHPaP (ORCPT ); Sun, 8 May 2022 11:30:15 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69A2EB87 for ; Sun, 8 May 2022 08:26:25 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id a11so10265838pff.1 for ; Sun, 08 May 2022 08:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wlb5sCv0vT9DKd6Y0pxChn3TRESHpDGd2RiWXJbPiOA=; b=A8uBy/esNOEbUqh4vOntGYm1YMVp8KTDNwiHyleMxFUxETUvcSv6DZ39zZIcwk5yYw 86UrDKPKDKAZMR7dwUoHWD+jUB4gtgw1yCKhEiU7ARnW49msAlzrKSzQ8vYFlTYpNIt4 hQLknIHiDmcV0B5wHAtIxy+UOOM5eEY20zDhI9WMiJaDrUjdvDVuVJ7iiy5qzG1y47jV 5gEm227YJe0hvNojSjOoSAN3C1iYnEXrtZFcNuKVuuM/p8p/52As0MlF3Mk2EzYn6wr/ J7bXPbCej7CVuXF4I6IX7/Rq1hiMYtnD6AFcfLgLxgY9EZUeI+It1LKO31oPmsw6uMey wxog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wlb5sCv0vT9DKd6Y0pxChn3TRESHpDGd2RiWXJbPiOA=; b=LPT/3b5w0zQtdaK9Yy8FddcHtCsQaNBgN+7D46blPISxLqRph0HTTs1AfpjzpZO9Np gpC+wy11U8T7odlOL0TALjAVL+79O9LBhCmuxaJT7x4JX8PRgX90ssOJCpsaA+ob8ijL V495YhJvuyX+pyUsXr2qMLBrzw4iWpOws20rp+j0CyUKyzi7CnCwLD+xmG+f3St2eDoO ioq3UhAwxKnPfiPijNAx5ieHVApfNKvuaZ0b0I1UgLyCLQv0Ci28CY/a1FBbXBnYq+WR fPibguxraISp5ugUutyBClKGaVcT0mWLYoS1RkVj97H0/WEXGtvn/lYItB3ebVAArXxQ zJvA== X-Gm-Message-State: AOAM5323lFFwnSCoH7QiztpYhG2bvfIFktmWmKMWWGqQUomv9pJtgZ5u ADfSf9Fh4v9Wz+O/SQQLf3tAyIfgTu0K7Q== X-Google-Smtp-Source: ABdhPJwrAUBJu+P2n6cQJedLTi8BGUZ973hWDTaS8Y3nr73sK+kVeWZgWILLCvpX1mBPKLFMAkg+uw== X-Received: by 2002:aa7:9d0d:0:b0:50d:4fcc:7cb1 with SMTP id k13-20020aa79d0d000000b0050d4fcc7cb1mr11948987pfp.41.1652023584948; Sun, 08 May 2022 08:26:24 -0700 (PDT) Received: from localhost ([139.177.225.250]) by smtp.gmail.com with ESMTPSA id a19-20020a170902b59300b0015e8d4eb229sm5253221pls.115.2022.05.08.08.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 08:26:24 -0700 (PDT) Date: Sun, 8 May 2022 23:26:21 +0800 From: Muchun Song To: Baolin Wang Cc: catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mike.kravetz@oracle.com, akpm@linux-foundation.org, sj@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 0/3] Introduce new huge_ptep_get_access_flags() interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 08, 2022 at 04:58:51PM +0800, Baolin Wang wrote: > Hi, > > As Mike pointed out [1], the huge_ptep_get() will only return one specific > pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which > will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD > size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD > size hugetlb page for those functions that want to check the dirty or > young flags of a hugetlb page. For example, the gather_hugetlb_stats() will > get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring > will also get inaccurate access statistics. > > To fix this issue, one approach is that we can define an ARM64 specific huge_ptep_get() > implementation, which will take into account any subpages' dirty or young bits. IIUC, we could get the page size by page_size(pte_page(pte)). So, how about the following implementation of huge_ptep_get()? Does this work for you? pte_t huge_ptep_get(pte_t *ptep) { int ncontig, i; size_t pgsize; pte_t orig_pte = ptep_get(ptep); if (!pte_present(orig_pte) || !pte_cont(orig_pte)) return orig_pte; ncontig = num_contig_ptes(page_size(pte_page(orig_pte)), &pgsize); for (i = 0; i < ncontig; i++, ptep++) { pte_t pte = ptep_get(ptep); if (pte_dirty(pte)) orig_pte = pte_mkdirty(orig_pte); if (pte_young(pte)) orig_pte = pte_mkyoung(orig_pte); } return orig_pte; } > However we should add a new parameter for ARM64 specific huge_ptep_get() to check > how many continuous PTEs or PMDs in this CONT-PTE/PMD size hugetlb, that means we > should convert all the places using huge_ptep_get(), meanwhile most places using > huge_ptep_get() did not care about the dirty or young flags at all. > > So instead of changing the prototype of huge_ptep_get(), this patch set introduces > a new huge_ptep_get_access_flags() interface and define an ARM64 specific implementation, > that will take into account any subpages' dirty or young bits for CONT-PTE/PMD size > hugetlb page. And we can only change to use huge_ptep_get_access_flags() for those > functions that care about the dirty or young flags of a hugetlb page. > > [1] https://lore.kernel.org/linux-mm/85bd80b4-b4fd-0d3f-a2e5-149559f2f387@oracle.com/ > > Baolin Wang (3): > arm64/hugetlb: Introduce new huge_ptep_get_access_flags() interface > fs/proc/task_mmu: Change to use huge_ptep_get_access_flags() > mm/damon/vaddr: Change to use huge_ptep_get_access_flags() > > arch/arm64/include/asm/hugetlb.h | 2 ++ > arch/arm64/mm/hugetlbpage.c | 24 ++++++++++++++++++++++++ > fs/proc/task_mmu.c | 3 ++- > include/asm-generic/hugetlb.h | 7 +++++++ > mm/damon/vaddr.c | 5 +++-- > 5 files changed, 38 insertions(+), 3 deletions(-) > > -- > 1.8.3.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5B8DC433EF for ; Sun, 8 May 2022 15:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RY+3RMhNNhUFTCoL2xJDJFanpr9Y8SL4F3ZzRMHc7Cc=; b=Wf1XAOHE/AuunK DB+N3ZX3/GonSv4XrmRCC1JHkXA4wtE9K9dXHT1D+g8TL6MhcWLeGdspxixXY+tPxBcFB4y+SKhcf ezWZzi19DsIBR+4nwTDo3+NaeFZNnFKStjeXXCORPTkl0eFZQ7rKPbByM7R6NvsvEc0LyQGA72mfD XVNwuP/VaqfSdI+qsbt3IYdr4xrlqbs7/0v5pJl/Ng+LDBo+oAkavFkD70xv7J9QKrkCiAcK/Cm9K iZY7wobxbcoGOP/kzwKC4c1PucccFNSpohjTGUlWZ88XunrgI6Y/Qk6Xxn7iTIdg08WrCnT+wDCCz sosqt2LbYa7065ahah8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nninm-00AUax-OL; Sun, 08 May 2022 15:26:30 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nninj-00AUZa-5h for linux-arm-kernel@lists.infradead.org; Sun, 08 May 2022 15:26:29 +0000 Received: by mail-pf1-x42f.google.com with SMTP id 204so7468235pfx.3 for ; Sun, 08 May 2022 08:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wlb5sCv0vT9DKd6Y0pxChn3TRESHpDGd2RiWXJbPiOA=; b=A8uBy/esNOEbUqh4vOntGYm1YMVp8KTDNwiHyleMxFUxETUvcSv6DZ39zZIcwk5yYw 86UrDKPKDKAZMR7dwUoHWD+jUB4gtgw1yCKhEiU7ARnW49msAlzrKSzQ8vYFlTYpNIt4 hQLknIHiDmcV0B5wHAtIxy+UOOM5eEY20zDhI9WMiJaDrUjdvDVuVJ7iiy5qzG1y47jV 5gEm227YJe0hvNojSjOoSAN3C1iYnEXrtZFcNuKVuuM/p8p/52As0MlF3Mk2EzYn6wr/ J7bXPbCej7CVuXF4I6IX7/Rq1hiMYtnD6AFcfLgLxgY9EZUeI+It1LKO31oPmsw6uMey wxog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wlb5sCv0vT9DKd6Y0pxChn3TRESHpDGd2RiWXJbPiOA=; b=anHmAAOWOZ8V2HUSxgtJ7fSG4M9/C0j73nyUccRMr9P0Kc6Ke3pfAbMdcmss+4jj9d 2elpf1NfblnOpcWXdQLFLYMO4wEbQ74oOZd7rkNrZsQGPxwxvxdUtE4lDVyICSfW6cKj /oK6eeoWUDHpUNsXNRhAM1kIqUzGFBOrxWWNZKntQBBqbTn/7EQZtLmTRGohrxGqrUEN Y7CHjVHl4jaeWlcQk45PEyQBqQ+8zvGb9O2Lr4iRHy0JHoQdPjRpnq1Vn94Le2skOxhV E+BD4fWm22n26GJsn3WzAUqKGZhi+jjXHb/bLBYsm8q6Z/bU/SOtXv8huoskb+wNPEri ft2Q== X-Gm-Message-State: AOAM533BaX9mAR/f8AKPbGQF5NEZjzFkDwrxAMsEFLLlcSfm6OTNNOIe fmGuu4FVAjDf0pti0Zp0iN0hbQ== X-Google-Smtp-Source: ABdhPJwrAUBJu+P2n6cQJedLTi8BGUZ973hWDTaS8Y3nr73sK+kVeWZgWILLCvpX1mBPKLFMAkg+uw== X-Received: by 2002:aa7:9d0d:0:b0:50d:4fcc:7cb1 with SMTP id k13-20020aa79d0d000000b0050d4fcc7cb1mr11948987pfp.41.1652023584948; Sun, 08 May 2022 08:26:24 -0700 (PDT) Received: from localhost ([139.177.225.250]) by smtp.gmail.com with ESMTPSA id a19-20020a170902b59300b0015e8d4eb229sm5253221pls.115.2022.05.08.08.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 08:26:24 -0700 (PDT) Date: Sun, 8 May 2022 23:26:21 +0800 From: Muchun Song To: Baolin Wang Cc: catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mike.kravetz@oracle.com, akpm@linux-foundation.org, sj@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 0/3] Introduce new huge_ptep_get_access_flags() interface Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220508_082627_478287_CF6AA432 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 08, 2022 at 04:58:51PM +0800, Baolin Wang wrote: > Hi, > > As Mike pointed out [1], the huge_ptep_get() will only return one specific > pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which > will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD > size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD > size hugetlb page for those functions that want to check the dirty or > young flags of a hugetlb page. For example, the gather_hugetlb_stats() will > get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring > will also get inaccurate access statistics. > > To fix this issue, one approach is that we can define an ARM64 specific huge_ptep_get() > implementation, which will take into account any subpages' dirty or young bits. IIUC, we could get the page size by page_size(pte_page(pte)). So, how about the following implementation of huge_ptep_get()? Does this work for you? pte_t huge_ptep_get(pte_t *ptep) { int ncontig, i; size_t pgsize; pte_t orig_pte = ptep_get(ptep); if (!pte_present(orig_pte) || !pte_cont(orig_pte)) return orig_pte; ncontig = num_contig_ptes(page_size(pte_page(orig_pte)), &pgsize); for (i = 0; i < ncontig; i++, ptep++) { pte_t pte = ptep_get(ptep); if (pte_dirty(pte)) orig_pte = pte_mkdirty(orig_pte); if (pte_young(pte)) orig_pte = pte_mkyoung(orig_pte); } return orig_pte; } > However we should add a new parameter for ARM64 specific huge_ptep_get() to check > how many continuous PTEs or PMDs in this CONT-PTE/PMD size hugetlb, that means we > should convert all the places using huge_ptep_get(), meanwhile most places using > huge_ptep_get() did not care about the dirty or young flags at all. > > So instead of changing the prototype of huge_ptep_get(), this patch set introduces > a new huge_ptep_get_access_flags() interface and define an ARM64 specific implementation, > that will take into account any subpages' dirty or young bits for CONT-PTE/PMD size > hugetlb page. And we can only change to use huge_ptep_get_access_flags() for those > functions that care about the dirty or young flags of a hugetlb page. > > [1] https://lore.kernel.org/linux-mm/85bd80b4-b4fd-0d3f-a2e5-149559f2f387@oracle.com/ > > Baolin Wang (3): > arm64/hugetlb: Introduce new huge_ptep_get_access_flags() interface > fs/proc/task_mmu: Change to use huge_ptep_get_access_flags() > mm/damon/vaddr: Change to use huge_ptep_get_access_flags() > > arch/arm64/include/asm/hugetlb.h | 2 ++ > arch/arm64/mm/hugetlbpage.c | 24 ++++++++++++++++++++++++ > fs/proc/task_mmu.c | 3 ++- > include/asm-generic/hugetlb.h | 7 +++++++ > mm/damon/vaddr.c | 5 +++-- > 5 files changed, 38 insertions(+), 3 deletions(-) > > -- > 1.8.3.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel