From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH 2/2] slimbus: qcom: Remove unnecessary print function dev_err()
Date: Mon, 9 May 2022 15:42:36 +0200 [thread overview]
Message-ID: <YnkaTOk3SzcyFJyP@kroah.com> (raw)
In-Reply-To: <20220429165051.6187-3-srinivas.kandagatla@linaro.org>
On Fri, Apr 29, 2022 at 05:50:51PM +0100, Srinivas Kandagatla wrote:
> From: Yang Li <yang.lee@linux.alibaba.com>
>
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
> platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/slimbus/qcom-ctrl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index ec58091fc948..c0c4f895d76e 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
> }
>
> ctrl->irq = platform_get_irq(pdev, 0);
> - if (ctrl->irq < 0) {
> - dev_err(&pdev->dev, "no slimbus IRQ\n");
> + if (ctrl->irq < 0)
> return ctrl->irq;
> - }
>
> sctrl = &ctrl->ctrl;
> sctrl->dev = &pdev->dev;
> --
> 2.21.0
>
Does not apply to my tree :(
next prev parent reply other threads:[~2022-05-09 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 16:50 [PATCH 0/2] slimbus: patches for 5.19 Srinivas Kandagatla
2022-04-29 16:50 ` [PATCH 1/2] slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get the interrupt Srinivas Kandagatla
2022-04-29 16:50 ` [PATCH 2/2] slimbus: qcom: Remove unnecessary print function dev_err() Srinivas Kandagatla
2022-05-09 13:42 ` Greg KH [this message]
2022-05-10 9:49 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnkaTOk3SzcyFJyP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.