From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A43BC433EF for ; Tue, 10 May 2022 10:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239585AbiEJKMv (ORCPT ); Tue, 10 May 2022 06:12:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiEJKMl (ORCPT ); Tue, 10 May 2022 06:12:41 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF250185C85; Tue, 10 May 2022 03:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652177325; x=1683713325; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FEwpRe0W3NxiPGNEO5T4Th0jnvzANcK4YMMXxjuh76U=; b=kdq2FPsxM+RaYtG5iEDFtNXz54S01iJiIlrCh1nBn0X12zn5Um5blB/K Ic1xOCJvVhPdUNf/cPTfplnHCQaD1mQtzURC44mAO6VTt9MI8en/GIwx0 NxB/DQNMKTNvgL/ZAHy11T5AksMUI94w5hs0uDMrW/Dsb10EhVfH7LNSt TcNMuEmWtkfc7C6G3Bahh5PRVBIU5yugpJigRqbLYPO5dKi5+XTcTNjW+ lHDz2gy34PV2cejasf5fNQxr4/499MllCGtrH7WngPOO3dogbPIJzhq+A sgzQy+Pjm/FQvyHZD9JGfttZ6cZhRfPD3gx20zrNCG9AsGadJjoBNbaY3 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10342"; a="269464879" X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="269464879" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:08:35 -0700 X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="570605764" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:08:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1noMn3-00EI7L-0j; Tue, 10 May 2022 13:08:25 +0300 Date: Tue, 10 May 2022 13:08:24 +0300 From: Andy Shevchenko To: Tyrone Ting Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, wsa@kernel.org, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, sven@svenpeter.dev, jie.deng@intel.com, jsd@semihalf.com, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Message-ID: References: <20220510091654.8498-1-warp5tw@gmail.com> <20220510091654.8498-3-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510091654.8498-3-warp5tw@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 05:16:47PM +0800, Tyrone Ting wrote: > From: Tali Perry > > Change the way of getting NPCM system manager reigster (GCR) > and still maintain the old mechanism as a fallback if getting > nuvoton,sys-mgr fails while working with the legacy devicetree > file. ... > @@ -2236,6 +2236,7 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev) > static struct regmap *clk_regmap; > int irq; > int ret; > + struct device_node *np = pdev->dev.of_node; Can we keep "longer line first" order? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF2EAC433EF for ; Tue, 10 May 2022 10:10:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KyDLn1XFSz3bcj for ; Tue, 10 May 2022 20:10:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=U3/tZUC9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=U3/tZUC9; dkim-atps=neutral Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KyDL10BCnz3bZP for ; Tue, 10 May 2022 20:09:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652177385; x=1683713385; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FEwpRe0W3NxiPGNEO5T4Th0jnvzANcK4YMMXxjuh76U=; b=U3/tZUC9w4GsBGxzoAzAkL0MP+8RqQs9v8tOdbsZJnSOQ0YK8O+LGXTE ChfbuaBkgQYdeAbDoR4sGQ1qLesRSF0kvUmZtSSfK5oZ2j/IbtJ9RT4D1 rBg+TmiWWyU2sjrhMCYh51THPeOdp3ETyhqv6ybEMjDyXndBWwJBBVg49 6/oywa2TeuJHrPUdmxgAgWpvHzgv2Kukx+xswveK3xP/DJFMCK2gjsZbj A8l32Cj+74mDEzV/6G7Yy7RxIt3avKnXqDh3dunC/zz17Z3P7czK5HZ4o +jO06eaHSgy4sOQaU2N9OdXcnExkz5DRvaggCZajV/MSr1ZInLa2asMYS g==; X-IronPort-AV: E=McAfee;i="6400,9594,10342"; a="249857722" X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="249857722" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:08:35 -0700 X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="570605764" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:08:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1noMn3-00EI7L-0j; Tue, 10 May 2022 13:08:25 +0300 Date: Tue, 10 May 2022 13:08:24 +0300 From: Andy Shevchenko To: Tyrone Ting Subject: Re: [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Message-ID: References: <20220510091654.8498-1-warp5tw@gmail.com> <20220510091654.8498-3-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510091654.8498-3-warp5tw@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tmaimon77@gmail.com, devicetree@vger.kernel.org, tali.perry1@gmail.com, jsd@semihalf.com, benjaminfair@google.com, krzysztof.kozlowski@canonical.com, openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com, lukas.bulwahn@gmail.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, arnd@arndb.de, sven@svenpeter.dev, robh+dt@kernel.org, Avi.Fishman@nuvoton.com, semen.protsenko@linaro.org, jie.deng@intel.com, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, wsa@kernel.org, kfting@nuvoton.com, tali.perry@nuvoton.com, jarkko.nikula@linux.intel.com, olof@lixom.net, linux-i2c@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, May 10, 2022 at 05:16:47PM +0800, Tyrone Ting wrote: > From: Tali Perry > > Change the way of getting NPCM system manager reigster (GCR) > and still maintain the old mechanism as a fallback if getting > nuvoton,sys-mgr fails while working with the legacy devicetree > file. ... > @@ -2236,6 +2236,7 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev) > static struct regmap *clk_regmap; > int irq; > int ret; > + struct device_node *np = pdev->dev.of_node; Can we keep "longer line first" order? -- With Best Regards, Andy Shevchenko