All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org,
	linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>
Subject: Re: [xfstests PATCH 1/2] ext4/053: update the test_dummy_encryption tests
Date: Tue, 10 May 2022 10:53:35 -0400	[thread overview]
Message-ID: <Ynp8b+Gocx3A/NbW@mit.edu> (raw)
In-Reply-To: <YnASjrPbudBXCYfK@sol.localdomain>

On Mon, May 02, 2022 at 10:19:10AM -0700, Eric Biggers wrote:
> 
> We could gate them on the kernel version, similar to the whole ext4/053 which
> already only runs on kernel version 5.12.  (Kernel versions checks suck, but
> maybe it's the right choice for this very-nit-picky test.)  Alternatively, I
> could just backport "ext4: only allow test_dummy_encryption when supported" to
> 5.15, which would be the only relevant LTS kernel version.

If we don't need the "only allow test_dummy_encryption when supported"
in any Android, Distro, or LTS kernel --- which seems to be a
reasonable assumption, that seems to be OK.  Lukas, do you agree?

In the long term I suspect there will be times when we want to
backport mount option handling changes to older kernels, and we're
going to be hit this issue again, but as the saying goes, "sufficient
unto the day is the evil thereof".

     	 				- Ted
				

  reply	other threads:[~2022-05-10 15:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-01  5:19 [xfstests PATCH 0/2] update test_dummy_encryption testing in ext4/053 Eric Biggers
2022-05-01  5:19 ` [xfstests PATCH 1/2] ext4/053: update the test_dummy_encryption tests Eric Biggers
2022-05-02 12:46   ` tytso
2022-05-02 17:19     ` Eric Biggers
2022-05-10 14:53       ` Theodore Ts'o [this message]
2022-05-11  8:45         ` Lukas Czerner
2022-05-01  5:19 ` [xfstests PATCH 2/2] ext4/053: test changing test_dummy_encryption on remount Eric Biggers
2022-05-18 14:19 ` [xfstests PATCH 0/2] update test_dummy_encryption testing in ext4/053 Zorro Lang
2022-05-18 17:37   ` Eric Biggers
2022-05-18 18:16     ` Zorro Lang
2022-05-18 22:01       ` Eric Biggers
2022-05-19  4:47         ` Zorro Lang
2022-05-19  8:33           ` Lukas Czerner
2022-05-19 10:40             ` Zorro Lang
2022-05-19  8:10         ` Lukas Czerner
2022-05-19 10:58 ` Lukas Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ynp8b+Gocx3A/NbW@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.