From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20ACAC43219 for ; Tue, 10 May 2022 15:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345845AbiEJPh6 (ORCPT ); Tue, 10 May 2022 11:37:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346223AbiEJPg2 (ORCPT ); Tue, 10 May 2022 11:36:28 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF8C63C4 for ; Tue, 10 May 2022 08:32:30 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id u3so24357601wrg.3 for ; Tue, 10 May 2022 08:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ibDKLmqXZAEEFTExzRdfpLVElcsKcx9KbemDnOPns+k=; b=figfC27hBQ7YIl202+8UV+l1HErOFJIF9/fpjPlCPer5g3I7PjAtzfad9fQkyRxLjr 2Rn89ZkXFnj/ZtK9VRdPLP2LkZM3RIZHLXiPF7jTPH2sjLvKyJyyZhA8IU8nvYI6dAq8 eWWDHyE0BiwMx0ztz4HjHBdxVDNMORyJ3lEV0cf+voR+rNEqAWWKymQdZiy6Bu0isRA0 sx/2yAsnZP4Up/rDDDUE9k3t+Ayuee8qbQu+lddnI/2qPWWDITuddK7AaNrlWrBvSbHh +GKPURa/WCWQELR5zsHNR3B0osJYPBBuowvHljLEI/p32ixzYEuxagZ/9me25B5QZUhV zZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ibDKLmqXZAEEFTExzRdfpLVElcsKcx9KbemDnOPns+k=; b=OTlJfQoJWh3uEIrIZPpwjhBVVcXGClZn8A0zfYXq6iNwiOJ8hjB3thMJ7CTMBEmePa 651zq5ZuGlWDnXNj91tbrvhDfiqXyFsOFvgsh7kwZvMYUZuqzW1dF1xFJl5GxlLrILKt VzDIZLTub3aTzRPpNxvLzVqOqHuVOgxgjU5hkO6EmDNoXBHQ2uOBtDZOgsv/UEwNAUAz rbev8u1fQxTLGenX22sMnrsNd2r5h6okLaI62k4WUfAzr3d6qFSXUY9LJyVK8M65LdT/ djPam1UTuTbcgLfGbE2MX3M8G0gq8+7TbX55Id88J4yEsHPVbg3TAw3c4VOGNS0h9tCx yq+w== X-Gm-Message-State: AOAM530AN+8O15ADIQ6GO71DzVUJt0UpU7gszA/ir2N+9foNovAeGbFp WG19rTFTbzBsWfahlnohxsS+Kw== X-Google-Smtp-Source: ABdhPJxhbL0kXjtF40z+/oU1QTJ/WF63V5u/yXTZ1XONjVrTuv3E338FNMTKvYPqbqjTgY9CE4ly0A== X-Received: by 2002:a5d:4205:0:b0:20a:e23c:a7f4 with SMTP id n5-20020a5d4205000000b0020ae23ca7f4mr19616144wrq.576.1652196749233; Tue, 10 May 2022 08:32:29 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id x18-20020adfdd92000000b0020c5253d915sm13895707wrl.97.2022.05.10.08.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 08:32:28 -0700 (PDT) Date: Tue, 10 May 2022 16:32:26 +0100 From: Lee Jones To: Vladimir Oltean Cc: Colin Foster , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , Terry Bowman , Wolfram Sang , Andy Shevchenko , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil Subject: Re: [RFC v8 net-next 08/16] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-9-colin.foster@in-advantage.com> <20220509105239.wriaryaclzsq5ia3@skbuf> <20220509234922.GC895@COLIN-DESKTOP1.localdomain> <20220509172028.qcxzexnabovrdatq@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220509172028.qcxzexnabovrdatq@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 09 May 2022, Vladimir Oltean wrote: > On Mon, May 09, 2022 at 04:49:22PM -0700, Colin Foster wrote: > > > > +struct regmap *ocelot_init_regmap_from_resource(struct device *child, > > > > + const struct resource *res) > > > > +{ > > > > + struct device *dev = child->parent; > > > > + > > > > + return ocelot_spi_devm_init_regmap(dev, child, res); > > > > > > So much for being bus-agnostic :-/ > > > Maybe get the struct ocelot_ddata and call ocelot_spi_devm_init_regmap() > > > via a function pointer which is populated by ocelot-spi.c? If you do > > > that don't forget to clean up drivers/mfd/ocelot.h of SPI specific stuff. > > > > That was my initial design. "core" was calling into "spi" exclusively > > via function pointers. > > > > The request was "Please find a clearer way to do this without function > > pointers" > > > > https://lore.kernel.org/netdev/Ydwju35sN9QJqJ%2FP@google.com/ > > Yeah, I'm not sure what Lee was looking for, either. In any case I agree > with the comment that you aren't configuring a bus. In this context it > seems more appropriate to call this function pointer "init_regmap", with > different implementations per transport. FWIW, I'm still against using function pointers for this. What about making ocelot_init_regmap_from_resource() an inline function and pushing it into one of the header files? [As an aside, you don't need to pass both dev (parent) and child] In there you could simply do: inline struct regmap *ocelot_init_regmap_from_resource(struct device *dev, const struct resource *res) { if (dev_get_drvdata(dev->parent)->spi) return ocelot_spi_devm_init_regmap(dev, res); return NULL; } Also, do you really need devm in the title? > Or alternatively you could leave the "core"/"spi" pseudo-separation up > to the next person who needs to add support for some other register I/O > method. Or this. Your call. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D81EC433F5 for ; Tue, 10 May 2022 15:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MsX8INuh06YNb03nHF4NwgPUpt92t1kQ5SixYzuHs7E=; b=My0PpDzDjWp06x ltz9DtbRq36drY/Xy3z7qwHtvVtoy0Wzs8tBoLPuwQilqVi+YADHJQOMPkF0hNve/NZ/bfpi3oG63 W8IVCBp2XqOcapyfGoF/mFw0o0mbO0ws+UPOpEInrodiKA5U6kkJdtQodtGIQ8F6djAEllOiHo4vZ jIdzIG43yNOocrzoMCZHEthRimnr0Dta5OtB/V8AkGII+POIb7gxx5DCZIqrnJGvKtfP8mYeuG5rF TmZDt1t1Fh4eqhQjddQkGy+5ym0k8T7OVW2DO7BE2by6MyZrEEJFgPx8bZDl4GOmRpSJEuC2I3bLM OKkr1zWLfkZjojFDQRMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noRqn-002kOO-27; Tue, 10 May 2022 15:32:37 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noRqi-002kMs-UD for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 15:32:34 +0000 Received: by mail-wr1-x434.google.com with SMTP id v12so24311317wrv.10 for ; Tue, 10 May 2022 08:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ibDKLmqXZAEEFTExzRdfpLVElcsKcx9KbemDnOPns+k=; b=figfC27hBQ7YIl202+8UV+l1HErOFJIF9/fpjPlCPer5g3I7PjAtzfad9fQkyRxLjr 2Rn89ZkXFnj/ZtK9VRdPLP2LkZM3RIZHLXiPF7jTPH2sjLvKyJyyZhA8IU8nvYI6dAq8 eWWDHyE0BiwMx0ztz4HjHBdxVDNMORyJ3lEV0cf+voR+rNEqAWWKymQdZiy6Bu0isRA0 sx/2yAsnZP4Up/rDDDUE9k3t+Ayuee8qbQu+lddnI/2qPWWDITuddK7AaNrlWrBvSbHh +GKPURa/WCWQELR5zsHNR3B0osJYPBBuowvHljLEI/p32ixzYEuxagZ/9me25B5QZUhV zZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ibDKLmqXZAEEFTExzRdfpLVElcsKcx9KbemDnOPns+k=; b=ppyo3DnGb8UAejKRUOXRcbBXO8VBLv7gshyUHxEslso1gExbTY68jvgMBiEjq2e3/+ CL1Nw1KVf/CF59Qi/xSvfN/Y6QVODGzXT5+i0zKzl3Ilzdo7b3kk+d1Q0J22pGtOKWg+ BWoFN75vauznYHnmoRrLPQryDY6RbPrB+XVdAa0p0vXcXrOwO+1I3aGrt/DkSwF0f5Cq TTFA9dAT28gBUhklI/ZHgpFLeoPAwLIT1ycHlSRvw6QBusPDWYMswBR/dPmTWVcpq6yq 3APAMxWhCoLPtzz8YfQRVR/zBQzXnr1/mMD3OQBL7HYLKKPmqXP9rDNiyI/+48YYNuVt avJg== X-Gm-Message-State: AOAM533OENngr3e8fh/wUGjl4mJW7GCwWeFCy7D5k/4X3grutLHKe4zX qcu69nzsOZPhshab7+0b3CxW2Q== X-Google-Smtp-Source: ABdhPJxhbL0kXjtF40z+/oU1QTJ/WF63V5u/yXTZ1XONjVrTuv3E338FNMTKvYPqbqjTgY9CE4ly0A== X-Received: by 2002:a5d:4205:0:b0:20a:e23c:a7f4 with SMTP id n5-20020a5d4205000000b0020ae23ca7f4mr19616144wrq.576.1652196749233; Tue, 10 May 2022 08:32:29 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id x18-20020adfdd92000000b0020c5253d915sm13895707wrl.97.2022.05.10.08.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 08:32:28 -0700 (PDT) Date: Tue, 10 May 2022 16:32:26 +0100 From: Lee Jones To: Vladimir Oltean Cc: Colin Foster , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , Terry Bowman , Wolfram Sang , Andy Shevchenko , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil Subject: Re: [RFC v8 net-next 08/16] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-9-colin.foster@in-advantage.com> <20220509105239.wriaryaclzsq5ia3@skbuf> <20220509234922.GC895@COLIN-DESKTOP1.localdomain> <20220509172028.qcxzexnabovrdatq@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220509172028.qcxzexnabovrdatq@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_083233_013268_7D370BBA X-CRM114-Status: GOOD ( 24.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwOSBNYXkgMjAyMiwgVmxhZGltaXIgT2x0ZWFuIHdyb3RlOgoKPiBPbiBNb24sIE1h eSAwOSwgMjAyMiBhdCAwNDo0OToyMlBNIC0wNzAwLCBDb2xpbiBGb3N0ZXIgd3JvdGU6Cj4gPiA+ ID4gK3N0cnVjdCByZWdtYXAgKm9jZWxvdF9pbml0X3JlZ21hcF9mcm9tX3Jlc291cmNlKHN0cnVj dCBkZXZpY2UgKmNoaWxkLAo+ID4gPiA+ICsJCQkJCQljb25zdCBzdHJ1Y3QgcmVzb3VyY2UgKnJl cykKPiA+ID4gPiArewo+ID4gPiA+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gY2hpbGQtPnBhcmVu dDsKPiA+ID4gPiArCj4gPiA+ID4gKwlyZXR1cm4gb2NlbG90X3NwaV9kZXZtX2luaXRfcmVnbWFw KGRldiwgY2hpbGQsIHJlcyk7Cj4gPiA+IAo+ID4gPiBTbyBtdWNoIGZvciBiZWluZyBidXMtYWdu b3N0aWMgOi0vCj4gPiA+IE1heWJlIGdldCB0aGUgc3RydWN0IG9jZWxvdF9kZGF0YSBhbmQgY2Fs bCBvY2Vsb3Rfc3BpX2Rldm1faW5pdF9yZWdtYXAoKQo+ID4gPiB2aWEgYSBmdW5jdGlvbiBwb2lu dGVyIHdoaWNoIGlzIHBvcHVsYXRlZCBieSBvY2Vsb3Qtc3BpLmM/IElmIHlvdSBkbwo+ID4gPiB0 aGF0IGRvbid0IGZvcmdldCB0byBjbGVhbiB1cCBkcml2ZXJzL21mZC9vY2Vsb3QuaCBvZiBTUEkg c3BlY2lmaWMgc3R1ZmYuCj4gPiAKPiA+IFRoYXQgd2FzIG15IGluaXRpYWwgZGVzaWduLiAiY29y ZSIgd2FzIGNhbGxpbmcgaW50byAic3BpIiBleGNsdXNpdmVseQo+ID4gdmlhIGZ1bmN0aW9uIHBv aW50ZXJzLgo+ID4gCj4gPiBUaGUgcmVxdWVzdCB3YXMgIlBsZWFzZSBmaW5kIGEgY2xlYXJlciB3 YXkgdG8gZG8gdGhpcyB3aXRob3V0IGZ1bmN0aW9uCj4gPiBwb2ludGVycyIKPiA+IAo+ID4gaHR0 cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbmV0ZGV2L1lkd2p1MzVzTjlRSnFKJTJGUEBnb29nbGUuY29t Lwo+IAo+IFllYWgsIEknbSBub3Qgc3VyZSB3aGF0IExlZSB3YXMgbG9va2luZyBmb3IsIGVpdGhl ci4gSW4gYW55IGNhc2UgSSBhZ3JlZQo+IHdpdGggdGhlIGNvbW1lbnQgdGhhdCB5b3UgYXJlbid0 IGNvbmZpZ3VyaW5nIGEgYnVzLiBJbiB0aGlzIGNvbnRleHQgaXQKPiBzZWVtcyBtb3JlIGFwcHJv cHJpYXRlIHRvIGNhbGwgdGhpcyBmdW5jdGlvbiBwb2ludGVyICJpbml0X3JlZ21hcCIsIHdpdGgK PiBkaWZmZXJlbnQgaW1wbGVtZW50YXRpb25zIHBlciB0cmFuc3BvcnQuCgpGV0lXLCBJJ20gc3Rp bGwgYWdhaW5zdCB1c2luZyBmdW5jdGlvbiBwb2ludGVycyBmb3IgdGhpcy4KCldoYXQgYWJvdXQg bWFraW5nIG9jZWxvdF9pbml0X3JlZ21hcF9mcm9tX3Jlc291cmNlKCkgYW4gaW5saW5lCmZ1bmN0 aW9uIGFuZCBwdXNoaW5nIGl0IGludG8gb25lIG9mIHRoZSBoZWFkZXIgZmlsZXM/CgpbQXMgYW4g YXNpZGUsIHlvdSBkb24ndCBuZWVkIHRvIHBhc3MgYm90aCBkZXYgKHBhcmVudCkgYW5kIGNoaWxk XQoKSW4gdGhlcmUgeW91IGNvdWxkIHNpbXBseSBkbzoKCmlubGluZSBzdHJ1Y3QgcmVnbWFwICpv Y2Vsb3RfaW5pdF9yZWdtYXBfZnJvbV9yZXNvdXJjZShzdHJ1Y3QgZGV2aWNlICpkZXYsCgkJCQkJ CSAgICAgICBjb25zdCBzdHJ1Y3QgcmVzb3VyY2UgKnJlcykKewoJaWYgKGRldl9nZXRfZHJ2ZGF0 YShkZXYtPnBhcmVudCktPnNwaSkKCQlyZXR1cm4gb2NlbG90X3NwaV9kZXZtX2luaXRfcmVnbWFw KGRldiwgcmVzKTsKCglyZXR1cm4gTlVMTDsKfQoKQWxzbywgZG8geW91IHJlYWxseSBuZWVkIGRl dm0gaW4gdGhlIHRpdGxlPwoKPiBPciBhbHRlcm5hdGl2ZWx5IHlvdSBjb3VsZCBsZWF2ZSB0aGUg ImNvcmUiLyJzcGkiIHBzZXVkby1zZXBhcmF0aW9uIHVwCj4gdG8gdGhlIG5leHQgcGVyc29uIHdo byBuZWVkcyB0byBhZGQgc3VwcG9ydCBmb3Igc29tZSBvdGhlciByZWdpc3RlciBJL08KPiBtZXRo b2QuCgpPciB0aGlzLiAgWW91ciBjYWxsLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpQcmlu Y2lwYWwgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIg T3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29r IHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK