From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 267B9C433F5 for ; Wed, 11 May 2022 13:13:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id EBBE4C34111; Wed, 11 May 2022 13:13:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30003C34110; Wed, 11 May 2022 13:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652274788; bh=g6AP2mOn4r0mBHmFBWeCj8s1yPZtKg1jfCdKfza0eZ4=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=M3mQ8c4VGBxOq6FQQFXKXLjEngDx5roARmi4dVb0kmcgsv3oY1A4fXlrbO6usrpZX L0hTrzpKR/HI6nrXUi98i4+S9KNtGtfzhYpt4z2a93oEI9VlrhOk2VpfUL7NMvlQwV eCDTdX4GldGVHNyCl4aVCExlMHfQUz0Xh7XMQKZnPmvrR90nJINHapblFmgGIwP1H9 9SnQeUvh/gbvqRbgmQrDRKSUGNuzVe65bXEQEb/1eCy+J2S7PugRmi0Dv8gdbVwWY/ BRgG0d34tqafwcTYMZ760pAufNSdg4vnlr9vKkN3ZRbA7DmGNJfg0xaXiTJJhLqUCV wmb4aVqkU7Big== Date: Wed, 11 May 2022 14:13:03 +0100 From: Mark Brown To: Liviu Dudau List-Id: Cc: Carsten Haitzler , Sudeep Holla , carsten.haitzler@arm.com, soc@kernel.org, linux-arm-kernel@lists.infradead.org, Robin Murphy Subject: Re: [PATCH] arm64: defconfig: Enable modules for arm displays Message-ID: References: <20220509125510.152114-1-carsten.haitzler@foss.arm.com> <20220510111545.uqatdfthc6lv5p7i@bogus> <02ce0958-7e19-3315-a39f-548cf41e1f0b@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vj+Up9p+S45+hYAV" Content-Disposition: inline In-Reply-To: X-Cookie: Look ere ye leap. --vj+Up9p+S45+hYAV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 10, 2022 at 09:06:52PM +0100, Liviu Dudau wrote: > The quickest way is to harmonise the treatment of IRQs between tda998x an= d tda9950. > The former treats the IRQ as optional, the later as mandatory. Given that= (according > to comments in the code) TDA998X is actually a TDA9989+TDA9950, it makes = sense to > treat the lack of IRQ the same way (make it optional, IMHO). The check in tda9950 is sensible enough, the device relies on interrupts to report the status of CEC operations so we'd need to poll constantly which doesn't seem great. It wouldn't be *so* bad for things initiated by the device but given that CEC is a network and we might get messages =66rom other devices in the system at any time we'd need to poll constantly even when otherwise idle which doesn't seem good. I sent a patch to lower the level of the log message, hopefully that's OK for people. --vj+Up9p+S45+hYAV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJ7tl8ACgkQJNaLcl1U h9DFrgf/b4RpFBQ5m3hzH/EqEjhAZgef1qIQsozfhsHowAhxXaDA47nSo3LxvEt7 U3sMHsBX7C1Qy+DnjppjuKkXYOHQtB6q5U+nJFLROC+UK4/fh9z1Vn9eo1xkqsMI zXUZNIKhZUQVctlP23Dz/GLot5a9L++BQTNqfGW6KrvKOTcaJ9CTdqxX4OYc8ben GVj7VtyribCEneAVgVMSTwkSODmOc9hWWIDy3v3K46ZR3gpmzMjK78nkM9pHPxmE rlfk6admkcMmz1rgrXy6zVy/o1ObNJxYLFtLN9LWNw2k8x1KJk6cjHgHPlweWwq8 3Px8Zv9REJsTYhbp3HDfoyKl7jePOw== =u7zY -----END PGP SIGNATURE----- --vj+Up9p+S45+hYAV-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D15C433F5 for ; Wed, 11 May 2022 13:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tSda2s2t1is0F0g9CqhMsaK6k+LqKa8wE4kdoqq8Ll0=; b=iQCfE1Ks3NCNtyX1v3StG8wP5k ZTQ97rR9UxBEjN58Sqzw0VfjyDrxOnWvKTM4tlKqb6s+hbOSnRLrB61BNWEkVjjd/yerOpLGxQ1JH r+CELuIRgGRCLbw13q+pHdj6ZtDmdnYBCUH1kK72cRcurlcpwn6mqoucHOM03uKEYYTQXJcRjtVJx y/9HnKV3gG6dr9qKOwljQRDMzDWuzclwed53NZ5970nxQQaTQMzbWxV5Ms42DoU+LeGyyhv5dlLgn nqDh/FMDAj2ckk/5xkf/2xhcbu9ekTzAp46CmohP73P+Lc5VYWX1ofbx/D5GI7ei/P1+OHoyjg2Mt nNhwBzjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nom9T-006twK-AQ; Wed, 11 May 2022 13:13:15 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nom9P-006tvf-IO for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 13:13:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1E6E7B82357; Wed, 11 May 2022 13:13:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30003C34110; Wed, 11 May 2022 13:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652274788; bh=g6AP2mOn4r0mBHmFBWeCj8s1yPZtKg1jfCdKfza0eZ4=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=M3mQ8c4VGBxOq6FQQFXKXLjEngDx5roARmi4dVb0kmcgsv3oY1A4fXlrbO6usrpZX L0hTrzpKR/HI6nrXUi98i4+S9KNtGtfzhYpt4z2a93oEI9VlrhOk2VpfUL7NMvlQwV eCDTdX4GldGVHNyCl4aVCExlMHfQUz0Xh7XMQKZnPmvrR90nJINHapblFmgGIwP1H9 9SnQeUvh/gbvqRbgmQrDRKSUGNuzVe65bXEQEb/1eCy+J2S7PugRmi0Dv8gdbVwWY/ BRgG0d34tqafwcTYMZ760pAufNSdg4vnlr9vKkN3ZRbA7DmGNJfg0xaXiTJJhLqUCV wmb4aVqkU7Big== Date: Wed, 11 May 2022 14:13:03 +0100 From: Mark Brown To: Liviu Dudau Cc: Carsten Haitzler , Sudeep Holla , carsten.haitzler@arm.com, soc@kernel.org, linux-arm-kernel@lists.infradead.org, Robin Murphy Subject: Re: [PATCH] arm64: defconfig: Enable modules for arm displays Message-ID: References: <20220509125510.152114-1-carsten.haitzler@foss.arm.com> <20220510111545.uqatdfthc6lv5p7i@bogus> <02ce0958-7e19-3315-a39f-548cf41e1f0b@foss.arm.com> MIME-Version: 1.0 In-Reply-To: X-Cookie: Look ere ye leap. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_061311_784872_AD78CE8D X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1811191701455355097==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1811191701455355097== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vj+Up9p+S45+hYAV" Content-Disposition: inline --vj+Up9p+S45+hYAV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 10, 2022 at 09:06:52PM +0100, Liviu Dudau wrote: > The quickest way is to harmonise the treatment of IRQs between tda998x an= d tda9950. > The former treats the IRQ as optional, the later as mandatory. Given that= (according > to comments in the code) TDA998X is actually a TDA9989+TDA9950, it makes = sense to > treat the lack of IRQ the same way (make it optional, IMHO). The check in tda9950 is sensible enough, the device relies on interrupts to report the status of CEC operations so we'd need to poll constantly which doesn't seem great. It wouldn't be *so* bad for things initiated by the device but given that CEC is a network and we might get messages =66rom other devices in the system at any time we'd need to poll constantly even when otherwise idle which doesn't seem good. I sent a patch to lower the level of the log message, hopefully that's OK for people. --vj+Up9p+S45+hYAV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJ7tl8ACgkQJNaLcl1U h9DFrgf/b4RpFBQ5m3hzH/EqEjhAZgef1qIQsozfhsHowAhxXaDA47nSo3LxvEt7 U3sMHsBX7C1Qy+DnjppjuKkXYOHQtB6q5U+nJFLROC+UK4/fh9z1Vn9eo1xkqsMI zXUZNIKhZUQVctlP23Dz/GLot5a9L++BQTNqfGW6KrvKOTcaJ9CTdqxX4OYc8ben GVj7VtyribCEneAVgVMSTwkSODmOc9hWWIDy3v3K46ZR3gpmzMjK78nkM9pHPxmE rlfk6admkcMmz1rgrXy6zVy/o1ObNJxYLFtLN9LWNw2k8x1KJk6cjHgHPlweWwq8 3Px8Zv9REJsTYhbp3HDfoyKl7jePOw== =u7zY -----END PGP SIGNATURE----- --vj+Up9p+S45+hYAV-- --===============1811191701455355097== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1811191701455355097==--