From: Stephan Gerhold <stephan@gerhold.net>
To: Sireesh Kodali <sireeshkodali1@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, bjorn.andersson@linaro.org,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: msm8916: Fix typo in pronto remoteproc node
Date: Wed, 11 May 2022 19:51:32 +0200 [thread overview]
Message-ID: <Ynv3pE3gkLW39jNk@gerhold.net> (raw)
In-Reply-To: <20220510042654.71152-3-sireeshkodali1@gmail.com>
On Tue, May 10, 2022 at 09:56:54AM +0530, Sireesh Kodali wrote:
> The smem-state properties for the pronto node were incorrectly labelled,
> reading `qcom,state*` rather than `qcom,smem-state*`. Fix that, allowing
> the stop state to be used.
>
> Fixes: 88106096cbf8 ("ARM: dts: msm8916: Add and enable wcnss node")
>
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
Thanks for finding this!
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index e34963505e07..7ecd747dc624 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1758,8 +1758,8 @@ pronto: remoteproc@a21b000 {
> <&rpmpd MSM8916_VDDMX>;
> power-domain-names = "cx", "mx";
>
> - qcom,state = <&wcnss_smp2p_out 0>;
> - qcom,state-names = "stop";
> + qcom,smem-states = <&wcnss_smp2p_out 0>;
> + qcom,smem-state-names = "stop";
>
> pinctrl-names = "default";
> pinctrl-0 = <&wcnss_pin_a>;
> --
> 2.36.0
>
next prev parent reply other threads:[~2022-05-11 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 4:26 [PATCH 0/2] remoteproc: qcom: Fix handling of WCNSS IRQs Sireesh Kodali
2022-05-10 4:26 ` [PATCH 1/2] remoteproc: qcom: wcnss: Fix handling of IRQs Sireesh Kodali
2022-05-10 4:26 ` [PATCH 2/2] arm64: dts: qcom: msm8916: Fix typo in pronto remoteproc node Sireesh Kodali
2022-05-11 17:51 ` Stephan Gerhold [this message]
2022-05-11 18:11 ` Krzysztof Kozlowski
2022-05-12 9:37 ` Sireesh Kodali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynv3pE3gkLW39jNk@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sireeshkodali1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.