From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D377C4332F for ; Wed, 11 May 2022 19:51:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346786AbiEKTvS (ORCPT ); Wed, 11 May 2022 15:51:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347293AbiEKTvN (ORCPT ); Wed, 11 May 2022 15:51:13 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E391A3D4B0 for ; Wed, 11 May 2022 12:51:11 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id ch13so6069892ejb.12 for ; Wed, 11 May 2022 12:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=QUS04llQ/TQdvF3bJLtNkYv+9Y/6CRyA1IhJj03bD1ysf9ANin3YF7pIozL2ckCVd9 OEgvjLcrm/1wDU9oB6CTsdkJp6bSY0dGxFMc0XUZpQx5vjtv+lpaWgY+z91+b2dCfgUQ oJPZmG2v8C8OYJmWR8Lmy78eHPjrvYJULiRqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=ssUJuPFFzDqKxSqPiIVRxykPBt2uNXqhG6eRSQXH4vNzxVpkVC0vxxYPxTBsIihfbi ktLgyYxV09CkzceRuQmf2QKuYCUQaQLekwP12Ng1r7+TdkiaYpUpDr4dIrC5Ql5BK878 2wFvrnu9HRmsIDYaiGaIA4lWEz+3V2VgrP/JqU+62JmV5ToWp33oGRBG718ZeqtBUZgn +ThIhOP/oeyP5DEh9pkEHwmtLuWi2aQn6VetwUpH+XMbBmsR6z9YbxioCLB6qCbXYz51 +LARpBtt+vBXzcLEeUMRNwbkR8Cm0E3ZcFSzg1YfK2YYUv+WRcB360u9GNKQPyASv8ez rTwA== X-Gm-Message-State: AOAM532FuEDlLsKgFyt7SM0ev1MaSJSqpF0hmnfSD9kC42oHo6x/wcJO qXysd2DuNCaYjT+zvMj9QuUM9w== X-Google-Smtp-Source: ABdhPJzc30UDk4ot2UfqIn3JcPVtx5jKy3U9yzEWlwhCj1FbId8oXyy3bEiSM7KRq59c9iZ9/8xhUg== X-Received: by 2002:a17:906:b74b:b0:6f4:cd08:6fec with SMTP id fx11-20020a170906b74b00b006f4cd086fecmr28194512ejb.155.1652298670454; Wed, 11 May 2022 12:51:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id cb13-20020a0564020b6d00b0042617ba639asm1598568edb.36.2022.05.11.12.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:51:09 -0700 (PDT) Date: Wed, 11 May 2022 21:51:08 +0200 From: Daniel Vetter To: Mauro Carvalho Chehab Cc: Luis Chamberlain , Daniel Vetter , David Airlie , Greg KH , Jaroslav Kysela , Kai Vehmanen , Lucas De Marchi , Pierre-Louis Bossart , Takashi Iwai , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, mauro.chehab@linux.intel.com, Takashi Iwai Subject: Re: [PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver Message-ID: Mail-Followup-To: Mauro Carvalho Chehab , Luis Chamberlain , David Airlie , Greg KH , Jaroslav Kysela , Kai Vehmanen , Lucas De Marchi , Pierre-Louis Bossart , Takashi Iwai , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, mauro.chehab@linux.intel.com, Takashi Iwai References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: On Mon, May 09, 2022 at 06:23:39PM +0200, Mauro Carvalho Chehab wrote: > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that depends on > i915 driver. > > Ensure that a proper reference between the snd-hda driver needing > such binding is shown at /proc/modules, in order to allow userspace > to know about such binding. > > Reviewed-by: Takashi Iwai > Signed-off-by: Mauro Carvalho Chehab > --- > > See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mchehab@kernel.org/ > > sound/hda/hdac_component.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c > index bb37e7e0bd79..7789873ddf47 100644 > --- a/sound/hda/hdac_component.c > +++ b/sound/hda/hdac_component.c > @@ -199,7 +199,7 @@ static int hdac_component_master_bind(struct device *dev) > } > > /* pin the module to avoid dynamic unbinding, but only if given */ > - if (!try_module_get(acomp->ops->owner)) { > + if (!try_module_get_owner(acomp->ops->owner, dev->driver->owner)) { I'm still a bit confused why snd-hda does this and why this wasn't put into component.c, but that's kinda a pre-existing issue and I guess could be fixed later on. It really shouldn't be anything specific to snd-hda here. Anyway I scrolled through the series, it makes a lot more sense than the intial hack to me, so on the series: Acked-by: Daniel Vetter But maybe don't count that as real review :-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30EF3C433EF for ; Wed, 11 May 2022 19:51:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A350810EB0E; Wed, 11 May 2022 19:51:13 +0000 (UTC) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED66610EF9C for ; Wed, 11 May 2022 19:51:11 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id z2so6151833ejj.3 for ; Wed, 11 May 2022 12:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=QUS04llQ/TQdvF3bJLtNkYv+9Y/6CRyA1IhJj03bD1ysf9ANin3YF7pIozL2ckCVd9 OEgvjLcrm/1wDU9oB6CTsdkJp6bSY0dGxFMc0XUZpQx5vjtv+lpaWgY+z91+b2dCfgUQ oJPZmG2v8C8OYJmWR8Lmy78eHPjrvYJULiRqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=rRge9Nlcv/bULXcFM5u7ytKnOEAlt7FS2jp5+MJ70XqPFBM9cpQGg2bbMXfYzDFE4b JIk//4xptIg7hzzDNr8GIq61FH+b4NrJkmUnGUiYErUrKydePywx83/Um8OJSxIarLz5 w8a/7G49YWqpx48aHqjHB+ja3E0ZGGApqkl6KnpojA42qgaM8VIlNnsGiQ4v+Y2fu0HW oJvK0/jJIriuYQHTy1Vf3Uod7W5eGBJ6vEpmuwfmYW6DbpyPNTuPYWVDx4Gzcgz8wqBf RkeaMh8R05I3mY1FHXKGNJBXqXQSx0FAfPLSLWAie/CXdRfhy9RO7yAXQpLr83klYd/r pdhQ== X-Gm-Message-State: AOAM532XY8PiFr+6gZlYio8B1Td683kNlq2/epswsGNiY0W8wkDDpWkW rN2ufcPfJ7fsMK0S2xyLmLlEcA== X-Google-Smtp-Source: ABdhPJzc30UDk4ot2UfqIn3JcPVtx5jKy3U9yzEWlwhCj1FbId8oXyy3bEiSM7KRq59c9iZ9/8xhUg== X-Received: by 2002:a17:906:b74b:b0:6f4:cd08:6fec with SMTP id fx11-20020a170906b74b00b006f4cd086fecmr28194512ejb.155.1652298670454; Wed, 11 May 2022 12:51:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id cb13-20020a0564020b6d00b0042617ba639asm1598568edb.36.2022.05.11.12.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:51:09 -0700 (PDT) Date: Wed, 11 May 2022 21:51:08 +0200 From: Daniel Vetter To: Mauro Carvalho Chehab Subject: Re: [PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver Message-ID: Mail-Followup-To: Mauro Carvalho Chehab , Luis Chamberlain , David Airlie , Greg KH , Jaroslav Kysela , Kai Vehmanen , Lucas De Marchi , Pierre-Louis Bossart , Takashi Iwai , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, mauro.chehab@linux.intel.com, Takashi Iwai References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, mauro.chehab@linux.intel.com, David Airlie , Greg KH , intel-gfx@lists.freedesktop.org, Lucas De Marchi , Takashi Iwai , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Kai Vehmanen , Luis Chamberlain , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 09, 2022 at 06:23:39PM +0200, Mauro Carvalho Chehab wrote: > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that depends on > i915 driver. > > Ensure that a proper reference between the snd-hda driver needing > such binding is shown at /proc/modules, in order to allow userspace > to know about such binding. > > Reviewed-by: Takashi Iwai > Signed-off-by: Mauro Carvalho Chehab > --- > > See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mchehab@kernel.org/ > > sound/hda/hdac_component.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c > index bb37e7e0bd79..7789873ddf47 100644 > --- a/sound/hda/hdac_component.c > +++ b/sound/hda/hdac_component.c > @@ -199,7 +199,7 @@ static int hdac_component_master_bind(struct device *dev) > } > > /* pin the module to avoid dynamic unbinding, but only if given */ > - if (!try_module_get(acomp->ops->owner)) { > + if (!try_module_get_owner(acomp->ops->owner, dev->driver->owner)) { I'm still a bit confused why snd-hda does this and why this wasn't put into component.c, but that's kinda a pre-existing issue and I guess could be fixed later on. It really shouldn't be anything specific to snd-hda here. Anyway I scrolled through the series, it makes a lot more sense than the intial hack to me, so on the series: Acked-by: Daniel Vetter But maybe don't count that as real review :-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5D66C433EF for ; Wed, 11 May 2022 19:51:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 453CB10EA79; Wed, 11 May 2022 19:51:13 +0000 (UTC) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF43810F020 for ; Wed, 11 May 2022 19:51:11 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id j6so6074927ejc.13 for ; Wed, 11 May 2022 12:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=QUS04llQ/TQdvF3bJLtNkYv+9Y/6CRyA1IhJj03bD1ysf9ANin3YF7pIozL2ckCVd9 OEgvjLcrm/1wDU9oB6CTsdkJp6bSY0dGxFMc0XUZpQx5vjtv+lpaWgY+z91+b2dCfgUQ oJPZmG2v8C8OYJmWR8Lmy78eHPjrvYJULiRqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=FPa1tEezoxu+8UhrpSW+jJwKze9uyDhz2AoBH9MV8Wbw+Da0JTw/C0bNqao8V93NnO qPGhqrW9/Fd3fHKd2hr6oOqwK2wIPNwuCJKj6ieUZ3MUr3vOsJrQLmXS/eFfAB2xLbyf wIKjLBymJ3TFA+9k50QUooYwCHVtfTajJNK0RXeP8ci2O3n1VOHKsBPGbhqUqCieU9A6 Jh5uNPLk/bYKQIMm3BzpCbJwV7uRc8FHiI9pR5/1Cx/Zx6hY81q71WtOXIf9MlVQIXr9 tLfZ1dz1OTPu6ilq97emQoIewgrZNhD3Fv8N+m2ARZ6bDRISYhQr0UtwAn2dQG+CFmG6 4uWw== X-Gm-Message-State: AOAM532xtqs5tTX/wjlIYGlTQ9zWvZ+SKMuAU5iSagi3PLQNGKG4kLd5 4QgIxYyIWcxjrNmokewmjV138w== X-Google-Smtp-Source: ABdhPJzc30UDk4ot2UfqIn3JcPVtx5jKy3U9yzEWlwhCj1FbId8oXyy3bEiSM7KRq59c9iZ9/8xhUg== X-Received: by 2002:a17:906:b74b:b0:6f4:cd08:6fec with SMTP id fx11-20020a170906b74b00b006f4cd086fecmr28194512ejb.155.1652298670454; Wed, 11 May 2022 12:51:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id cb13-20020a0564020b6d00b0042617ba639asm1598568edb.36.2022.05.11.12.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:51:09 -0700 (PDT) Date: Wed, 11 May 2022 21:51:08 +0200 From: Daniel Vetter To: Mauro Carvalho Chehab Message-ID: Mail-Followup-To: Mauro Carvalho Chehab , Luis Chamberlain , David Airlie , Greg KH , Jaroslav Kysela , Kai Vehmanen , Lucas De Marchi , Pierre-Louis Bossart , Takashi Iwai , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, mauro.chehab@linux.intel.com, Takashi Iwai References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Subject: Re: [Intel-gfx] [PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, mauro.chehab@linux.intel.com, David Airlie , Greg KH , intel-gfx@lists.freedesktop.org, Takashi Iwai , Lucas De Marchi , Takashi Iwai , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Kai Vehmanen , Luis Chamberlain , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, May 09, 2022 at 06:23:39PM +0200, Mauro Carvalho Chehab wrote: > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that depends on > i915 driver. > > Ensure that a proper reference between the snd-hda driver needing > such binding is shown at /proc/modules, in order to allow userspace > to know about such binding. > > Reviewed-by: Takashi Iwai > Signed-off-by: Mauro Carvalho Chehab > --- > > See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mchehab@kernel.org/ > > sound/hda/hdac_component.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c > index bb37e7e0bd79..7789873ddf47 100644 > --- a/sound/hda/hdac_component.c > +++ b/sound/hda/hdac_component.c > @@ -199,7 +199,7 @@ static int hdac_component_master_bind(struct device *dev) > } > > /* pin the module to avoid dynamic unbinding, but only if given */ > - if (!try_module_get(acomp->ops->owner)) { > + if (!try_module_get_owner(acomp->ops->owner, dev->driver->owner)) { I'm still a bit confused why snd-hda does this and why this wasn't put into component.c, but that's kinda a pre-existing issue and I guess could be fixed later on. It really shouldn't be anything specific to snd-hda here. Anyway I scrolled through the series, it makes a lot more sense than the intial hack to me, so on the series: Acked-by: Daniel Vetter But maybe don't count that as real review :-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AE06C433EF for ; Wed, 11 May 2022 19:52:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 920C11A92; Wed, 11 May 2022 21:51:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 920C11A92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652298734; bh=rUTPYUhf+yXLlD+ZlHCeS+jaBDhLx8hw4GqXh9n/Sew=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H3MDN7iurrpjPxBiUTTcbIVtCBhfbyq4ohMCvcJ4Vpuu6lLwZUzStkjHPoM5uzdX2 x95HQgXylIg3AVfyK16dtl8wY2tAUcmMvNcvVbUorYV4ubx7zn7TWsRDaU1NTMhEyH M/NbPV5Czq3ej3P5aDlhUEwmDFw7TZS2CNh/HaFI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 130AAF80137; Wed, 11 May 2022 21:51:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 90779F8015B; Wed, 11 May 2022 21:51:22 +0200 (CEST) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EF177F80116 for ; Wed, 11 May 2022 21:51:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EF177F80116 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="QUS04llQ" Received: by mail-ej1-x630.google.com with SMTP id dk23so6109768ejb.8 for ; Wed, 11 May 2022 12:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=QUS04llQ/TQdvF3bJLtNkYv+9Y/6CRyA1IhJj03bD1ysf9ANin3YF7pIozL2ckCVd9 OEgvjLcrm/1wDU9oB6CTsdkJp6bSY0dGxFMc0XUZpQx5vjtv+lpaWgY+z91+b2dCfgUQ oJPZmG2v8C8OYJmWR8Lmy78eHPjrvYJULiRqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=okDasmSIedZIfDNVfGzL/C0tlLQxT7cXpy43/5U1qMo=; b=rlJgLs8IgccBdp7hFAOxst+q1mQ+RE5vZ6jAG52RBr/kU/FtuQS7+G8YZLlVc93Sz/ 2eExuGkv1rIo3idZrCNKvRTgX+gvMisyO4iqgShFdJBbSODcWFP/RO31tKR/VasAZ663 bfcoYc1UHNxkFIZ9lKvPEfVY1080Sdi7wkqJZjOZl+GHTs4J7ZGsFD4P+Q+eeoAlSfj0 Ugb4KgAju/gWbGttYYtp7WC98yOo0JqL5WD5m7sRS/VfcvKZtY8w96L55qOexvTGwwe3 RYiB6pzPvsLliYtCt3r2rCf3lB5tjaPLQp5c2R5RsyDgZUhUqfledwi8vEv90Z+PleR8 eKSQ== X-Gm-Message-State: AOAM532b/jXtjoZNIf/OC3gZzX1kpAOL42bFmHat5EEaYY/lOZ/PJ/yy 49SJRoT/4xQkMtM920FEIlNUWA== X-Google-Smtp-Source: ABdhPJzc30UDk4ot2UfqIn3JcPVtx5jKy3U9yzEWlwhCj1FbId8oXyy3bEiSM7KRq59c9iZ9/8xhUg== X-Received: by 2002:a17:906:b74b:b0:6f4:cd08:6fec with SMTP id fx11-20020a170906b74b00b006f4cd086fecmr28194512ejb.155.1652298670454; Wed, 11 May 2022 12:51:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id cb13-20020a0564020b6d00b0042617ba639asm1598568edb.36.2022.05.11.12.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:51:09 -0700 (PDT) Date: Wed, 11 May 2022 21:51:08 +0200 From: Daniel Vetter To: Mauro Carvalho Chehab Subject: Re: [PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver Message-ID: Mail-Followup-To: Mauro Carvalho Chehab , Luis Chamberlain , David Airlie , Greg KH , Jaroslav Kysela , Kai Vehmanen , Lucas De Marchi , Pierre-Louis Bossart , Takashi Iwai , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, mauro.chehab@linux.intel.com, Takashi Iwai References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 Cc: alsa-devel@alsa-project.org, mauro.chehab@linux.intel.com, David Airlie , Greg KH , intel-gfx@lists.freedesktop.org, Takashi Iwai , Lucas De Marchi , Takashi Iwai , dri-devel@lists.freedesktop.org, Kai Vehmanen , Luis Chamberlain , linux-modules@vger.kernel.org, Daniel Vetter , linux-kernel@vger.kernel.org, Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, May 09, 2022 at 06:23:39PM +0200, Mauro Carvalho Chehab wrote: > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that depends on > i915 driver. > > Ensure that a proper reference between the snd-hda driver needing > such binding is shown at /proc/modules, in order to allow userspace > to know about such binding. > > Reviewed-by: Takashi Iwai > Signed-off-by: Mauro Carvalho Chehab > --- > > See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mchehab@kernel.org/ > > sound/hda/hdac_component.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c > index bb37e7e0bd79..7789873ddf47 100644 > --- a/sound/hda/hdac_component.c > +++ b/sound/hda/hdac_component.c > @@ -199,7 +199,7 @@ static int hdac_component_master_bind(struct device *dev) > } > > /* pin the module to avoid dynamic unbinding, but only if given */ > - if (!try_module_get(acomp->ops->owner)) { > + if (!try_module_get_owner(acomp->ops->owner, dev->driver->owner)) { I'm still a bit confused why snd-hda does this and why this wasn't put into component.c, but that's kinda a pre-existing issue and I guess could be fixed later on. It really shouldn't be anything specific to snd-hda here. Anyway I scrolled through the series, it makes a lot more sense than the intial hack to me, so on the series: Acked-by: Daniel Vetter But maybe don't count that as real review :-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch