From: Stafford Horne <shorne@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org
Subject: Re: [PULL 3/4] Normalize header guard symbol definition
Date: Thu, 12 May 2022 06:28:32 +0900 [thread overview]
Message-ID: <YnwqgNjjYxLVkjR3@antec> (raw)
In-Reply-To: <20220511145922.3431407-4-armbru@redhat.com>
On Wed, May 11, 2022 at 04:59:21PM +0200, Markus Armbruster wrote:
> We commonly define the header guard symbol without an explicit value.
> Normalize the exceptions.
>
> Done with scripts/clean-header-guards.pl.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <20220506134911.2856099-4-armbru@redhat.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/exec/memopidx.h | 2 +-
> include/tcg/tcg-ldst.h | 2 +-
> target/alpha/cpu-param.h | 2 +-
> target/arm/cpu-param.h | 2 +-
> target/cris/cpu-param.h | 2 +-
> target/hppa/cpu-param.h | 2 +-
> target/i386/cpu-param.h | 2 +-
> target/m68k/cpu-param.h | 2 +-
> target/microblaze/cpu-param.h | 2 +-
> target/mips/cpu-param.h | 2 +-
> target/nios2/cpu-param.h | 2 +-
> target/openrisc/cpu-param.h | 2 +-
> target/ppc/cpu-param.h | 2 +-
> target/riscv/cpu-param.h | 2 +-
> target/s390x/cpu-param.h | 2 +-
> target/sh4/cpu-param.h | 2 +-
> target/sparc/cpu-param.h | 2 +-
> target/tricore/cpu-param.h | 2 +-
> target/xtensa/cpu-param.h | 2 +-
> tcg/tcg-internal.h | 2 +-
> 20 files changed, 20 insertions(+), 20 deletions(-)
I looked at this for the OpenRISC changes, but the whole patch looks ok to me.
Reviewed-by: Stafford Horne <shorne@gmail.com>
next prev parent reply other threads:[~2022-05-11 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 14:59 [PULL 0/4] Miscellaneous patches patches for 2022-05-11 Markus Armbruster
2022-05-11 14:59 ` [PULL 1/4] Clean up header guards that don't match their file name Markus Armbruster
2022-05-11 14:59 ` [PULL 2/4] Clean up ill-advised or unusual header guards Markus Armbruster
2022-05-11 14:59 ` [PULL 3/4] Normalize header guard symbol definition Markus Armbruster
2022-05-11 21:28 ` Stafford Horne [this message]
2022-05-11 14:59 ` [PULL 4/4] Clean up decorations and whitespace around header guards Markus Armbruster
2022-05-11 21:43 ` [PULL 0/4] Miscellaneous patches patches for 2022-05-11 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnwqgNjjYxLVkjR3@antec \
--to=shorne@gmail.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.