From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: Kees Cook <keescook@chromium.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"avimalin@gmail.com" <avimalin@gmail.com>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
"kafai@fb.com" <kafai@fb.com>,
"songliubraving@fb.com" <songliubraving@fb.com>,
"yhs@fb.com" <yhs@fb.com>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"kpsingh@kernel.org" <kpsingh@kernel.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"anil.s.keshavamurthy@intel.com" <anil.s.keshavamurthy@intel.com>,
"linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vaneet Narang <v.narang@samsung.com>,
Onkarnath <onkarnath.1@samsung.com>
Subject: Re: [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases
Date: Thu, 12 May 2022 12:53:05 +0300 [thread overview]
Message-ID: <YnzZASsT2Cy7COax@smile.fi.intel.com> (raw)
In-Reply-To: <20220512034650epcms5p3c0b90af240d837491fff020497f389e5@epcms5p3>
On Thu, May 12, 2022 at 09:16:50AM +0530, Maninder Singh wrote:
> > On Wed, May 11, 2022 at 01:36:56PM +0530, Maninder Singh wrote:
...
> > This is printing raw kernel addresses with no hashing, as far as I can
> > tell. That's not okay at all.
>
> yes same was suggested by Petr also, because earlier we were printing base address also as raw address.
>
> https://lkml.org/lkml/2022/2/28/847
>
> but then modified approach to print base address as hash when we are going to show offset of module address,
> but when we print complete address then we thought of keeping it same as it was:
>
> original:
> [12.487424] ps 0xffff800000eb008c
> with patch:
> [9.624152] ps 0xffff800001bd008c [crash]
>
> But if its has to be hashed, will fix that also.
In such case it should be a separate change since it will be the one that
changes behaviour.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-05-12 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220511080722epcas5p459493d02ff662a7c75590e44a11e34a6@epcas5p4.samsung.com>
2022-05-11 8:06 ` [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases Maninder Singh
[not found] ` <CGME20220511080728epcas5p2e377c38aba2e93dccc7fe8958e4724c2@epcas5p2.samsung.com>
2022-05-11 8:06 ` [PATCH 2/2] kallsyms: move sprint_module_info to kallsyms_tiny.c Maninder Singh
2022-05-11 22:32 ` [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases Kees Cook
[not found] ` <CGME20220511080722epcas5p459493d02ff662a7c75590e44a11e34a6@epcms5p3>
2022-05-12 3:46 ` Maninder Singh
2022-05-12 9:53 ` andriy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnzZASsT2Cy7COax@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=avimalin@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maninder1.s@samsung.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=onkarnath.1@samsung.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=songliubraving@fb.com \
--cc=v.narang@samsung.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.