From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E99C433EF for ; Thu, 26 May 2022 16:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244348AbiEZQlL (ORCPT ); Thu, 26 May 2022 12:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbiEZQlJ (ORCPT ); Thu, 26 May 2022 12:41:09 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA10C3B3C0 for ; Thu, 26 May 2022 09:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653583267; x=1685119267; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tjBaAbh6HrriUT68SvY0WLPr98BrVKnGVpNLD4OjveA=; b=KTDaH4gFvMvaH/yMPmsfyEDwmI0AnUFZwJKawOx8XXg7gmSCaahRAgPy uEEY9X2q8eRZHPq6RIr5nJoNatFb2A7CLbizzOnxCk2xoZn/1xM13/AYz Wx/kKkUbUP/08Uzv59Lz5PZsTics9YhB8AMmFli2RC0HlI46yea6mY7LA Mu33NIGUZbrrZFPdLvnHXLEurh3/X2XeB3wVBX6TywdVrLFafHHtSyRTH stF8UNfe4L1hRWZpGCZqCLmW4eKRWPJotFD7mW+QMJEC0hOl06bizPcej Uu1jkuJ+s0f4HVqmfAS1WU1nLEyfWhOGrSTihBR8MHmcSxvyGZbjm4FOd w==; X-IronPort-AV: E=McAfee;i="6400,9594,10359"; a="360599659" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="360599659" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 09:41:07 -0700 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="573973495" Received: from agluck-desk3.sc.intel.com ([172.25.222.78]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 09:41:07 -0700 Date: Thu, 26 May 2022 09:41:06 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Peter Zijlstra , X86 ML , LKML Subject: Re: Taint addresses Message-ID: References: <20220524185324.28395-1-bp@alien8.de> <20220524185324.28395-4-bp@alien8.de> <20220525065940.GF2578@worktop.programming.kicks-ass.net> <4644ff0530ba40948ed1f0e2e45a24d8@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022 at 02:11:12PM +0200, Borislav Petkov wrote: > I guess something like this: > > ... > [ 2.591532] x86/mm: Checked W+X mappings: passed, no W+X pages found. > [ 2.592678] CPU: 2 PID: 1 Comm: swapper/0 Tainted: G S C 5.18.0+ #7 > [ 2.593079] Last taint addresses: > [ 2.593079] S:start_kernel+0x614/0x634 > [ 2.593079] C:kernel_init+0x70/0x140 Maybe something a little more user friendly than addresses? If there was a new macro: #define add_taint(flag, lockdep) __add_taint(flag, lockdep, __FILE__, __LINE__) then renmame existing add_taint() to __add_taint() and have it save the file/line values. Then you could print filename:line Also: Is it more useful to store the most recent taint of each type, or the first of each type? -Tony