From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v4 4/5] platform/chrome: cros_kbd_led_backlight: support OF match
Date: Wed, 25 May 2022 11:33:25 +0800 [thread overview]
Message-ID: <Yo2jhTpsa5Vw4+61@google.com> (raw)
In-Reply-To: <Yo07IDqYuQUzeL+N@google.com>
On Tue, May 24, 2022 at 01:08:00PM -0700, Matthias Kaehlcke wrote:
> On Mon, May 23, 2022 at 05:08:21PM +0800, Tzung-Bi Shih wrote:
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id keyboard_led_of_match[] = {
> > + {
> > + .compatible = "google,cros-kbd-led-backlight",
> > + },
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(of, keyboard_led_of_match);
> > +#endif
> > +
> > static struct platform_driver keyboard_led_driver = {
> > .driver = {
> > .name = "chromeos-keyboard-leds",
> > .acpi_match_table = ACPI_PTR(keyboard_led_acpi_match),
> > + .of_match_table = of_match_ptr(keyboard_led_of_match),
>
> You need to put this assignment inside an '#ifdef CONFIG_OF' block,
> otherwise the compiler won't find 'keyboard_led_of_match' when
> CONFIG_OF isn't set.
It doesn't need as of_match_ptr() already guarded it.
next prev parent reply other threads:[~2022-05-25 3:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 9:08 [PATCH v4 0/5] platform/chrome: cros_kbd_led_backlight: add EC PWM backend Tzung-Bi Shih
2022-05-23 9:08 ` [PATCH v4 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically Tzung-Bi Shih
2022-05-23 9:08 ` [PATCH v4 2/5] platform/chrome: cros_kbd_led_backlight: separate ACPI backend Tzung-Bi Shih
2022-06-09 7:45 ` Tzung-Bi Shih
2022-06-09 12:44 ` Guenter Roeck
2022-05-23 9:08 ` [PATCH v4 3/5] dt-bindings: add google,cros-kbd-led-backlight Tzung-Bi Shih
2022-05-23 9:08 ` [PATCH v4 4/5] platform/chrome: cros_kbd_led_backlight: support OF match Tzung-Bi Shih
2022-05-24 20:08 ` Matthias Kaehlcke
2022-05-25 3:33 ` Tzung-Bi Shih [this message]
2022-05-25 15:11 ` Matthias Kaehlcke
2022-05-25 18:40 ` Prashant Malani
2022-05-23 9:08 ` [PATCH v4 5/5] platform/chrome: cros_kbd_led_backlight: support EC PWM backend Tzung-Bi Shih
2022-05-24 21:44 ` Matthias Kaehlcke
2022-05-24 0:50 ` [PATCH v4 0/5] platform/chrome: cros_kbd_led_backlight: add " patchwork-bot+chrome-platform
2022-05-24 1:28 ` Tzung-Bi Shih
2022-06-10 2:40 ` patchwork-bot+chrome-platform
2022-06-10 4:40 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo2jhTpsa5Vw4+61@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.